From 6559fa82a7905fd7bfe702f99bf81f07ca39299f Mon Sep 17 00:00:00 2001 From: "Thiago Marcos P. Santos" Date: Fri, 27 Mar 2020 18:30:35 +0200 Subject: [core] Fix readability-redundant-smartptr-get errors in header files As reported by clang-tidy-8. --- include/mbgl/style/color_ramp_property_value.hpp | 2 +- include/mbgl/util/image.hpp | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) (limited to 'include') diff --git a/include/mbgl/style/color_ramp_property_value.hpp b/include/mbgl/style/color_ramp_property_value.hpp index bc5639c899..1b9385f85f 100644 --- a/include/mbgl/style/color_ramp_property_value.hpp +++ b/include/mbgl/style/color_ramp_property_value.hpp @@ -27,7 +27,7 @@ public: ColorRampPropertyValue() : value(nullptr) {} ColorRampPropertyValue(std::shared_ptr value_) : value(std::move(value_)) {} - bool isUndefined() const { return value.get() == nullptr; } + bool isUndefined() const { return value == nullptr; } // noop, needed for batch evaluation of paint property values to compile template diff --git a/include/mbgl/util/image.hpp b/include/mbgl/util/image.hpp index e997c02223..75a49550b1 100644 --- a/include/mbgl/util/image.hpp +++ b/include/mbgl/util/image.hpp @@ -56,9 +56,7 @@ public: return !(lhs == rhs); } - bool valid() const { - return !size.isEmpty() && data.get() != nullptr; - } + bool valid() const { return !size.isEmpty() && data != nullptr; } template T clone() const { -- cgit v1.2.1