From 209857f8acc73d7950a1c8ec58f4ec7622287e55 Mon Sep 17 00:00:00 2001 From: Gali Nelle Date: Wed, 8 Apr 2020 16:28:35 +0300 Subject: Fix LocationIndicator Layer This changes image size properties to be scales instead of pixel sizes. The commit also adds fixes for handling image updates with the same ID, adds tests for expressions in paint properties, as well as tests for using images with pixel ratio greater than 1. Finally it moves image-tilt-displacement and perspective-compensation properties from layout to paint properties, and includes other minor cleanups. --- .../mbgl/style/layers/location_indicator_layer.hpp | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) (limited to 'include') diff --git a/include/mbgl/style/layers/location_indicator_layer.hpp b/include/mbgl/style/layers/location_indicator_layer.hpp index f112664dab..49720a2403 100644 --- a/include/mbgl/style/layers/location_indicator_layer.hpp +++ b/include/mbgl/style/layers/location_indicator_layer.hpp @@ -26,14 +26,6 @@ public: const PropertyValue& getBearingImage() const; void setBearingImage(const PropertyValue&); - static PropertyValue getDefaultImageTiltDisplacement(); - const PropertyValue& getImageTiltDisplacement() const; - void setImageTiltDisplacement(const PropertyValue&); - - static PropertyValue getDefaultPerspectiveCompensation(); - const PropertyValue& getPerspectiveCompensation() const; - void setPerspectiveCompensation(const PropertyValue&); - static PropertyValue getDefaultShadowImage(); const PropertyValue& getShadowImage() const; void setShadowImage(const PropertyValue&); @@ -74,12 +66,24 @@ public: void setBearingImageSizeTransition(const TransitionOptions&); TransitionOptions getBearingImageSizeTransition() const; + static PropertyValue getDefaultImageTiltDisplacement(); + const PropertyValue& getImageTiltDisplacement() const; + void setImageTiltDisplacement(const PropertyValue&); + void setImageTiltDisplacementTransition(const TransitionOptions&); + TransitionOptions getImageTiltDisplacementTransition() const; + static PropertyValue> getDefaultLocation(); const PropertyValue>& getLocation() const; void setLocation(const PropertyValue>&); void setLocationTransition(const TransitionOptions&); TransitionOptions getLocationTransition() const; + static PropertyValue getDefaultPerspectiveCompensation(); + const PropertyValue& getPerspectiveCompensation() const; + void setPerspectiveCompensation(const PropertyValue&); + void setPerspectiveCompensationTransition(const TransitionOptions&); + TransitionOptions getPerspectiveCompensationTransition() const; + static PropertyValue getDefaultShadowImageSize(); const PropertyValue& getShadowImageSize() const; void setShadowImageSize(const PropertyValue&); -- cgit v1.2.1