From ea2477f2ea9f1ccebe0263104ad13d729fdbcfdf Mon Sep 17 00:00:00 2001 From: "Thiago Marcos P. Santos" Date: Fri, 27 Mar 2020 18:30:35 +0200 Subject: [core] Fix performance-no-automatic-move (bonus) As reported by clang-tidy-10. We don't run clang-tidy-10 yet. We should probably consider moving the bots at some point so errors like this won't return. --- include/mbgl/style/expression/let.hpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'include/mbgl/style/expression/let.hpp') diff --git a/include/mbgl/style/expression/let.hpp b/include/mbgl/style/expression/let.hpp index 7c468dfeb1..a03c4b7d70 100644 --- a/include/mbgl/style/expression/let.hpp +++ b/include/mbgl/style/expression/let.hpp @@ -49,8 +49,8 @@ private: class Var : public Expression { public: - Var(std::string name_, const std::shared_ptr& value_) - : Expression(Kind::Var, value_->getType()), name(std::move(name_)), value(value_) {} + Var(std::string name_, std::shared_ptr value_) + : Expression(Kind::Var, value_->getType()), name(std::move(name_)), value(std::move(value_)) {} static ParseResult parse(const mbgl::style::conversion::Convertible&, ParsingContext&); -- cgit v1.2.1