From ef8540b68373d2474449e6e5f17eaaaaab7c7f9a Mon Sep 17 00:00:00 2001 From: Mikhail Pozdnyakov Date: Tue, 8 Oct 2019 22:54:54 +0300 Subject: [core] Update ImageManager.OnStyleImageMissingBeforeSpriteLoaded unit test So that it checks missing images requests coalescing. --- test/renderer/image_manager.test.cpp | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/test/renderer/image_manager.test.cpp b/test/renderer/image_manager.test.cpp index 16700d713f..f1061ce59e 100644 --- a/test/renderer/image_manager.test.cpp +++ b/test/renderer/image_manager.test.cpp @@ -187,6 +187,20 @@ TEST(ImageManager, OnStyleImageMissingBeforeSpriteLoaded) { EXPECT_EQ(observer.count, 1); ASSERT_TRUE(notified); + // Repeated request of the same image shall not result another + // `ImageManagerObserver.onStyleImageMissing()` call. + imageManager.getImages(requestor, std::make_pair(dependencies, imageCorrelationID)); + runLoop.runOnce(); + + EXPECT_EQ(observer.count, 1); + + // Request for updated dependencies must be dispatched to the + // observer. + dependencies.emplace("post", ImageType::Icon); + imageManager.getImages(requestor, std::make_pair(dependencies, imageCorrelationID)); + runLoop.runOnce(); + + EXPECT_EQ(observer.count, 2); } TEST(ImageManager, OnStyleImageMissingAfterSpriteLoaded) { -- cgit v1.2.1