From ec8e1e78445c3fcbd2ab90312918ccf03fb58873 Mon Sep 17 00:00:00 2001 From: John Firebaugh Date: Wed, 29 Aug 2018 12:49:07 -0700 Subject: [android] Explicitly delete local JNI references This method seems to be called in a loop, leading to a local reference table overflow if not explicitly deleted. See https://github.com/mapbox/mapbox-gl-native/pull/12716#pullrequestreview-150462731 --- platform/android/src/logger.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/platform/android/src/logger.cpp b/platform/android/src/logger.cpp index 1cc7660716..0ade914604 100644 --- a/platform/android/src/logger.cpp +++ b/platform/android/src/logger.cpp @@ -28,6 +28,9 @@ void Logger::log(jni::JNIEnv& env, EventSeverity severity, const std::string &ms auto static error = _class.GetStaticMethod(env, "e"); _class.Call(env, error, tag, message); } + + DeleteLocalRef(env, tag); + DeleteLocalRef(env, message); } } // namespace android -- cgit v1.2.1