From de6c1d914a6b22e6cbfe8bbdae09a9c0d8af274b Mon Sep 17 00:00:00 2001 From: Tobrun Van Nuland Date: Fri, 28 Jul 2017 15:33:30 +0200 Subject: fixup --- .../android/MapboxGLAndroidSDKTestApp/build.gradle | 2 +- .../lint-baseline-local.xml | 15 ------ .../lint/lint-baseline-ci.xml | 55 +++++++++------------- 3 files changed, 23 insertions(+), 49 deletions(-) diff --git a/platform/android/MapboxGLAndroidSDKTestApp/build.gradle b/platform/android/MapboxGLAndroidSDKTestApp/build.gradle index 1e4af3acf6..360cb36067 100644 --- a/platform/android/MapboxGLAndroidSDKTestApp/build.gradle +++ b/platform/android/MapboxGLAndroidSDKTestApp/build.gradle @@ -28,7 +28,7 @@ android { baseline file("lint-baseline-local.xml") checkAllWarnings true warningsAsErrors true - disable 'MissingTranslation', 'GoogleAppIndexingWarning', 'UnpackedNativeCode' + disable 'MissingTranslation', 'GoogleAppIndexingWarning', 'UnpackedNativeCode', 'IconDipSize' } buildTypes { diff --git a/platform/android/MapboxGLAndroidSDKTestApp/lint-baseline-local.xml b/platform/android/MapboxGLAndroidSDKTestApp/lint-baseline-local.xml index 3e66b617b2..e3c5abce4f 100644 --- a/platform/android/MapboxGLAndroidSDKTestApp/lint-baseline-local.xml +++ b/platform/android/MapboxGLAndroidSDKTestApp/lint-baseline-local.xml @@ -56,21 +56,6 @@ column="55"/> - - - - - - - - diff --git a/platform/android/MapboxGLAndroidSDKTestApp/lint/lint-baseline-ci.xml b/platform/android/MapboxGLAndroidSDKTestApp/lint/lint-baseline-ci.xml index d2fdb3d34b..64e3d41bcc 100644 --- a/platform/android/MapboxGLAndroidSDKTestApp/lint/lint-baseline-ci.xml +++ b/platform/android/MapboxGLAndroidSDKTestApp/lint/lint-baseline-ci.xml @@ -6,61 +6,50 @@ from lint-baseline-local.xml file) you should remove it too from lint-baseline-ci.xml (THIS FILE) which is the only one included in the repo. Eventually, it'll be removed (when we remove all current lint errors included). --> - - + + - - - - + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~" + id="Overdraw" + message="Possible overdraw: Root element paints background `#cccc` with a theme that also paints a background (inferred theme is `@style/AppTheme`)"> + line="4"/> + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~" + id="Overdraw" + message="Possible overdraw: Root element paints background `?android:attr/selectableItemBackground` with a theme that also paints a background (inferred theme is `@style/AppTheme`)"> + line="6"/> + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~" + id="Overdraw" + message="Possible overdraw: Root element paints background `@color/mapboxGreen` with a theme that also paints a background (inferred theme is `@style/AppTheme`)"> + line="5"/> + errorLine2=" ^" + id="TypographyQuotes" + message="Replace straight quotes ('') with directional quotes (‘’, ‘ and ’) ?"> + line="9"/>