From ad53132e5d56fbd0ae90cfde2e2b26977ad0b433 Mon Sep 17 00:00:00 2001 From: Mikhail Pozdnyakov Date: Wed, 5 Jun 2019 16:41:14 +0300 Subject: [core] Inherit RenderAnnotationSource from RenderTileSource --- src/mbgl/annotation/render_annotation_source.cpp | 37 +----------------------- src/mbgl/annotation/render_annotation_source.hpp | 22 ++------------ 2 files changed, 4 insertions(+), 55 deletions(-) diff --git a/src/mbgl/annotation/render_annotation_source.cpp b/src/mbgl/annotation/render_annotation_source.cpp index ada6ec5ea9..123a776754 100644 --- a/src/mbgl/annotation/render_annotation_source.cpp +++ b/src/mbgl/annotation/render_annotation_source.cpp @@ -10,7 +10,7 @@ namespace mbgl { using namespace style; RenderAnnotationSource::RenderAnnotationSource(Immutable impl_) - : RenderSource(impl_) { + : RenderTileSource(std::move(impl_)) { assert(LayerManager::annotationsEnabled); tilePyramid.setObserver(this); } @@ -19,10 +19,6 @@ const AnnotationSource::Impl& RenderAnnotationSource::impl() const { return static_cast(*baseImpl); } -bool RenderAnnotationSource::isLoaded() const { - return tilePyramid.isLoaded(); -} - void RenderAnnotationSource::update(Immutable baseImpl_, const std::vector>& layers, const bool needsRendering, @@ -47,30 +43,6 @@ void RenderAnnotationSource::update(Immutable baseImpl_, }); } -void RenderAnnotationSource::upload(gfx::UploadPass& uploadPass) { - tilePyramid.upload(uploadPass); -} - -void RenderAnnotationSource::prepare(const SourcePrepareParameters& parameters) { - tilePyramid.prepare(parameters); -} - -void RenderAnnotationSource::finishRender(PaintParameters& parameters) { - tilePyramid.finishRender(parameters); -} - -void RenderAnnotationSource::updateFadingTiles() { - tilePyramid.updateFadingTiles(); -} - -bool RenderAnnotationSource::hasFadingTiles() const { - return tilePyramid.hasFadingTiles(); -} - -std::vector> RenderAnnotationSource::getRenderTiles() { - return tilePyramid.getRenderTiles(); -} - std::unordered_map> RenderAnnotationSource::queryRenderedFeatures(const ScreenLineString& geometry, const TransformState& transformState, @@ -84,12 +56,5 @@ std::vector RenderAnnotationSource::querySourceFeatures(const SourceQue return {}; } -void RenderAnnotationSource::reduceMemoryUse() { - tilePyramid.reduceMemoryUse(); -} - -void RenderAnnotationSource::dumpDebugLogs() const { - tilePyramid.dumpDebugLogs(); -} } // namespace mbgl diff --git a/src/mbgl/annotation/render_annotation_source.hpp b/src/mbgl/annotation/render_annotation_source.hpp index c427da16d5..e5d5130446 100644 --- a/src/mbgl/annotation/render_annotation_source.hpp +++ b/src/mbgl/annotation/render_annotation_source.hpp @@ -1,16 +1,13 @@ #pragma once -#include -#include #include +#include namespace mbgl { -class RenderAnnotationSource : public RenderSource { +class RenderAnnotationSource final : public RenderTileSource { public: - RenderAnnotationSource(Immutable); - - bool isLoaded() const final; + explicit RenderAnnotationSource(Immutable); void update(Immutable, const std::vector>&, @@ -18,14 +15,6 @@ public: bool needsRelayout, const TileParameters&) final; - void upload(gfx::UploadPass&) final; - void prepare(const SourcePrepareParameters&) final; - void finishRender(PaintParameters&) final; - void updateFadingTiles() final; - bool hasFadingTiles() const final; - - std::vector> getRenderTiles() final; - std::unordered_map> queryRenderedFeatures(const ScreenLineString& geometry, const TransformState& transformState, @@ -36,13 +25,8 @@ public: std::vector querySourceFeatures(const SourceQueryOptions&) const final; - void reduceMemoryUse() final; - void dumpDebugLogs() const final; - private: const AnnotationSource::Impl& impl() const; - - TilePyramid tilePyramid; }; template <> -- cgit v1.2.1