From ad1d48af987dd43ec8c8dd298d8ef1962ac0b695 Mon Sep 17 00:00:00 2001 From: tobrun Date: Tue, 20 Aug 2019 11:06:26 +0200 Subject: [android] update javadoc on style image missing --- platform/android/CHANGELOG.md | 3 +++ .../src/main/java/com/mapbox/mapboxsdk/maps/MapView.java | 8 ++++++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/platform/android/CHANGELOG.md b/platform/android/CHANGELOG.md index 8d0030b397..598d12d601 100644 --- a/platform/android/CHANGELOG.md +++ b/platform/android/CHANGELOG.md @@ -9,6 +9,9 @@ Mapbox welcomes participation and contributions from everyone. If you'd like to - Font lookup on pre lollipop devices failed, provide default font list instead [#15410](https://github.com/mapbox/mapbox-gl-native/pull/15410). - Fixed rendering and collision detection issues with using `text-variable-anchor` and `icon-text-fit` properties on the same layer [#15367](https://github.com/mapbox/mapbox-gl-native/pull/15367). +### Docs + - Add javadoc to OnStyleImageMissingListener indicating the required synchronous addition images, document workaround [#15418](https://github.com/mapbox/mapbox-gl-native/pull/15418) + ## 8.3.0-alpha.3 - August 15, 2019 [Changes](https://github.com/mapbox/mapbox-gl-native/compare/android-v8.3.0-alpha.2...android-v8.3.0-alpha.3) since [Mapbox Maps SDK for Android v8.3.0-alpha.2](https://github.com/mapbox/mapbox-gl-native/releases/tag/android-v8.3.0-alpha.2): diff --git a/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapView.java b/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapView.java index 1367de8729..4521d2ae60 100644 --- a/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapView.java +++ b/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapView.java @@ -1013,14 +1013,18 @@ public class MapView extends FrameLayout implements NativeMapView.ViewCallback { } /** - * Interface definition for a callback to be invoked with the id of a missing icon. + * Interface definition for a callback to be invoked with the id of a missing icon. The icon should be added + * synchronously with {@link Style#addImage(String, Bitmap)} to be rendered on the current zoom level. When loading + * icons asynchronously, you can load a placeholder image and replace it when you icon has loaded. *

* {@link MapView#addOnStyleImageMissingListener(OnStyleImageMissingListener)} *

*/ public interface OnStyleImageMissingListener { /** - * Called when the map is missing an icon. + * Called when the map is missing an icon.The icon should be added synchronously with + * {@link Style#addImage(String, Bitmap)} to be rendered on the current zoom level. When loading icons + * asynchronously, you can load a placeholder image and replace it when you icon has loaded. * * @param id the id of the icon that is missing */ -- cgit v1.2.1