From aabc7e9afbd872fcba0467c1ab002c2004edb6e5 Mon Sep 17 00:00:00 2001 From: "M.Stephen" Date: Fri, 13 Dec 2019 17:42:52 +0800 Subject: refactor --- platform/darwin/include/mbgl/interface/native_apple_interface.h | 6 ------ platform/darwin/src/http_file_source.mm | 3 --- platform/darwin/src/native_apple_interface.m | 4 +++- 3 files changed, 3 insertions(+), 10 deletions(-) diff --git a/platform/darwin/include/mbgl/interface/native_apple_interface.h b/platform/darwin/include/mbgl/interface/native_apple_interface.h index 59e5d5431f..d4d207462d 100644 --- a/platform/darwin/include/mbgl/interface/native_apple_interface.h +++ b/platform/darwin/include/mbgl/interface/native_apple_interface.h @@ -36,12 +36,6 @@ NS_ASSUME_NONNULL_BEGIN @property (nonatomic, readonly) NSURLSessionConfiguration *sessionConfiguration; -/* - For testing. Since we get a `nil` return when SDK is modualar, we use this for testing network. - Same as `[MGLNetworkConfiguration defaultSessionConfiguration]` in `MGLNetworkConfiguration.m`. - */ -@property (nonatomic, readonly) NSURLSessionConfiguration *testSessionConfiguration; - - (void)startDownloadEvent:(NSString *)event type:(NSString *)type; - (void)cancelDownloadEventForResponse:(NSURLResponse *)response; diff --git a/platform/darwin/src/http_file_source.mm b/platform/darwin/src/http_file_source.mm index a5f0f8dbb7..6f68111203 100644 --- a/platform/darwin/src/http_file_source.mm +++ b/platform/darwin/src/http_file_source.mm @@ -84,9 +84,6 @@ public: Impl() { @autoreleasepool { NSURLSessionConfiguration *sessionConfig = MGLNativeNetworkManager.sharedManager.sessionConfiguration; - if (!sessionConfig) { - sessionConfig = MGLNativeNetworkManager.sharedManager.testSessionConfiguration; - } session = [NSURLSession sessionWithConfiguration:sessionConfig]; userAgent = getUserAgent(); diff --git a/platform/darwin/src/native_apple_interface.m b/platform/darwin/src/native_apple_interface.m index 7401681e56..07dce0d5b0 100644 --- a/platform/darwin/src/native_apple_interface.m +++ b/platform/darwin/src/native_apple_interface.m @@ -17,7 +17,9 @@ static MGLNativeNetworkManager *instance = nil; if (_delegate && [_delegate respondsToSelector:@selector(sessionConfiguration)]) { return [_delegate sessionConfiguration]; } - return nil; + // For testing. Since we get a `nil` return when SDK is modualar, we use this for testing requests. + // Same as `[MGLNetworkConfiguration defaultSessionConfiguration]` in `MGLNetworkConfiguration.m`. + return [self testSessionConfiguration]; } - (NSURLSessionConfiguration *)testSessionConfiguration { -- cgit v1.2.1