From 9a1bb1ad14e18433d4cc8e805af57a6014275561 Mon Sep 17 00:00:00 2001 From: John Firebaugh Date: Mon, 30 Jul 2018 15:04:41 -0700 Subject: [core] Tweak conversions to reduce binary size MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * return {} → return nullopt * error = { "..." } → error.message = "..." --- cmake/core-files.cmake | 2 + .../style/conversion/color_ramp_property_value.hpp | 32 +-- include/mbgl/style/conversion/constant.hpp | 16 +- .../conversion/custom_geometry_source_options.hpp | 69 +------ .../conversion/data_driven_property_value.hpp | 14 +- include/mbgl/style/conversion/function.hpp | 6 +- include/mbgl/style/conversion/property_value.hpp | 18 +- .../style/conversion/color_ramp_property_value.cpp | 42 ++++ src/mbgl/style/conversion/constant.cpp | 36 ++-- src/mbgl/style/conversion/coordinate.cpp | 12 +- .../conversion/custom_geometry_source_options.cpp | 75 +++++++ src/mbgl/style/conversion/filter.cpp | 60 +++--- src/mbgl/style/conversion/function.cpp | 218 ++++++++++----------- src/mbgl/style/conversion/geojson_options.cpp | 28 +-- src/mbgl/style/conversion/layer.cpp | 72 +++---- src/mbgl/style/conversion/light.cpp | 20 +- src/mbgl/style/conversion/position.cpp | 2 +- src/mbgl/style/conversion/property_setter.hpp | 8 +- src/mbgl/style/conversion/source.cpp | 74 +++---- src/mbgl/style/conversion/tileset.cpp | 42 ++-- src/mbgl/style/conversion/transition_options.cpp | 12 +- 21 files changed, 440 insertions(+), 418 deletions(-) create mode 100644 src/mbgl/style/conversion/color_ramp_property_value.cpp create mode 100644 src/mbgl/style/conversion/custom_geometry_source_options.cpp diff --git a/cmake/core-files.cmake b/cmake/core-files.cmake index e9f70378ad..f2e26a9a7e 100644 --- a/cmake/core-files.cmake +++ b/cmake/core-files.cmake @@ -426,8 +426,10 @@ set(MBGL_CORE_FILES include/mbgl/style/conversion/source.hpp include/mbgl/style/conversion/tileset.hpp include/mbgl/style/conversion/transition_options.hpp + src/mbgl/style/conversion/color_ramp_property_value.cpp src/mbgl/style/conversion/constant.cpp src/mbgl/style/conversion/coordinate.cpp + src/mbgl/style/conversion/custom_geometry_source_options.cpp src/mbgl/style/conversion/filter.cpp src/mbgl/style/conversion/function.cpp src/mbgl/style/conversion/geojson.cpp diff --git a/include/mbgl/style/conversion/color_ramp_property_value.hpp b/include/mbgl/style/conversion/color_ramp_property_value.hpp index 290ee6a56c..87049b043b 100644 --- a/include/mbgl/style/conversion/color_ramp_property_value.hpp +++ b/include/mbgl/style/conversion/color_ramp_property_value.hpp @@ -2,11 +2,6 @@ #include #include -#include -#include -#include -#include -#include namespace mbgl { namespace style { @@ -14,32 +9,7 @@ namespace conversion { template <> struct Converter { - optional operator()(const Convertible& value, Error& error, bool /* convertTokens */ = false) const { - using namespace mbgl::style::expression; - if (isUndefined(value)) { - return ColorRampPropertyValue(); - } else if (isExpression(value)) { - ParsingContext ctx(type::Color); - ParseResult expression = ctx.parseLayerPropertyExpression(value); - if (!expression) { - error = { ctx.getCombinedErrors() }; - return {}; - } - assert(*expression); - if (!isFeatureConstant(**expression)) { - error = { "property expressions not supported" }; - return {}; - } - if (!isZoomConstant(**expression)) { - error = { "zoom expressions not supported" }; - return {}; - } - return {ColorRampPropertyValue(std::move(*expression))}; - } else { - error = { "color ramp must be an expression" }; - return {}; - } - } + optional operator()(const Convertible& value, Error& error, bool /* convertTokens */ = false) const; }; } // namespace conversion diff --git a/include/mbgl/style/conversion/constant.hpp b/include/mbgl/style/conversion/constant.hpp index 7b3249da52..7d74ec42ce 100644 --- a/include/mbgl/style/conversion/constant.hpp +++ b/include/mbgl/style/conversion/constant.hpp @@ -33,14 +33,14 @@ struct Converter::value>> { optional operator()(const Convertible& value, Error& error) const { optional string = toString(value); if (!string) { - error = { "value must be a string" }; - return {}; + error.message = "value must be a string"; + return nullopt; } const auto result = Enum::toEnum(*string); if (!result) { - error = { "value must be a valid enumeration value" }; - return {}; + error.message = "value must be a valid enumeration value"; + return nullopt; } return *result; @@ -56,16 +56,16 @@ template struct Converter> { optional> operator()(const Convertible& value, Error& error) const { if (!isArray(value) || arrayLength(value) != N) { - error = { "value must be an array of " + util::toString(N) + " numbers" }; - return {}; + error.message = "value must be an array of " + util::toString(N) + " numbers"; + return nullopt; } std::array result; for (size_t i = 0; i < N; i++) { optional n = toNumber(arrayMember(value, i)); if (!n) { - error = { "value must be an array of " + util::toString(N) + " numbers" }; - return {}; + error.message = "value must be an array of " + util::toString(N) + " numbers"; + return nullopt; } result[i] = *n; } diff --git a/include/mbgl/style/conversion/custom_geometry_source_options.hpp b/include/mbgl/style/conversion/custom_geometry_source_options.hpp index dedecd1aa4..f0f505e54f 100644 --- a/include/mbgl/style/conversion/custom_geometry_source_options.hpp +++ b/include/mbgl/style/conversion/custom_geometry_source_options.hpp @@ -9,74 +9,7 @@ namespace conversion { template <> struct Converter { - - template - optional operator()(const V& value, Error& error) const { - CustomGeometrySource::Options options; - - const auto minzoomValue = objectMember(value, "minzoom"); - if (minzoomValue) { - if (toNumber(*minzoomValue)) { - options.zoomRange.min = static_cast(*toNumber(*minzoomValue)); - } else { - error = { "GeoJSON source minzoom value must be a number" }; - return {}; - } - } - - const auto maxzoomValue = objectMember(value, "maxzoom"); - if (maxzoomValue) { - if (toNumber(*maxzoomValue)) { - options.zoomRange.max = static_cast(*toNumber(*maxzoomValue)); - } else { - error = { "GeoJSON source maxzoom value must be a number" }; - return {}; - } - } - - const auto bufferValue = objectMember(value, "buffer"); - if (bufferValue) { - if (toNumber(*bufferValue)) { - options.tileOptions.buffer = static_cast(*toNumber(*bufferValue)); - } else { - error = { "GeoJSON source buffer value must be a number" }; - return {}; - } - } - - const auto toleranceValue = objectMember(value, "tolerance"); - if (toleranceValue) { - if (toNumber(*toleranceValue)) { - options.tileOptions.tolerance = static_cast(*toNumber(*toleranceValue)); - } else { - error = { "GeoJSON source tolerance value must be a number" }; - return {}; - } - } - - const auto wrapValue = objectMember(value, "wrap"); - if (wrapValue) { - if (toBool(*wrapValue)) { - options.tileOptions.wrap = static_cast(*toBool(*wrapValue)); - } else { - error = { "CustomGeometrySource TileOptions wrap value must be a boolean" }; - return {}; - } - } - - const auto clipValue = objectMember(value, "clip"); - if (clipValue) { - if (toBool(*clipValue)) { - options.tileOptions.clip = static_cast(*toBool(*clipValue)); - } else { - error = { "CustomGeometrySource TileOptiosn clip value must be a boolean" }; - return {}; - } - } - - return { options }; - } - + optional operator()(const Convertible& value, Error& error) const; }; } // namespace conversion diff --git a/include/mbgl/style/conversion/data_driven_property_value.hpp b/include/mbgl/style/conversion/data_driven_property_value.hpp index 59d197b216..2d8817ecf4 100644 --- a/include/mbgl/style/conversion/data_driven_property_value.hpp +++ b/include/mbgl/style/conversion/data_driven_property_value.hpp @@ -29,8 +29,8 @@ struct Converter> { ParsingContext ctx(valueTypeToExpressionType()); ParseResult parsed = ctx.parseLayerPropertyExpression(value); if (!parsed) { - error = { ctx.getCombinedErrors() }; - return {}; + error.message = ctx.getCombinedErrors(); + return nullopt; } expression = PropertyExpression(std::move(*parsed)); } else if (isObject(value)) { @@ -38,26 +38,26 @@ struct Converter> { } else { optional constant = convert(value, error); if (!constant) { - return {}; + return nullopt; } return convertTokens ? maybeConvertTokens(*constant) : DataDrivenPropertyValue(*constant); } if (!expression) { - return {}; + return nullopt; } else if (!(*expression).isFeatureConstant() || !(*expression).isZoomConstant()) { return { std::move(*expression) }; } else if ((*expression).getExpression().getKind() == Kind::Literal) { optional constant = fromExpressionValue( static_cast((*expression).getExpression()).getValue()); if (!constant) { - return {}; + return nullopt; } return DataDrivenPropertyValue(*constant); } else { assert(false); - error = { "expected a literal expression" }; - return {}; + error.message = "expected a literal expression"; + return nullopt; } } diff --git a/include/mbgl/style/conversion/function.hpp b/include/mbgl/style/conversion/function.hpp index 8799e9faa4..49825a3410 100644 --- a/include/mbgl/style/conversion/function.hpp +++ b/include/mbgl/style/conversion/function.hpp @@ -19,7 +19,7 @@ template optional> convertFunctionToExpression(const Convertible& value, Error& error, bool convertTokens) { auto expression = convertFunctionToExpression(expression::valueTypeToExpressionType(), value, error, convertTokens); if (!expression) { - return {}; + return nullopt; } optional defaultValue; @@ -28,8 +28,8 @@ optional> convertFunctionToExpression(const Convertible& v if (defaultValueValue) { defaultValue = convert(*defaultValueValue, error); if (!defaultValue) { - error = { R"(wrong type for "default": )" + error.message }; - return {}; + error.message = R"(wrong type for "default": )" + error.message; + return nullopt; } } diff --git a/include/mbgl/style/conversion/property_value.hpp b/include/mbgl/style/conversion/property_value.hpp index b03655a848..4d13144dd7 100644 --- a/include/mbgl/style/conversion/property_value.hpp +++ b/include/mbgl/style/conversion/property_value.hpp @@ -33,8 +33,8 @@ struct Converter> { ParsingContext ctx(valueTypeToExpressionType()); ParseResult parsed = ctx.parseLayerPropertyExpression(value); if (!parsed) { - error = { ctx.getCombinedErrors() }; - return {}; + error.message = ctx.getCombinedErrors(); + return nullopt; } expression = PropertyExpression(std::move(*parsed)); } else if (isObject(value)) { @@ -42,29 +42,29 @@ struct Converter> { } else { optional constant = convert(value, error); if (!constant) { - return {}; + return nullopt; } return { *constant }; } if (!expression) { - return {}; + return nullopt; } else if (!(*expression).isFeatureConstant()) { - error = { "data expressions not supported" }; - return {}; + error.message = "data expressions not supported"; + return nullopt; } else if (!(*expression).isZoomConstant()) { return { std::move(*expression) }; } else if ((*expression).getExpression().getKind() == Kind::Literal) { optional constant = fromExpressionValue( static_cast((*expression).getExpression()).getValue()); if (!constant) { - return {}; + return nullopt; } return PropertyValue(*constant); } else { assert(false); - error = { "expected a literal expression" }; - return {}; + error.message = "expected a literal expression"; + return nullopt; } } }; diff --git a/src/mbgl/style/conversion/color_ramp_property_value.cpp b/src/mbgl/style/conversion/color_ramp_property_value.cpp new file mode 100644 index 0000000000..e792cf3fe4 --- /dev/null +++ b/src/mbgl/style/conversion/color_ramp_property_value.cpp @@ -0,0 +1,42 @@ +#include +#include +#include +#include +#include +#include +#include + +namespace mbgl { +namespace style { +namespace conversion { + +optional Converter::operator()(const Convertible& value, Error& error, bool) const { + using namespace mbgl::style::expression; + if (isUndefined(value)) { + return ColorRampPropertyValue(); + } else if (isExpression(value)) { + ParsingContext ctx(type::Color); + ParseResult expression = ctx.parseLayerPropertyExpression(value); + if (!expression) { + error.message = ctx.getCombinedErrors(); + return nullopt; + } + assert(*expression); + if (!isFeatureConstant(**expression)) { + error.message = "data expressions not supported"; + return nullopt; + } + if (!isZoomConstant(**expression)) { + error.message = "zoom expressions not supported"; + return nullopt; + } + return ColorRampPropertyValue(std::move(*expression)); + } else { + error.message = "color ramp must be an expression"; + return nullopt; + } +} + +} // namespace conversion +} // namespace style +} // namespace mbgl diff --git a/src/mbgl/style/conversion/constant.cpp b/src/mbgl/style/conversion/constant.cpp index e837c4e70b..d432b5f051 100644 --- a/src/mbgl/style/conversion/constant.cpp +++ b/src/mbgl/style/conversion/constant.cpp @@ -7,8 +7,8 @@ namespace conversion { optional Converter::operator()(const Convertible& value, Error& error) const { optional converted = toBool(value); if (!converted) { - error = { "value must be a boolean" }; - return {}; + error.message = "value must be a boolean"; + return nullopt; } return *converted; } @@ -16,8 +16,8 @@ optional Converter::operator()(const Convertible& value, Error& erro optional Converter::operator()(const Convertible& value, Error& error) const { optional converted = toNumber(value); if (!converted) { - error = { "value must be a number" }; - return {}; + error.message = "value must be a number"; + return nullopt; } return *converted; } @@ -25,8 +25,8 @@ optional Converter::operator()(const Convertible& value, Error& er optional Converter::operator()(const Convertible& value, Error& error) const { optional converted = toString(value); if (!converted) { - error = { "value must be a string" }; - return {}; + error.message = "value must be a string"; + return nullopt; } return *converted; } @@ -34,14 +34,14 @@ optional Converter::operator()(const Convertible& valu optional Converter::operator()(const Convertible& value, Error& error) const { optional string = toString(value); if (!string) { - error = { "value must be a string" }; - return {}; + error.message = "value must be a string"; + return nullopt; } optional color = Color::parse(*string); if (!color) { - error = { "value must be a valid color" }; - return {}; + error.message = "value must be a valid color"; + return nullopt; } return *color; @@ -49,8 +49,8 @@ optional Converter::operator()(const Convertible& value, Error& er optional> Converter>::operator()(const Convertible& value, Error& error) const { if (!isArray(value)) { - error = { "value must be an array" }; - return {}; + error.message = "value must be an array"; + return nullopt; } std::vector result; @@ -59,8 +59,8 @@ optional> Converter>::operator()(const Con for (std::size_t i = 0; i < arrayLength(value); ++i) { optional number = toNumber(arrayMember(value, i)); if (!number) { - error = { "value must be an array of numbers" }; - return {}; + error.message = "value must be an array of numbers"; + return nullopt; } result.push_back(*number); } @@ -70,8 +70,8 @@ optional> Converter>::operator()(const Con optional> Converter>::operator()(const Convertible& value, Error& error) const { if (!isArray(value)) { - error = { "value must be an array" }; - return {}; + error.message = "value must be an array"; + return nullopt; } std::vector result; @@ -80,8 +80,8 @@ optional> Converter>::operator for (std::size_t i = 0; i < arrayLength(value); ++i) { optional string = toString(arrayMember(value, i)); if (!string) { - error = { "value must be an array of strings" }; - return {}; + error.message = "value must be an array of strings"; + return nullopt; } result.push_back(*string); } diff --git a/src/mbgl/style/conversion/coordinate.cpp b/src/mbgl/style/conversion/coordinate.cpp index 9b2be3381e..20abd45e26 100644 --- a/src/mbgl/style/conversion/coordinate.cpp +++ b/src/mbgl/style/conversion/coordinate.cpp @@ -6,20 +6,20 @@ namespace conversion { optional Converter::operator() (const Convertible& value, Error& error) const { if (!isArray(value) || arrayLength(value) < 2 ) { - error = { "coordinate array must contain numeric longitude and latitude values" }; - return {}; + error.message = "coordinate array must contain numeric longitude and latitude values"; + return nullopt; } //Style spec uses GeoJSON convention for specifying coordinates optional latitude = toDouble(arrayMember(value, 1)); optional longitude = toDouble(arrayMember(value, 0)); if (!latitude || !longitude) { - error = { "coordinate array must contain numeric longitude and latitude values" }; - return {}; + error.message = "coordinate array must contain numeric longitude and latitude values"; + return nullopt; } if (*latitude < -90 || *latitude > 90 ){ - error = { "coordinate latitude must be between -90 and 90" }; - return {}; + error.message = "coordinate latitude must be between -90 and 90"; + return nullopt; } return LatLng(*latitude, *longitude); } diff --git a/src/mbgl/style/conversion/custom_geometry_source_options.cpp b/src/mbgl/style/conversion/custom_geometry_source_options.cpp new file mode 100644 index 0000000000..8983f9f479 --- /dev/null +++ b/src/mbgl/style/conversion/custom_geometry_source_options.cpp @@ -0,0 +1,75 @@ +#include + +namespace mbgl { +namespace style { +namespace conversion { + +optional Converter::operator()(const Convertible& value, Error& error) const { + CustomGeometrySource::Options options; + + const auto minzoomValue = objectMember(value, "minzoom"); + if (minzoomValue) { + if (toNumber(*minzoomValue)) { + options.zoomRange.min = static_cast(*toNumber(*minzoomValue)); + } else { + error.message = "GeoJSON source minzoom value must be a number"; + return nullopt; + } + } + + const auto maxzoomValue = objectMember(value, "maxzoom"); + if (maxzoomValue) { + if (toNumber(*maxzoomValue)) { + options.zoomRange.max = static_cast(*toNumber(*maxzoomValue)); + } else { + error.message = "GeoJSON source maxzoom value must be a number"; + return nullopt; + } + } + + const auto bufferValue = objectMember(value, "buffer"); + if (bufferValue) { + if (toNumber(*bufferValue)) { + options.tileOptions.buffer = static_cast(*toNumber(*bufferValue)); + } else { + error.message = "GeoJSON source buffer value must be a number"; + return nullopt; + } + } + + const auto toleranceValue = objectMember(value, "tolerance"); + if (toleranceValue) { + if (toNumber(*toleranceValue)) { + options.tileOptions.tolerance = static_cast(*toNumber(*toleranceValue)); + } else { + error.message = "GeoJSON source tolerance value must be a number"; + return nullopt; + } + } + + const auto wrapValue = objectMember(value, "wrap"); + if (wrapValue) { + if (toBool(*wrapValue)) { + options.tileOptions.wrap = static_cast(*toBool(*wrapValue)); + } else { + error.message = "CustomGeometrySource TileOptions wrap value must be a boolean"; + return nullopt; + } + } + + const auto clipValue = objectMember(value, "clip"); + if (clipValue) { + if (toBool(*clipValue)) { + options.tileOptions.clip = static_cast(*toBool(*clipValue)); + } else { + error.message = "CustomGeometrySource TileOptiosn clip value must be a boolean"; + return nullopt; + } + } + + return options; +} + +} // namespace conversion +} // namespace style +} // namespace mbgl diff --git a/src/mbgl/style/conversion/filter.cpp b/src/mbgl/style/conversion/filter.cpp index b690c96388..5114c61778 100644 --- a/src/mbgl/style/conversion/filter.cpp +++ b/src/mbgl/style/conversion/filter.cpp @@ -9,9 +9,9 @@ namespace mbgl { namespace style { namespace conversion { - + using namespace mbgl::style::expression; - + static bool isExpression(const Convertible& filter); ParseResult convertLegacyFilter(const Convertible& values, Error& error); optional serializeLegacyFilter(const Convertible& values); @@ -21,8 +21,8 @@ optional Converter::operator()(const Convertible& value, Error& ParsingContext parsingContext(type::Boolean); ParseResult parseResult = parsingContext.parseExpression(value); if (!parseResult) { - error = { parsingContext.getCombinedErrors() }; - return {}; + error.message = parsingContext.getCombinedErrors(); + return nullopt; } else { return { Filter(std::move(parseResult)) }; } @@ -30,7 +30,7 @@ optional Converter::operator()(const Convertible& value, Error& ParseResult expression = convertLegacyFilter(value, error); if (!expression) { assert(error.message.size() > 0); - return {}; + return nullopt; } return Filter(optional>(std::move(*expression)), serializeLegacyFilter(value)); } @@ -41,23 +41,23 @@ bool isExpression(const Convertible& filter) { if (!isArray(filter) || arrayLength(filter) == 0) { return false; } - + optional op = toString(arrayMember(filter, 0)); - + if (!op) { return false; - + } else if (*op == "has") { if (arrayLength(filter) < 2) return false; optional operand = toString(arrayMember(filter, 1)); return operand && *operand != "$id" && *operand != "$type"; - + } else if (*op == "in" || *op == "!in" || *op == "!has" || *op == "none") { return false; - + } else if (*op == "==" || *op == "!=" || *op == ">" || *op == ">=" || *op == "<" || *op == "<=") { return arrayLength(filter) != 3 || isArray(arrayMember(filter, 1)) || isArray(arrayMember(filter, 2)); - + } else if (*op == "any" || *op == "all") { for (std::size_t i = 1; i < arrayLength(filter); i++) { Convertible f = arrayMember(filter, i); @@ -66,18 +66,18 @@ bool isExpression(const Convertible& filter) { } } return true; - + } else { return true; } } - + ParseResult createExpression(std::string op, optional>> args, Error& error) { if (!args) return {}; assert(std::all_of(args->begin(), args->end(), [](const std::unique_ptr &e) { return bool(e.get()); })); - + if (op == "any") { return {std::make_unique(std::move(*args))}; } else if (op == "all") { @@ -86,7 +86,7 @@ ParseResult createExpression(std::string op, optional> args; args.push_back(std::move(*arg)); return createExpression(op, std::move(args), error); @@ -110,7 +110,7 @@ ParseResult convertLiteral(const Convertible& convertible, Error& error) { if (parseResult) { return parseResult; } else { - error = { parsingContext.getCombinedErrors() }; + error.message = parsingContext.getCombinedErrors(); return {}; } } @@ -120,7 +120,7 @@ optional>> convertLiteralArray(const Con for (std::size_t i = startIndex; i < arrayLength(input); i++) { ParseResult literal = convertLiteral(arrayMember(input, i), error); if (!literal) { - return {}; + return nullopt; } output.push_back(std::move(*literal)); } @@ -130,9 +130,9 @@ optional>> convertLiteralArray(const Con ParseResult convertLegacyComparisonFilter(const Convertible& values, Error& error, optional opOverride = {}) { optional op = opOverride ? opOverride : toString(arrayMember(values, 0)); optional property = toString(arrayMember(values, 1)); - + if (!property) { - error = { "filter property must be a string" }; + error.message = "filter property must be a string"; return {}; } else if (*property == "$type") { return createExpression("filter-type-" + *op, convertLiteralArray(values, error, 2), error); @@ -142,12 +142,12 @@ ParseResult convertLegacyComparisonFilter(const Convertible& values, Error& erro return createExpression("filter-" + *op, convertLiteralArray(values, error, 1), error); } } - + ParseResult convertLegacyHasFilter(const Convertible& values, Error& error) { optional property = toString(arrayMember(values, 1)); - + if (!property) { - error = { "filter property must be a string" }; + error.message = "filter property must be a string"; return {}; } else if (*property == "$type") { return {std::make_unique(true)}; @@ -160,9 +160,9 @@ ParseResult convertLegacyHasFilter(const Convertible& values, Error& error) { ParseResult convertLegacyInFilter(const Convertible& values, Error& error) { optional property = toString(arrayMember(values, 1)); - + if (!property) { - error = { "filter property must be a string" }; + error.message = "filter property must be a string"; return {}; } else if (arrayLength(values) == 0) { return {std::make_unique(false)}; @@ -180,22 +180,22 @@ optional>> convertLegacyFilterArray(cons for (std::size_t i = startIndex; i < arrayLength(input); i++) { optional> child = convertLegacyFilter(arrayMember(input, i), error); if (!child) { - return {}; + return nullopt; } output.push_back(std::move(*child)); } return {std::move(output)}; } - + ParseResult convertLegacyFilter(const Convertible& values, Error& error) { if (isUndefined(values)) { return {std::make_unique(true)}; } - + optional op = toString(arrayMember(values, 0)); if (!op) { - error = { "filter operator must be a string" }; + error.message = "filter operator must be a string"; return {}; } else if (arrayLength(values) <= 1) { return {std::make_unique(*op != "any")}; @@ -221,7 +221,7 @@ ParseResult convertLegacyFilter(const Convertible& values, Error& error) { optional serializeLegacyFilter(const Convertible& values) { if (isUndefined(values)) { - return {}; + return nullopt; } else if (isArray(values)) { std::vector result; for (std::size_t i = 0; i < arrayLength(values); i++) { diff --git a/src/mbgl/style/conversion/function.cpp b/src/mbgl/style/conversion/function.cpp index 61b45fcbe5..1cc49e483a 100644 --- a/src/mbgl/style/conversion/function.cpp +++ b/src/mbgl/style/conversion/function.cpp @@ -78,7 +78,7 @@ struct Converter { optional operator()(const Convertible& value, Error& error) const { auto converted = convert(value, error); if (!converted) { - return {}; + return nullopt; } return *converted; } @@ -89,7 +89,7 @@ struct Converter { optional operator()(const Convertible& value, Error& error) const { auto converted = convert(value, error); if (!converted) { - return {}; + return nullopt; } return *converted; } @@ -125,39 +125,39 @@ static optional> convertLiteral(type::Type type, con [&] (const type::NumberType&) -> optional> { auto result = convert(value, error); if (!result) { - return {}; + return nullopt; } return literal(double(*result)); }, [&] (const type::BooleanType&) -> optional> { auto result = convert(value, error); if (!result) { - return {}; + return nullopt; } return literal(*result); }, [&] (const type::StringType&) -> optional> { auto result = convert(value, error); if (!result) { - return {}; + return nullopt; } return convertTokens ? convertTokenStringToExpression(*result) : literal(*result); }, [&] (const type::ColorType&) -> optional> { auto result = convert(value, error); if (!result) { - return {}; + return nullopt; } return literal(*result); }, [&] (const type::Array& array) -> optional> { if (!isArray(value)) { - error = { "value must be an array" }; - return {}; + error.message = "value must be an array"; + return nullopt; } if (array.N && arrayLength(value) != *array.N) { - error = { "value must be an array of length " + util::toString(*array.N) }; - return {}; + error.message = "value must be an array of length " + util::toString(*array.N); + return nullopt; } return array.itemType.match( [&] (const type::NumberType&) -> optional> { @@ -166,8 +166,8 @@ static optional> convertLiteral(type::Type type, con for (std::size_t i = 0; i < arrayLength(value); ++i) { optional number = toNumber(arrayMember(value, i)); if (!number) { - error = { "value must be an array of numbers" }; - return {}; + error.message = "value must be an array of numbers"; + return nullopt; } result.push_back(double(*number)); } @@ -179,8 +179,8 @@ static optional> convertLiteral(type::Type type, con for (std::size_t i = 0; i < arrayLength(value); ++i) { optional string = toString(arrayMember(value, i)); if (!string) { - error = { "value must be an array of strings" }; - return {}; + error.message = "value must be an array of strings"; + return nullopt; } result.push_back(*string); } @@ -188,29 +188,29 @@ static optional> convertLiteral(type::Type type, con }, [&] (const auto&) -> optional> { assert(false); // No properties use this type. - return {}; + return nullopt; } ); }, [&] (const type::NullType&) -> optional> { assert(false); // No properties use this type. - return {}; + return nullopt; }, [&] (const type::ObjectType&) -> optional> { assert(false); // No properties use this type. - return {}; + return nullopt; }, [&] (const type::ErrorType&) -> optional> { assert(false); // No properties use this type. - return {}; + return nullopt; }, [&] (const type::ValueType&) -> optional> { assert(false); // No properties use this type. - return {}; + return nullopt; }, [&] (const type::CollatorType&) -> optional> { assert(false); // No properties use this type. - return {}; + return nullopt; } ); } @@ -221,18 +221,18 @@ static optional>> convertStops(type bool convertTokens) { auto stopsValue = objectMember(value, "stops"); if (!stopsValue) { - error = { "function value must specify stops" }; - return {}; + error.message = "function value must specify stops"; + return nullopt; } if (!isArray(*stopsValue)) { - error = { "function stops must be an array" }; - return {}; + error.message = "function stops must be an array"; + return nullopt; } if (arrayLength(*stopsValue) == 0) { - error = { "function must have at least one stop" }; - return {}; + error.message = "function must have at least one stop"; + return nullopt; } std::map> stops; @@ -240,23 +240,23 @@ static optional>> convertStops(type const auto& stopValue = arrayMember(*stopsValue, i); if (!isArray(stopValue)) { - error = { "function stop must be an array" }; - return {}; + error.message = "function stop must be an array"; + return nullopt; } if (arrayLength(stopValue) != 2) { - error = { "function stop must have two elements" }; - return {}; + error.message = "function stop must have two elements"; + return nullopt; } optional t = convert(arrayMember(stopValue, 0), error); if (!t) { - return {}; + return nullopt; } optional> e = convertLiteral(type, arrayMember(stopValue, 1), error, convertTokens); if (!e) { - return {}; + return nullopt; } stops.emplace(*t, std::move(*e)); @@ -271,18 +271,18 @@ optional>> convertBranches(type::Type ty Error& error) { auto stopsValue = objectMember(value, "stops"); if (!stopsValue) { - error = { "function value must specify stops" }; - return {}; + error.message = "function value must specify stops"; + return nullopt; } if (!isArray(*stopsValue)) { - error = { "function stops must be an array" }; - return {}; + error.message = "function stops must be an array"; + return nullopt; } if (arrayLength(*stopsValue) == 0) { - error = { "function must have at least one stop" }; - return {}; + error.message = "function must have at least one stop"; + return nullopt; } std::map> stops; @@ -290,23 +290,23 @@ optional>> convertBranches(type::Type ty const auto& stopValue = arrayMember(*stopsValue, i); if (!isArray(stopValue)) { - error = { "function stop must be an array" }; - return {}; + error.message = "function stop must be an array"; + return nullopt; } if (arrayLength(stopValue) != 2) { - error = { "function stop must have two elements" }; - return {}; + error.message = "function stop must have two elements"; + return nullopt; } optional t = convert(arrayMember(stopValue, 0), error); if (!t) { - return {}; + return nullopt; } optional> e = convertLiteral(type, arrayMember(stopValue, 1), error); if (!e) { - return {}; + return nullopt; } stops.emplace(*t, std::move(*e)); @@ -324,8 +324,8 @@ static optional convertBase(const Convertible& value, Error& error) { auto base = toNumber(*baseValue); if (!base) { - error = { "function base must be a number" }; - return {}; + error.message = "function base must be a number"; + return nullopt; } return *base; @@ -379,7 +379,7 @@ static optional> convertIntervalFunction(type::Type bool convertTokens = false) { auto stops = convertStops(type, value, error, convertTokens); if (!stops) { - return {}; + return nullopt; } return step(type, std::move(input), std::move(*stops)); } @@ -391,11 +391,11 @@ static optional> convertExponentialFunction(type::Ty bool convertTokens = false) { auto stops = convertStops(type, value, error, convertTokens); if (!stops) { - return {}; + return nullopt; } auto base = convertBase(value, error); if (!base) { - return {}; + return nullopt; } return interpolate(type, exponential(*base), std::move(input), std::move(*stops)); } @@ -406,36 +406,36 @@ static optional> convertCategoricalFunction(type::Ty const std::string& property) { auto stopsValue = objectMember(value, "stops"); if (!stopsValue) { - err = { "function value must specify stops" }; - return {}; + err.message = "function value must specify stops"; + return nullopt; } if (!isArray(*stopsValue)) { - err = { "function stops must be an array" }; - return {}; + err.message = "function stops must be an array"; + return nullopt; } if (arrayLength(*stopsValue) == 0) { - err = { "function must have at least one stop" }; - return {}; + err.message = "function must have at least one stop"; + return nullopt; } const auto& first = arrayMember(*stopsValue, 0); if (!isArray(first)) { - err = { "function stop must be an array" }; - return {}; + err.message = "function stop must be an array"; + return nullopt; } if (arrayLength(first) != 2) { - err = { "function stop must have two elements" }; - return {}; + err.message = "function stop must have two elements"; + return nullopt; } if (toBool(arrayMember(first, 0))) { auto branches = convertBranches(type, value, err); if (!branches) { - return {}; + return nullopt; } return categorical(type, property, std::move(*branches)); } @@ -443,7 +443,7 @@ static optional> convertCategoricalFunction(type::Ty if (toNumber(arrayMember(first, 0))) { auto branches = convertBranches(type, value, err); if (!branches) { - return {}; + return nullopt; } return categorical(type, property, std::move(*branches)); } @@ -451,13 +451,13 @@ static optional> convertCategoricalFunction(type::Ty if (toString(arrayMember(first, 0))) { auto branches = convertBranches(type, value, err); if (!branches) { - return {}; + return nullopt; } return categorical(type, property, std::move(*branches)); } - err = { "stop domain value must be a number, string, or boolean" }; - return {}; + err.message = "stop domain value must be a number, string, or boolean"; + return nullopt; } template @@ -467,7 +467,7 @@ optional> composite(type::Type type, const Fn& makeInnerExpression) { auto base = convertBase(value, error); if (!base) { - return {}; + return nullopt; } auto stopsValue = objectMember(value, "stops"); @@ -482,47 +482,47 @@ optional> composite(type::Type type, const auto& stopValue = arrayMember(*stopsValue, i); if (!isArray(stopValue)) { - error = { "function stop must be an array" }; - return {}; + error.message = "function stop must be an array"; + return nullopt; } if (arrayLength(stopValue) != 2) { - error = { "function stop must have two elements" }; - return {}; + error.message = "function stop must have two elements"; + return nullopt; } const auto& stopInput = arrayMember(stopValue, 0); if (!isObject(stopInput)) { - error = { "stop input must be an object" }; - return {}; + error.message = "stop input must be an object"; + return nullopt; } auto zoomValue = objectMember(stopInput, "zoom"); if (!zoomValue) { - error = { "stop input must specify zoom" }; - return {}; + error.message = "stop input must specify zoom"; + return nullopt; } auto sourceValue = objectMember(stopInput, "value"); if (!sourceValue) { - error = { "stop input must specify value" }; - return {}; + error.message = "stop input must specify value"; + return nullopt; } optional z = convert(*zoomValue, error); if (!z) { - return {}; + return nullopt; } optional d = convert(*sourceValue, error); if (!d) { - return {}; + return nullopt; } optional> r = convertLiteral(type, arrayMember(stopValue, 1), error); if (!r) { - return {}; + return nullopt; } map[*z].emplace(*d, std::move(*r)); @@ -546,8 +546,8 @@ optional> convertFunctionToExpression(type::Type typ Error& err, bool convertTokens) { if (!isObject(value)) { - err = { "function must be an object" }; - return {}; + err.message = "function must be an object"; + return nullopt; } FunctionType functionType = FunctionType::Invalid; @@ -577,21 +577,21 @@ optional> convertFunctionToExpression(type::Type typ case FunctionType::Exponential: return convertExponentialFunction(type, value, err, zoom(), convertTokens); default: - err = { "unsupported function type" }; - return {}; + err.message = "unsupported function type"; + return nullopt; } } auto propertyValue = objectMember(value, "property"); if (!propertyValue) { - err = { "function must specify property" }; - return {}; + err.message = "function must specify property"; + return nullopt; } auto property = toString(*propertyValue); if (!property) { - err = { "function property must be a string" }; - return {}; + err.message = "function property must be a string"; + return nullopt; } if (functionType == FunctionType::Identity) { @@ -614,37 +614,37 @@ optional> convertFunctionToExpression(type::Type typ }, [&] (const auto&) -> optional> { assert(false); // No properties use this type. - return {}; + return nullopt; } ); } auto stopsValue = objectMember(value, "stops"); if (!stopsValue) { - err = { "function value must specify stops" }; - return {}; + err.message = "function value must specify stops"; + return nullopt; } if (!isArray(*stopsValue)) { - err = { "function stops must be an array" }; - return {}; + err.message = "function stops must be an array"; + return nullopt; } if (arrayLength(*stopsValue) == 0) { - err = { "function must have at least one stop" }; - return {}; + err.message = "function must have at least one stop"; + return nullopt; } const auto& first = arrayMember(*stopsValue, 0); if (!isArray(first)) { - err = { "function stop must be an array" }; - return {}; + err.message = "function stop must be an array"; + return nullopt; } if (arrayLength(first) != 2) { - err = { "function stop must have two elements" }; - return {}; + err.message = "function stop must have two elements"; + return nullopt; } const auto& stop = arrayMember(first, 0); @@ -659,15 +659,15 @@ optional> convertFunctionToExpression(type::Type typ case FunctionType::Categorical: return convertCategoricalFunction(type, value, err, *property); default: - err = { "unsupported function type" }; - return {}; + err.message = "unsupported function type"; + return nullopt; } } else { // Composite function. auto sourceValue = objectMember(stop, "value"); if (!sourceValue) { - err = { "stop must specify value" }; - return {}; + err.message = "stop must specify value"; + return nullopt; } if (toBool(*sourceValue)) { @@ -677,8 +677,8 @@ optional> convertFunctionToExpression(type::Type typ return categorical(type_, *property, std::move(stops)); }); default: - err = { "unsupported function type" }; - return {}; + err.message = "unsupported function type"; + return nullopt; } } @@ -697,8 +697,8 @@ optional> convertFunctionToExpression(type::Type typ return categorical(type_, *property, std::move(stops)); }); default: - err = { "unsupported function type" }; - return {}; + err.message = "unsupported function type"; + return nullopt; } } @@ -709,13 +709,13 @@ optional> convertFunctionToExpression(type::Type typ return categorical(type_, *property, std::move(stops)); }); default: - err = { "unsupported function type" }; - return {}; + err.message = "unsupported function type"; + return nullopt; } } - err = { "stop domain value must be a number, string, or boolean" }; - return {}; + err.message = "stop domain value must be a number, string, or boolean"; + return nullopt; } } diff --git a/src/mbgl/style/conversion/geojson_options.cpp b/src/mbgl/style/conversion/geojson_options.cpp index a2c5ed8816..52a5030c34 100644 --- a/src/mbgl/style/conversion/geojson_options.cpp +++ b/src/mbgl/style/conversion/geojson_options.cpp @@ -12,8 +12,8 @@ optional Converter::operator()(const Convertible if (toNumber(*minzoomValue)) { options.minzoom = static_cast(*toNumber(*minzoomValue)); } else { - error = { "GeoJSON source minzoom value must be a number" }; - return {}; + error.message = "GeoJSON source minzoom value must be a number"; + return nullopt; } } @@ -22,8 +22,8 @@ optional Converter::operator()(const Convertible if (toNumber(*maxzoomValue)) { options.maxzoom = static_cast(*toNumber(*maxzoomValue)); } else { - error = { "GeoJSON source maxzoom value must be a number" }; - return {}; + error.message = "GeoJSON source maxzoom value must be a number"; + return nullopt; } } @@ -32,8 +32,8 @@ optional Converter::operator()(const Convertible if (toNumber(*bufferValue)) { options.buffer = static_cast(*toNumber(*bufferValue)); } else { - error = { "GeoJSON source buffer value must be a number" }; - return {}; + error.message = "GeoJSON source buffer value must be a number"; + return nullopt; } } @@ -42,8 +42,8 @@ optional Converter::operator()(const Convertible if (toNumber(*toleranceValue)) { options.tolerance = static_cast(*toNumber(*toleranceValue)); } else { - error = { "GeoJSON source tolerance value must be a number" }; - return {}; + error.message = "GeoJSON source tolerance value must be a number"; + return nullopt; } } @@ -52,8 +52,8 @@ optional Converter::operator()(const Convertible if (toBool(*clusterValue)) { options.cluster = *toBool(*clusterValue); } else { - error = { "GeoJSON source cluster value must be a boolean" }; - return {}; + error.message = "GeoJSON source cluster value must be a boolean"; + return nullopt; } } @@ -62,8 +62,8 @@ optional Converter::operator()(const Convertible if (toNumber(*clusterMaxZoomValue)) { options.clusterMaxZoom = static_cast(*toNumber(*clusterMaxZoomValue)); } else { - error = { "GeoJSON source clusterMaxZoom value must be a number" }; - return {}; + error.message = "GeoJSON source clusterMaxZoom value must be a number"; + return nullopt; } } @@ -72,8 +72,8 @@ optional Converter::operator()(const Convertible if (toNumber(*clusterRadiusValue)) { options.clusterRadius = static_cast(*toNumber(*clusterRadiusValue)); } else { - error = { "GeoJSON source clusterRadius value must be a number" }; - return {}; + error.message = "GeoJSON source clusterRadius value must be a number"; + return nullopt; } } diff --git a/src/mbgl/style/conversion/layer.cpp b/src/mbgl/style/conversion/layer.cpp index 19472bc8d6..e18ad923f2 100644 --- a/src/mbgl/style/conversion/layer.cpp +++ b/src/mbgl/style/conversion/layer.cpp @@ -37,7 +37,7 @@ optional setPaintProperty(Layer& layer, const std::string& name, const Co optional setPaintProperties(Layer& layer, const Convertible& value) { auto paintValue = objectMember(value, "paint"); if (!paintValue) { - return {}; + return nullopt; } if (!isObject(*paintValue)) { return { { "paint must be an object" } }; @@ -51,14 +51,14 @@ template optional> convertVectorLayer(const std::string& id, const Convertible& value, Error& error) { auto sourceValue = objectMember(value, "source"); if (!sourceValue) { - error = { "layer must have a source" }; - return {}; + error.message = "layer must have a source"; + return nullopt; } optional source = toString(*sourceValue); if (!source) { - error = { "layer source must be a string" }; - return {}; + error.message = "layer source must be a string"; + return nullopt; } std::unique_ptr layer = std::make_unique(id, *source); @@ -67,8 +67,8 @@ optional> convertVectorLayer(const std::string& id, const if (sourceLayerValue) { optional sourceLayer = toString(*sourceLayerValue); if (!sourceLayer) { - error = { "layer source-layer must be a string" }; - return {}; + error.message = "layer source-layer must be a string"; + return nullopt; } layer->setSourceLayer(*sourceLayer); } @@ -77,7 +77,7 @@ optional> convertVectorLayer(const std::string& id, const if (filterValue) { optional filter = convert(*filterValue, error); if (!filter) { - return {}; + return nullopt; } layer->setFilter(*filter); } @@ -88,14 +88,14 @@ optional> convertVectorLayer(const std::string& id, const static optional> convertRasterLayer(const std::string& id, const Convertible& value, Error& error) { auto sourceValue = objectMember(value, "source"); if (!sourceValue) { - error = { "layer must have a source" }; - return {}; + error.message = "layer must have a source"; + return nullopt; } optional source = toString(*sourceValue); if (!source) { - error = { "layer source must be a string" }; - return {}; + error.message = "layer source must be a string"; + return nullopt; } return { std::make_unique(id, *source) }; @@ -104,14 +104,14 @@ static optional> convertRasterLayer(const std::string& id static optional> convertHillshadeLayer(const std::string& id, const Convertible& value, Error& error) { auto sourceValue = objectMember(value, "source"); if (!sourceValue) { - error = { "layer must have a source" }; - return {}; + error.message = "layer must have a source"; + return nullopt; } optional source = toString(*sourceValue); if (!source) { - error = { "layer source must be a string" }; - return {}; + error.message = "layer source must be a string"; + return nullopt; } return { std::make_unique(id, *source) }; @@ -124,32 +124,32 @@ static optional> convertBackgroundLayer(const std::string optional> Converter>::operator()(const Convertible& value, Error& error) const { if (!isObject(value)) { - error = { "layer must be an object" }; - return {}; + error.message = "layer must be an object"; + return nullopt; } auto idValue = objectMember(value, "id"); if (!idValue) { - error = { "layer must have an id" }; - return {}; + error.message = "layer must have an id"; + return nullopt; } optional id = toString(*idValue); if (!id) { - error = { "layer id must be a string" }; - return {}; + error.message = "layer id must be a string"; + return nullopt; } auto typeValue = objectMember(value, "type"); if (!typeValue) { - error = { "layer must have a type" }; - return {}; + error.message = "layer must have a type"; + return nullopt; } optional type = toString(*typeValue); if (!type) { - error = { "layer type must be a string" }; - return {}; + error.message = "layer type must be a string"; + return nullopt; } optional> converted; @@ -173,8 +173,8 @@ optional> Converter>::operator()(c } else if (*type == "background") { converted = convertBackgroundLayer(*id, value, error); } else { - error = { "invalid layer type" }; - return {}; + error.message = "invalid layer type"; + return nullopt; } if (!converted) { @@ -187,8 +187,8 @@ optional> Converter>::operator()(c if (minzoomValue) { optional minzoom = toNumber(*minzoomValue); if (!minzoom) { - error = { "minzoom must be numeric" }; - return {}; + error.message = "minzoom must be numeric"; + return nullopt; } layer->setMinZoom(*minzoom); } @@ -197,8 +197,8 @@ optional> Converter>::operator()(c if (maxzoomValue) { optional maxzoom = toNumber(*maxzoomValue); if (!maxzoom) { - error = { "maxzoom must be numeric" }; - return {}; + error.message = "maxzoom must be numeric"; + return nullopt; } layer->setMaxZoom(*maxzoom); } @@ -206,22 +206,22 @@ optional> Converter>::operator()(c auto layoutValue = objectMember(value, "layout"); if (layoutValue) { if (!isObject(*layoutValue)) { - error = { "layout must be an object" }; - return {}; + error.message = "layout must be an object"; + return nullopt; } optional error_ = eachMember(*layoutValue, [&] (const std::string& k, const Convertible& v) { return setLayoutProperty(*layer, k, v); }); if (error_) { error = *error_; - return {}; + return nullopt; } } optional error_ = setPaintProperties(*layer, value); if (error_) { error = *error_; - return {}; + return nullopt; } return std::move(layer); diff --git a/src/mbgl/style/conversion/light.cpp b/src/mbgl/style/conversion/light.cpp index 57b61eb340..0a68f2396f 100644 --- a/src/mbgl/style/conversion/light.cpp +++ b/src/mbgl/style/conversion/light.cpp @@ -9,8 +9,8 @@ namespace conversion { optional Converter::operator()(const Convertible& value, Error& error) const { if (!isObject(value)) { - error = { "light must be an object" }; - return {}; + error.message = "light must be an object"; + return nullopt; } Light light; @@ -23,7 +23,7 @@ optional Converter::operator()(const Convertible& value, Error& er if (convertedAnchor) { light.setAnchor(*convertedAnchor); } else { - return {}; + return nullopt; } } @@ -34,7 +34,7 @@ optional Converter::operator()(const Convertible& value, Error& er if (transition) { light.setAnchorTransition(*transition); } else { - return {}; + return nullopt; } } @@ -46,7 +46,7 @@ optional Converter::operator()(const Convertible& value, Error& er if (convertedColor) { light.setColor(*convertedColor); } else { - return {}; + return nullopt; } } @@ -57,7 +57,7 @@ optional Converter::operator()(const Convertible& value, Error& er if (transition) { light.setColorTransition(*transition); } else { - return {}; + return nullopt; } } @@ -69,7 +69,7 @@ optional Converter::operator()(const Convertible& value, Error& er if (convertedPosition) { light.setPosition(*convertedPosition); } else { - return {}; + return nullopt; } } @@ -80,7 +80,7 @@ optional Converter::operator()(const Convertible& value, Error& er if (transition) { light.setPositionTransition(*transition); } else { - return {}; + return nullopt; } } @@ -92,7 +92,7 @@ optional Converter::operator()(const Convertible& value, Error& er if (convertedIntensity) { light.setIntensity(*convertedIntensity); } else { - return {}; + return nullopt; } } @@ -103,7 +103,7 @@ optional Converter::operator()(const Convertible& value, Error& er if (transition) { light.setIntensityTransition(*transition); } else { - return {}; + return nullopt; } } diff --git a/src/mbgl/style/conversion/position.cpp b/src/mbgl/style/conversion/position.cpp index 702d250dbf..a19f57bff3 100644 --- a/src/mbgl/style/conversion/position.cpp +++ b/src/mbgl/style/conversion/position.cpp @@ -11,7 +11,7 @@ optional Converter::operator()(const Convertible& value, Err optional> spherical = convert>(value, error); if (!spherical) { - return {}; + return nullopt; } return Position(*spherical); diff --git a/src/mbgl/style/conversion/property_setter.hpp b/src/mbgl/style/conversion/property_setter.hpp index 8791e36e1f..cdb585aa29 100644 --- a/src/mbgl/style/conversion/property_setter.hpp +++ b/src/mbgl/style/conversion/property_setter.hpp @@ -31,7 +31,7 @@ optional setProperty(Layer& layer, const Convertible& value) { } (typedLayer->*setter)(*typedValue); - return {}; + return nullopt; } template @@ -48,13 +48,13 @@ optional setTransition(Layer& layer, const Convertible& value) { } (typedLayer->*setter)(*transition); - return {}; + return nullopt; } inline optional setVisibility(Layer& layer, const Convertible& value) { if (isUndefined(value)) { layer.setVisibility(VisibilityType::Visible); - return {}; + return nullopt; } Error error; @@ -64,7 +64,7 @@ inline optional setVisibility(Layer& layer, const Convertible& value) { } layer.setVisibility(*visibility); - return {}; + return nullopt; } } // namespace conversion diff --git a/src/mbgl/style/conversion/source.cpp b/src/mbgl/style/conversion/source.cpp index 670f50c041..ce0cb24ce0 100644 --- a/src/mbgl/style/conversion/source.cpp +++ b/src/mbgl/style/conversion/source.cpp @@ -20,15 +20,15 @@ static optional> convertURLOrTileset(const Convert if (!urlVal) { optional tileset = convert(value, error); if (!tileset) { - return {}; + return nullopt; } return { *tileset }; } optional url = toString(*urlVal); if (!url) { - error = { "source url must be a string" }; - return {}; + error.message = "source url must be a string"; + return nullopt; } return { *url }; @@ -39,7 +39,7 @@ static optional> convertRasterSource(const std::string& Error& error) { optional> urlOrTileset = convertURLOrTileset(value, error); if (!urlOrTileset) { - return {}; + return nullopt; } uint16_t tileSize = util::tileSize; @@ -47,8 +47,8 @@ static optional> convertRasterSource(const std::string& if (tileSizeValue) { optional size = toNumber(*tileSizeValue); if (!size || *size < 0 || *size > std::numeric_limits::max()) { - error = { "invalid tileSize" }; - return {}; + error.message = "invalid tileSize"; + return nullopt; } tileSize = *size; } @@ -61,7 +61,7 @@ static optional> convertRasterDEMSource(const std::strin Error& error) { optional> urlOrTileset = convertURLOrTileset(value, error); if (!urlOrTileset) { - return {}; + return nullopt; } uint16_t tileSize = util::tileSize; @@ -69,8 +69,8 @@ static optional> convertRasterDEMSource(const std::strin if (tileSizeValue) { optional size = toNumber(*tileSizeValue); if (!size || *size < 0 || *size > std::numeric_limits::max()) { - error = { "invalid tileSize" }; - return {}; + error.message = "invalid tileSize"; + return nullopt; } tileSize = *size; } @@ -83,7 +83,7 @@ static optional> convertVectorSource(const std::string& Error& error) { optional> urlOrTileset = convertURLOrTileset(value, error); if (!urlOrTileset) { - return {}; + return nullopt; } return { std::make_unique(id, std::move(*urlOrTileset)) }; @@ -94,13 +94,13 @@ static optional> convertGeoJSONSource(const std::string& Error& error) { auto dataValue = objectMember(value, "data"); if (!dataValue) { - error = { "GeoJSON source must have a data value" }; - return {}; + error.message = "GeoJSON source must have a data value"; + return nullopt; } optional options = convert(value, error); if (!options) { - return {}; + return nullopt; } auto result = std::make_unique(id, *options); @@ -108,14 +108,14 @@ static optional> convertGeoJSONSource(const std::string& if (isObject(*dataValue)) { optional geoJSON = convert(*dataValue, error); if (!geoJSON) { - return {}; + return nullopt; } result->setGeoJSON(std::move(*geoJSON)); } else if (toString(*dataValue)) { result->setURL(*toString(*dataValue)); } else { - error = { "GeoJSON data must be a URL or an object" }; - return {}; + error.message = "GeoJSON data must be a URL or an object"; + return nullopt; } return { std::move(result) }; @@ -126,32 +126,32 @@ static optional> convertImageSource(const std::string& i Error& error) { auto urlValue = objectMember(value, "url"); if (!urlValue) { - error = { "Image source must have a url value" }; - return {}; + error.message = "Image source must have a url value"; + return nullopt; } - + auto urlString = toString(*urlValue); if (!urlString) { - error = { "Image url must be a URL string" }; - return {}; + error.message = "Image url must be a URL string"; + return nullopt; } - + auto coordinatesValue = objectMember(value, "coordinates"); if (!coordinatesValue) { - error = { "Image source must have a coordinates values" }; - return {}; + error.message = "Image source must have a coordinates values"; + return nullopt; } - + if (!isArray(*coordinatesValue) || arrayLength(*coordinatesValue) != 4) { - error = { "Image coordinates must be an array of four longitude latitude pairs" }; - return {}; + error.message = "Image coordinates must be an array of four longitude latitude pairs"; + return nullopt; } - + std::array coordinates; for (std::size_t i=0; i < 4; i++) { auto latLng = conversion::convert(arrayMember(*coordinatesValue,i), error); if (!latLng) { - return {}; + return nullopt; } coordinates[i] = *latLng; } @@ -163,20 +163,20 @@ static optional> convertImageSource(const std::string& i optional> Converter>::operator()(const Convertible& value, Error& error, const std::string& id) const { if (!isObject(value)) { - error = { "source must be an object" }; - return {}; + error.message = "source must be an object"; + return nullopt; } auto typeValue = objectMember(value, "type"); if (!typeValue) { - error = { "source must have a type" }; - return {}; + error.message = "source must have a type"; + return nullopt; } optional type = toString(*typeValue); if (!type) { - error = { "source type must be a string" }; - return {}; + error.message = "source type must be a string"; + return nullopt; } const std::string tname = *type; if (*type == "raster") { @@ -190,8 +190,8 @@ optional> Converter>::operator() } else if (*type == "image") { return convertImageSource(id, value, error); } else { - error = { "invalid source type" }; - return {}; + error.message = "invalid source type"; + return nullopt; } } diff --git a/src/mbgl/style/conversion/tileset.cpp b/src/mbgl/style/conversion/tileset.cpp index fe3254b149..fb2ae6c6a0 100644 --- a/src/mbgl/style/conversion/tileset.cpp +++ b/src/mbgl/style/conversion/tileset.cpp @@ -11,20 +11,20 @@ optional Converter::operator()(const Convertible& value, Error auto tiles = objectMember(value, "tiles"); if (!tiles) { - error = { "source must have tiles" }; - return {}; + error.message = "source must have tiles"; + return nullopt; } if (!isArray(*tiles)) { - error = { "source tiles must be an array" }; - return {}; + error.message = "source tiles must be an array"; + return nullopt; } for (std::size_t i = 0; i < arrayLength(*tiles); i++) { optional urlTemplate = toString(arrayMember(*tiles, i)); if (!urlTemplate) { - error = { "source tiles member must be a string" }; - return {}; + error.message = "source tiles member must be a string"; + return nullopt; } result.tiles.push_back(std::move(*urlTemplate)); } @@ -43,7 +43,7 @@ optional Converter::operator()(const Convertible& value, Error if (encoding && *encoding == "terrarium") { result.encoding = Tileset::DEMEncoding::Terrarium; } else if (encoding && *encoding != "mapbox") { - error = { "invalid raster-dem encoding type - valid types are 'mapbox' and 'terrarium' " }; + error.message = "invalid raster-dem encoding type - valid types are 'mapbox' and 'terrarium' "; } } @@ -51,8 +51,8 @@ optional Converter::operator()(const Convertible& value, Error if (minzoomValue) { optional minzoom = toNumber(*minzoomValue); if (!minzoom || *minzoom < 0 || *minzoom > std::numeric_limits::max()) { - error = { "invalid minzoom" }; - return {}; + error.message = "invalid minzoom"; + return nullopt; } result.zoomRange.min = *minzoom; } @@ -61,8 +61,8 @@ optional Converter::operator()(const Convertible& value, Error if (maxzoomValue) { optional maxzoom = toNumber(*maxzoomValue); if (!maxzoom || *maxzoom < 0 || *maxzoom > std::numeric_limits::max()) { - error = { "invalid maxzoom" }; - return {}; + error.message = "invalid maxzoom"; + return nullopt; } result.zoomRange.max = *maxzoom; } @@ -71,8 +71,8 @@ optional Converter::operator()(const Convertible& value, Error if (attributionValue) { optional attribution = toString(*attributionValue); if (!attribution) { - error = { "source attribution must be a string" }; - return {}; + error.message = "source attribution must be a string"; + return nullopt; } result.attribution = std::move(*attribution); } @@ -80,8 +80,8 @@ optional Converter::operator()(const Convertible& value, Error auto boundsValue = objectMember(value, "bounds"); if (boundsValue) { if (!isArray(*boundsValue) || arrayLength(*boundsValue) != 4) { - error = { "bounds must be an array with left, bottom, top, and right values" }; - return {}; + error.message = "bounds must be an array with left, bottom, top, and right values"; + return nullopt; } optional left = toDouble(arrayMember(*boundsValue, 0)); optional bottom = toDouble(arrayMember(*boundsValue, 1)); @@ -89,20 +89,20 @@ optional Converter::operator()(const Convertible& value, Error optional top = toDouble(arrayMember(*boundsValue, 3)); if (!left || !right || !bottom || !top) { - error = { "bounds array must contain numeric longitude and latitude values" }; - return {}; + error.message = "bounds array must contain numeric longitude and latitude values"; + return nullopt; } bottom = util::clamp(*bottom, -90.0, 90.0); top = util::clamp(*top, -90.0, 90.0); if (top <= bottom){ - error = { "bounds bottom latitude must be smaller than top latitude" }; - return {}; + error.message = "bounds bottom latitude must be smaller than top latitude"; + return nullopt; } if(*left >= *right) { - error = { "bounds left longitude should be less than right longitude" }; - return {}; + error.message = "bounds left longitude should be less than right longitude"; + return nullopt; } left = util::max(-180.0, *left); right = util::min(180.0, *right); diff --git a/src/mbgl/style/conversion/transition_options.cpp b/src/mbgl/style/conversion/transition_options.cpp index 116d44f9d9..924032a0c0 100644 --- a/src/mbgl/style/conversion/transition_options.cpp +++ b/src/mbgl/style/conversion/transition_options.cpp @@ -6,8 +6,8 @@ namespace conversion { optional Converter::operator()(const Convertible& value, Error& error) const { if (!isObject(value)) { - error = { "transition must be an object" }; - return {}; + error.message = "transition must be an object"; + return nullopt; } optional result = TransitionOptions{}; @@ -16,8 +16,8 @@ optional Converter::operator()(const Conve if (duration) { auto number = toNumber(*duration); if (!number) { - error = { "duration must be a number" }; - return {}; + error.message = "duration must be a number"; + return nullopt; } result->duration = { std::chrono::milliseconds(int64_t(*number)) }; } @@ -26,8 +26,8 @@ optional Converter::operator()(const Conve if (delay) { auto number = toNumber(*delay); if (!number) { - error = { "delay must be a number" }; - return {}; + error.message = "delay must be a number"; + return nullopt; } result->delay = { std::chrono::milliseconds(int64_t(*number)) }; } -- cgit v1.2.1