From 4f995b03cd81af997351a67f3aab430877d547f1 Mon Sep 17 00:00:00 2001 From: Chris Loer Date: Tue, 31 Oct 2017 15:52:44 -0700 Subject: Changes for circle-ci clang-tidy. --- src/mbgl/layout/symbol_projection.hpp | 2 +- src/mbgl/renderer/buckets/symbol_bucket.hpp | 4 ++-- src/mbgl/text/collision_index.cpp | 2 +- src/mbgl/text/cross_tile_symbol_index.hpp | 1 + 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/mbgl/layout/symbol_projection.hpp b/src/mbgl/layout/symbol_projection.hpp index 5f4f919c93..08c265a891 100644 --- a/src/mbgl/layout/symbol_projection.hpp +++ b/src/mbgl/layout/symbol_projection.hpp @@ -35,7 +35,7 @@ namespace mbgl { mat4 getLabelPlaneMatrix(const mat4& posMatrix, const bool pitchWithMap, const bool rotateWithMap, const TransformState& state, const float pixelsToTileUnits); mat4 getGlCoordMatrix(const mat4& posMatrix, const bool pitchWithMap, const bool rotateWithMap, const TransformState& state, const float pixelsToTileUnits); - typedef std::pair,float> PointAndCameraDistance; + using PointAndCameraDistance = std::pair,float>; PointAndCameraDistance project(const Point& point, const mat4& matrix); void reprojectLineLabels(gl::VertexVector&, const std::vector&, diff --git a/src/mbgl/renderer/buckets/symbol_bucket.hpp b/src/mbgl/renderer/buckets/symbol_bucket.hpp index da8514c4cf..39d8dbf804 100644 --- a/src/mbgl/renderer/buckets/symbol_bucket.hpp +++ b/src/mbgl/renderer/buckets/symbol_bucket.hpp @@ -19,9 +19,9 @@ namespace mbgl { class PlacedSymbol { public: PlacedSymbol(Point anchorPoint_, uint16_t segment_, float lowerSize_, float upperSize_, - std::array lineOffset_, WritingModeType writingModes_, const GeometryCoordinates& line_, const std::vector& tileDistances_) : + std::array lineOffset_, WritingModeType writingModes_, GeometryCoordinates line_, std::vector tileDistances_) : anchorPoint(anchorPoint_), segment(segment_), lowerSize(lowerSize_), upperSize(upperSize_), - lineOffset(lineOffset_), writingModes(writingModes_), line(line_), tileDistances(tileDistances_), hidden(false), vertexStartIndex(0) + lineOffset(lineOffset_), writingModes(writingModes_), line(std::move(line_)), tileDistances(std::move(tileDistances_)), hidden(false), vertexStartIndex(0) { } Point anchorPoint; diff --git a/src/mbgl/text/collision_index.cpp b/src/mbgl/text/collision_index.cpp index d6ca55bbd2..acd032c72d 100644 --- a/src/mbgl/text/collision_index.cpp +++ b/src/mbgl/text/collision_index.cpp @@ -265,7 +265,7 @@ std::vector CollisionIndex::queryRenderedSymbols(const Geomet polygon.push_back(convertPoint(projected)); } - typedef std::pair::BBox> QueryResult; + using QueryResult = std::pair::BBox>; std::vector thisTileFeatures; std::vector features = collisionGrid.queryWithBoxes({{minX, minY}, {maxX, maxY}}); diff --git a/src/mbgl/text/cross_tile_symbol_index.hpp b/src/mbgl/text/cross_tile_symbol_index.hpp index 3358c59366..5d2551d2ea 100644 --- a/src/mbgl/text/cross_tile_symbol_index.hpp +++ b/src/mbgl/text/cross_tile_symbol_index.hpp @@ -8,6 +8,7 @@ #include #include #include +#include namespace mbgl { -- cgit v1.2.1