From 3c23f6f9f7f92ef43cb3d78e5570976058cf49c5 Mon Sep 17 00:00:00 2001 From: "Thiago Marcos P. Santos" Date: Mon, 23 Sep 2019 13:43:40 +0300 Subject: [core] Fix bugprone-use-after-move Luckily this is an enum and was being copied. --- .clang-tidy | 1 + src/mbgl/programs/collision_box_program.hpp | 29 ++++++++++++++--------------- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 45e598fcdf..d62f2dfc53 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -1,3 +1,4 @@ Checks: '-*,bugprone-*,clang-analyzer-*,google-*,modernize-*,performance-*,-clang-analyzer-osx.*,-google-readability-braces-around-statements,-google-readability-todo,-google-runtime-int,-google-runtime-references' +WarningsAsErrors: 'bugprone-use-after-move' HeaderFilterRegex: '.*' FormatStyle: file diff --git a/src/mbgl/programs/collision_box_program.hpp b/src/mbgl/programs/collision_box_program.hpp index 1677be1250..3b5142633d 100644 --- a/src/mbgl/programs/collision_box_program.hpp +++ b/src/mbgl/programs/collision_box_program.hpp @@ -89,21 +89,20 @@ public: drawScopeIt = segment.drawScopes.emplace(layerID, context.createDrawScope()).first; } - program->draw( - context, - renderPass, - std::move(drawMode), - std::move(depthMode), - std::move(stencilMode), - std::move(colorMode), - std::move(cullFaceMode), - uniformValues, - drawScopeIt->second, - allAttributeBindings.offset(segment.vertexOffset), - textureBindings, - indexBuffer, - segment.indexOffset, - segment.indexLength); + program->draw(context, + renderPass, + drawMode, + depthMode, + stencilMode, + colorMode, + cullFaceMode, + uniformValues, + drawScopeIt->second, + allAttributeBindings.offset(segment.vertexOffset), + textureBindings, + indexBuffer, + segment.indexOffset, + segment.indexLength); } } }; -- cgit v1.2.1