From 2370461c9def1d6b09577ef3ec6782384e27c1bc Mon Sep 17 00:00:00 2001 From: Jason Wray Date: Fri, 1 Dec 2017 15:13:43 -0500 Subject: [build] Lint iOS and macOS plists on CI --- Makefile | 9 +++++++++ circle.yml | 6 ++++++ 2 files changed, 15 insertions(+) diff --git a/Makefile b/Makefile index d7678124f5..345f59c553 100644 --- a/Makefile +++ b/Makefile @@ -142,6 +142,10 @@ node: $(MACOS_PROJ_PATH) macos-test: $(MACOS_PROJ_PATH) set -o pipefail && $(MACOS_XCODEBUILD) -scheme 'CI' test $(XCPRETTY) +.PHONY: macos-lint +macos-lint: + find platform/macos -type f -name '*.plist' | xargs plutil -lint + .PHONY: xpackage xpackage: $(MACOS_PROJ_PATH) SYMBOLS=$(SYMBOLS) ./platform/macos/scripts/package.sh @@ -218,6 +222,11 @@ ios: $(IOS_PROJ_PATH) iproj: $(IOS_PROJ_PATH) open $(IOS_WORK_PATH) +.PHONY: ios-lint +ios-lint: + find platform/ios/framework -type f -name '*.plist' | xargs plutil -lint + find platform/ios/app -type f -name '*.plist' | xargs plutil -lint + .PHONY: ios-test ios-test: $(IOS_PROJ_PATH) set -o pipefail && $(IOS_XCODEBUILD_SIM) -scheme 'CI' test $(XCPRETTY) diff --git a/circle.yml b/circle.yml index ee6a833097..36d16c68d6 100644 --- a/circle.yml +++ b/circle.yml @@ -686,6 +686,9 @@ jobs: - *reset-ccache-stats - *build-ios-test - *check-public-symbols + - run: + name: Lint plist files + command: make ios-lint - *show-ccache-stats - *save-cache @@ -742,6 +745,9 @@ jobs: - *reset-ccache-stats - *build-macos-test - *check-public-symbols + - run: + name: Lint plist files + command: make macos-lint - *show-ccache-stats - *save-cache - store_artifacts: -- cgit v1.2.1