summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJason Wray <jason@mapbox.com>2018-09-18 13:55:23 -0700
committerJason Wray <jason@mapbox.com>2018-09-19 15:39:11 -0700
commitbcd135b7770cb7032e36bda995bb1dd3863f5880 (patch)
tree375b13bcbba3ab73e19fc79a8810fcfee4103f69
parent928a359242d72741ef9cb6570f3bf67dbda2fdd4 (diff)
downloadqtlocation-mapboxgl-upstream/fb-circleci-xcode10-beta.tar.gz
[ios, tests] Bump most waitForExpectationsWithTimeout's to 5supstream/fb-circleci-xcode10-beta
[skip firebase]
-rw-r--r--platform/darwin/test/MGLDocumentationExampleTests.swift2
-rw-r--r--platform/darwin/test/MGLDocumentationGuideTests.swift2
-rw-r--r--platform/darwin/test/MGLOfflineStorageTests.mm10
-rw-r--r--platform/darwin/test/MGLStyleTests.mm2
-rw-r--r--platform/ios/Integration Tests/Annotation Tests/MGLAnnotationViewIntegrationTests.m2
-rw-r--r--platform/ios/Integration Tests/MBGLIntegrationTests.m2
-rw-r--r--platform/ios/Integration Tests/MGLCameraTransitionTests.mm14
-rw-r--r--platform/ios/Integration Tests/MGLMapViewIntegrationTest.m2
-rw-r--r--platform/ios/test/MGLAnnotationViewTests.m2
-rw-r--r--platform/ios/test/MGLMapViewLayoutTests.m2
10 files changed, 20 insertions, 20 deletions
diff --git a/platform/darwin/test/MGLDocumentationExampleTests.swift b/platform/darwin/test/MGLDocumentationExampleTests.swift
index 9edb33a078..dd34b25291 100644
--- a/platform/darwin/test/MGLDocumentationExampleTests.swift
+++ b/platform/darwin/test/MGLDocumentationExampleTests.swift
@@ -34,7 +34,7 @@ class MGLDocumentationExampleTests: XCTestCase, MGLMapViewDelegate {
mapView = MGLMapView(frame: CGRect(x: 0, y: 0, width: 256, height: 256), styleURL: MGLDocumentationExampleTests.styleURL)
mapView.delegate = self
styleLoadingExpectation = expectation(description: "Map view should finish loading style")
- waitForExpectations(timeout: 1, handler: nil)
+ waitForExpectations(timeout: 5, handler: nil)
}
override func tearDown() {
diff --git a/platform/darwin/test/MGLDocumentationGuideTests.swift b/platform/darwin/test/MGLDocumentationGuideTests.swift
index 4de1d81aa9..b7f654aceb 100644
--- a/platform/darwin/test/MGLDocumentationGuideTests.swift
+++ b/platform/darwin/test/MGLDocumentationGuideTests.swift
@@ -37,7 +37,7 @@ class MGLDocumentationGuideTests: XCTestCase, MGLMapViewDelegate {
mapView = MGLMapView(frame: CGRect(x: 0, y: 0, width: 256, height: 256), styleURL: styleURL)
mapView.delegate = self
styleLoadingExpectation = expectation(description: "Map view should finish loading style")
- waitForExpectations(timeout: 1, handler: nil)
+ waitForExpectations(timeout: 5, handler: nil)
}
override func tearDown() {
diff --git a/platform/darwin/test/MGLOfflineStorageTests.mm b/platform/darwin/test/MGLOfflineStorageTests.mm
index f89d922f11..dec5eebbd0 100644
--- a/platform/darwin/test/MGLOfflineStorageTests.mm
+++ b/platform/darwin/test/MGLOfflineStorageTests.mm
@@ -86,7 +86,7 @@
pack = completionHandlerPack;
[additionCompletionHandlerExpectation fulfill];
}];
- [self waitForExpectationsWithTimeout:2 handler:nil];
+ [self waitForExpectationsWithTimeout:5 handler:nil];
XCTAssertEqual([MGLOfflineStorage sharedOfflineStorage].packs.count, countOfPacks + 1, @"Added pack should have been added to the canonical collection of packs owned by the shared offline storage object. This assertion can fail if this test is run before -testAAALoadPacks.");
@@ -124,7 +124,7 @@
return notificationPack == pack && pack.state == MGLOfflinePackStateInactive;
}];
[pack requestProgress];
- [self waitForExpectationsWithTimeout:1 handler:nil];
+ [self waitForExpectationsWithTimeout:5 handler:nil];
}
- (void)testAddPackForGeometry {
@@ -157,7 +157,7 @@
pack = completionHandlerPack;
[additionCompletionHandlerExpectation fulfill];
}];
- [self waitForExpectationsWithTimeout:2 handler:nil];
+ [self waitForExpectationsWithTimeout:5 handler:nil];
XCTAssertEqual([MGLOfflineStorage sharedOfflineStorage].packs.count, countOfPacks + 1, @"Added pack should have been added to the canonical collection of packs owned by the shared offline storage object. This assertion can fail if this test is run before -testAAALoadPacks.");
@@ -195,7 +195,7 @@
return notificationPack == pack && pack.state == MGLOfflinePackStateInactive;
}];
[pack requestProgress];
- [self waitForExpectationsWithTimeout:1 handler:nil];
+ [self waitForExpectationsWithTimeout:5 handler:nil];
pack = nil;
}
@@ -239,7 +239,7 @@
XCTAssertEqual(pack.state, MGLOfflinePackStateInvalid, @"Removed pack should be invalid in the completion handler.");
[completionHandlerExpectation fulfill];
}];
- [self waitForExpectationsWithTimeout:1 handler:nil];
+ [self waitForExpectationsWithTimeout:5 handler:nil];
XCTAssertEqual(pack.state, MGLOfflinePackStateInvalid, @"Removed pack should have been invalidated synchronously.");
diff --git a/platform/darwin/test/MGLStyleTests.mm b/platform/darwin/test/MGLStyleTests.mm
index f2a02963fc..ccab5961c9 100644
--- a/platform/darwin/test/MGLStyleTests.mm
+++ b/platform/darwin/test/MGLStyleTests.mm
@@ -33,7 +33,7 @@
self.mapView.delegate = self;
if (!self.mapView.style) {
_styleLoadingExpectation = [self expectationWithDescription:@"Map view should finish loading style."];
- [self waitForExpectationsWithTimeout:1 handler:nil];
+ [self waitForExpectationsWithTimeout:5 handler:nil];
}
}
diff --git a/platform/ios/Integration Tests/Annotation Tests/MGLAnnotationViewIntegrationTests.m b/platform/ios/Integration Tests/Annotation Tests/MGLAnnotationViewIntegrationTests.m
index ebd587ebe6..ba63a9eff4 100644
--- a/platform/ios/Integration Tests/Annotation Tests/MGLAnnotationViewIntegrationTests.m
+++ b/platform/ios/Integration Tests/Annotation Tests/MGLAnnotationViewIntegrationTests.m
@@ -102,7 +102,7 @@
[timerExpired fulfill];
});
- [self waitForExpectations:@[timerExpired, self.renderFinishedExpectation] timeout:1.0];
+ [self waitForExpectations:@[timerExpired, self.renderFinishedExpectation] timeout:5];
}
@end
diff --git a/platform/ios/Integration Tests/MBGLIntegrationTests.m b/platform/ios/Integration Tests/MBGLIntegrationTests.m
index 4f42c5a13f..aeff0ba6f3 100644
--- a/platform/ios/Integration Tests/MBGLIntegrationTests.m
+++ b/platform/ios/Integration Tests/MBGLIntegrationTests.m
@@ -186,7 +186,7 @@
XCTAssertNil(mapView2.style);
self.styleLoadingExpectation = [self expectationWithDescription:@"Map view should finish loading style."];
- [self waitForExpectationsWithTimeout:1 handler:nil];
+ [self waitForExpectationsWithTimeout:5 handler:nil];
MGLOpenGLStyleLayer *layer = [[MGLOpenGLStyleLayer alloc] initWithIdentifier:@"gl-layer"];
weakLayer = layer;
diff --git a/platform/ios/Integration Tests/MGLCameraTransitionTests.mm b/platform/ios/Integration Tests/MGLCameraTransitionTests.mm
index 0b28104c96..f29fa5e64c 100644
--- a/platform/ios/Integration Tests/MGLCameraTransitionTests.mm
+++ b/platform/ios/Integration Tests/MGLCameraTransitionTests.mm
@@ -34,7 +34,7 @@
[self.mapView setDirection:90 animated:YES];
// loop, render, and wait
- [self waitForExpectations:@[expectation] timeout:1.5];
+ [self waitForExpectations:@[expectation] timeout:5];
}
@@ -62,7 +62,7 @@
};
[self.mapView setDirection:90 animated:YES];
- [self waitForExpectations:@[expectation] timeout:1.5];
+ [self waitForExpectations:@[expectation] timeout:5];
}
- (void)testInterruptingAndResetNorthOnlyOnceInIsChanging {
@@ -106,7 +106,7 @@
};
[self.mapView setDirection:90 animated:YES];
- [self waitForExpectations:@[expectation] timeout:1.5];
+ [self waitForExpectations:@[expectation] timeout:5];
XCTAssertEqualWithAccuracy(self.mapView.direction, 0.0, 0.001, @"Camera should have reset to north. %0.3f", self.mapView.direction);
}
@@ -222,7 +222,7 @@
// Should take MGLAnimationDuration seconds (0.3)
[self.mapView setCenterCoordinate:target zoomLevel:15.0 animated:YES];
- [self waitForExpectations:@[expectation] timeout:1.5];
+ [self waitForExpectations:@[expectation] timeout:5];
}
- (void)testFlyToCameraInDelegateMethod {
@@ -323,7 +323,7 @@
// Should take MGLAnimationDuration
[self.mapView setCenterCoordinate:target zoomLevel:zoomLevel animated:YES];
- [self waitForExpectations:@[expectation] timeout:2.0];
+ [self waitForExpectations:@[expectation] timeout:5];
NSLog(@"setCenterCoordinate: %0.4fs", stop1 - stop0);
NSLog(@"flyToCamera: %0.4fs", stop2 - stop1);
@@ -362,7 +362,7 @@
};
[self.mapView setDirection:90 animated:YES];
- [self waitForExpectations:@[expectation] timeout:1.5];
+ [self waitForExpectations:@[expectation] timeout:5];
XCTAssertEqualWithAccuracy(self.mapView.direction, 0.0, 0.001, @"Camera should have reset to north. %0.3f", self.mapView.direction);
}
@@ -389,7 +389,7 @@
};
[self.mapView setCenterCoordinate:CLLocationCoordinate2DMake(40.0, 40.0) animated:YES];
- [self waitForExpectations:@[expectation] timeout:1.5];
+ [self waitForExpectations:@[expectation] timeout:5];
XCTAssertEqualWithAccuracy(self.mapView.direction, 0.0, 0.001, @"Camera should have reset to north. %0.3f", self.mapView.direction);
}
diff --git a/platform/ios/Integration Tests/MGLMapViewIntegrationTest.m b/platform/ios/Integration Tests/MGLMapViewIntegrationTest.m
index 68023f3556..8235945676 100644
--- a/platform/ios/Integration Tests/MGLMapViewIntegrationTest.m
+++ b/platform/ios/Integration Tests/MGLMapViewIntegrationTest.m
@@ -33,7 +33,7 @@
[window makeKeyAndVisible];
if (!self.mapView.style) {
- [self waitForMapViewToFinishLoadingStyleWithTimeout:1];
+ [self waitForMapViewToFinishLoadingStyleWithTimeout:5];
}
}
diff --git a/platform/ios/test/MGLAnnotationViewTests.m b/platform/ios/test/MGLAnnotationViewTests.m
index 7bf7c90a33..6c3cd6ea4a 100644
--- a/platform/ios/test/MGLAnnotationViewTests.m
+++ b/platform/ios/test/MGLAnnotationViewTests.m
@@ -85,7 +85,7 @@ static NSString * const MGLTestAnnotationReuseIdentifer = @"MGLTestAnnotationReu
MGLTestAnnotation *annotation = [[MGLTestAnnotation alloc] init];
[_mapView addAnnotation:annotation];
- [self waitForExpectationsWithTimeout:1 handler:nil];
+ [self waitForExpectationsWithTimeout:5 handler:nil];
XCTAssert(_mapView.annotations.count == 1, @"number of annotations should be 1");
XCTAssertNotNil(_annotationView.annotation, @"annotation property should not be nil");
diff --git a/platform/ios/test/MGLMapViewLayoutTests.m b/platform/ios/test/MGLMapViewLayoutTests.m
index 16f6cdada3..4bdff51e25 100644
--- a/platform/ios/test/MGLMapViewLayoutTests.m
+++ b/platform/ios/test/MGLMapViewLayoutTests.m
@@ -35,7 +35,7 @@
[self.superView addConstraints:[verticalConstraints arrayByAddingObjectsFromArray:horizonatalConstraints]];
self.styleLoadingExpectation = [self expectationWithDescription:@"Map view should finish loading style."];
- [self waitForExpectationsWithTimeout:1 handler:nil];
+ [self waitForExpectationsWithTimeout:5 handler:nil];
self.mapView.showsScale = YES;