summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJohn Firebaugh <john.firebaugh@gmail.com>2016-05-16 16:33:24 -0700
committerJohn Firebaugh <john.firebaugh@gmail.com>2016-05-17 13:20:25 -0700
commit3c49fdc99d9177a2751361f3151cc562aa1f77a3 (patch)
tree719a95c6e75f48f0668f85a8860a809e891d0672
parentb7d395fcf64f4098f3a3ca01f8613f2249d60fa3 (diff)
downloadqtlocation-mapboxgl-3c49fdc99d9177a2751361f3151cc562aa1f77a3.tar.gz
[core] Feature IDs are always integers
-rw-r--r--include/mbgl/util/feature.hpp2
-rw-r--r--platform/node/src/node_feature.cpp2
-rw-r--r--src/mbgl/geometry/feature_index.cpp6
3 files changed, 3 insertions, 7 deletions
diff --git a/include/mbgl/util/feature.hpp b/include/mbgl/util/feature.hpp
index c9dbc31769..7747d34ee9 100644
--- a/include/mbgl/util/feature.hpp
+++ b/include/mbgl/util/feature.hpp
@@ -13,7 +13,7 @@ public:
Feature(geometry_type&& geometry_)
: mapbox::geometry::feature<double> { std::move(geometry_) } {}
- optional<Value> id {};
+ optional<uint64_t> id;
};
} // namespace mbgl
diff --git a/platform/node/src/node_feature.cpp b/platform/node/src/node_feature.cpp
index 7175f9d1fa..1a5e31fe97 100644
--- a/platform/node/src/node_feature.cpp
+++ b/platform/node/src/node_feature.cpp
@@ -159,7 +159,7 @@ v8::Local<v8::Object> toJS(const Feature& feature) {
Nan::Set(result, Nan::New("properties").ToLocalChecked(), toJS(feature.properties));
if (feature.id) {
- Nan::Set(result, Nan::New("id").ToLocalChecked(), toJS(*feature.id));
+ Nan::Set(result, Nan::New("id").ToLocalChecked(), Nan::New(double(*feature.id)));
}
return scope.Escape(result);
diff --git a/src/mbgl/geometry/feature_index.cpp b/src/mbgl/geometry/feature_index.cpp
index d3d523af0a..fb68b572b1 100644
--- a/src/mbgl/geometry/feature_index.cpp
+++ b/src/mbgl/geometry/feature_index.cpp
@@ -123,11 +123,7 @@ void FeatureIndex::addFeature(
Feature feature { mapbox::geometry::point<double>() };
feature.properties = geometryTileFeature->getProperties();
-
- optional<uint64_t> id = geometryTileFeature->getID();
- if (id) {
- feature.id = Value(*id);
- }
+ feature.id = geometryTileFeature->getID();
result[layerID].push_back(std::move(feature));
}