delta/qt5/qtbase.git/tests/auto/corelib/tools, branch dev

QVarLengthArray/QList: make assign() return a reference to *this

2023-05-17T04:44:45+00:00

While std::vector::assign() returns void, std::basic_string::assign()
returns std::basic_string&. In Qt, we want to be consistent between
{QVLA,QList,QString,QByteArray}::assign(), and returning *this is the
more general solution, so do that.

Task-number: QTBUG-106196
Task-number: QTBUG-106200
Change-Id: I2689b4af032ab6fb3f8fbcb4d825d5201ea5abeb
Reviewed-by: Mårten Nordheim 
Reviewed-by: Qt CI Bot

QList: re-use the prepend buffer, if any, on assign()

2023-05-17T04:44:39+00:00

Task-number: QTBUG-106196
Change-Id: I62d8610529cab528ae1b114d29707133b4fc28dc
Reviewed-by: Mårten Nordheim 
Reviewed-by: Qt CI Bot

QList: add STL-style assign()

2023-05-16T18:09:39+00:00

Implemented assign() methods for QList to align with the criteria of
std::vector, addressing the previously missing functionality.

Reference:
https://en.cppreference.com/w/cpp/container/vector/assign

[ChangeLog][QtCore][QList] Added assign().

Fixes: QTBUG-106196
Change-Id: I5df8689c020dafde68d2cd7d09c769744fa8f137
Reviewed-by: Marc Mutz 
Reviewed-by: Mårten Nordheim

tst_ContainerApiSymmetry: fix spacing of template

2023-05-16T18:09:39+00:00

This file, like the majority of qtbase, uses a space between template
and the opening of the template argument list. Add it.

Change-Id: I927cb2b1b9620ae108e913343d995373493e8981
Reviewed-by: Mårten Nordheim

Darwin: Remove QMacAutoReleasePool heap allocation detection

2023-05-15T13:51:00+00:00

This is handled by the Objective-C runtime nowadays, where it will
abort if the situation is detected, with the option to break on
objc_autoreleasePoolInvalid to debug the situation.

Pick-to: 6.5
Change-Id: Idf2c4aacc77e41a3deebf270303f4f13cfb0819b
Reviewed-by: Timur Pocheptsov

Clean up phrasing of --help-all and other help options

2023-05-15T12:02:43+00:00

The options included by --help-all, although they are "specific to
Qt", are "specific" to all Qt applications, so - in the present
context, of QCommandLineParser - not specific at all. It's the options
described by -h that are specific, to the present command; the Qt
options are generic (in the present context).

So rework the help string for --help-all itself and the documentation
of the function. It had, in any case, an overly-complex first line,
that descended into too much detail. Updated test to match.

Pick-to: 6.5
Task-number: QTBUG-111228
Change-Id: I06da0af41be60e6e1b7616984001ddb9ca33aad6
Reviewed-by: Marc Mutz 
Reviewed-by: David Faure

tst_ContainerApiSymmetry: make assign_impl() robust w.r.t. overallocation

2023-05-13T14:58:36+00:00

The parameter passed to reserve() is just a hint. The container
implementation is free to choose a larger capacity, and some do
(e.g. QList in prepend optimization mode).

Fix the test by querying the container for its post-make<>()
capacity() and taking a larger-than-expected initial capacity() into
account when later re-checking the capacity().

Change-Id: Id8f26f14e8df9d685ca2387ec4a52d74fea7cb9d
Reviewed-by: Ivan Solovev 
Reviewed-by: Qt CI Bot

tst_ContainerApiSymmetry: make a comment more precise

2023-05-13T14:58:27+00:00

It took me a sec to figure out the relation between the comment and
the code line following it. Make it easier for the next guy and add a
bit more infos.

Amends 7cbdc8abbda12488f51317313347bbc220b42fe0.

Change-Id: I4ff2d9a52aef643a92339df32cc86f686a689a9a
Reviewed-by: Dennis Oberst 
Reviewed-by: Ivan Solovev

tst_ContainerApiSymmetry: follow file's style for assign() tests

2023-05-13T14:58:19+00:00

We use a single line per test slot everywhere else, ignoring even
line-length limitations, to keep the function names aligned for easier
parsing.

Amends 7cbdc8abbda12488f51317313347bbc220b42fe0.

Change-Id: Iaf2941aae88392d407d688fc4a7537fcdc0a5851
Reviewed-by: Dennis Oberst 
Reviewed-by: Ivan Solovev

tst_ContainerApiSymmetry: fix mutable lambda anti-pattern

2023-05-13T14:58:10+00:00

STL algorithms, in general, don't specify how often the function
objects passed to them are copied during the run of the
algorithm.

While generate_n is above any reasonable suspicion of copying the
function object after the first invocation, passing a mutable lambda
containing the counter is still an anti-pattern we don't want people
to copy.

Fix in the usual way, by keeping the counter external to the lambda.

As a drive-by, replace post- with pre-increment.

Amends dc091e74431acbe66ae7921ba82d3eb34ae8cc55.

Pick-to: 6.5 6.2
Change-Id: I9c44e769fd41e5f7157179a2be4c3534424cf913
Reviewed-by: Ivan Solovev