From 4511a3873ca18a59b9fb5e442fb8cb8ff6e640fc Mon Sep 17 00:00:00 2001
From: Mike Krus <mike.krus@kdab.com>
Date: Sun, 28 May 2017 22:35:29 +0100
Subject: QNodeCommand: Fix API review comments

Implement QNodeCommandPrivate dtor out-of-line and mark the
(Private, NodeId) ctor explicit.

Amends 44420de26b3ff7999ef2a932c2cae058d794b155.

Change-Id: Ic234e123c64a9e8bb2eef480dec9e91f0ceba585
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
---
 src/core/changes/qnodecommand.cpp | 4 ++++
 src/core/changes/qnodecommand.h   | 2 +-
 src/core/changes/qnodecommand_p.h | 1 +
 3 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/core/changes/qnodecommand.cpp b/src/core/changes/qnodecommand.cpp
index fc7e01697..ae5ae46f1 100644
--- a/src/core/changes/qnodecommand.cpp
+++ b/src/core/changes/qnodecommand.cpp
@@ -50,6 +50,10 @@ QNodeCommandPrivate::QNodeCommandPrivate()
 {
 }
 
+QNodeCommandPrivate::~QNodeCommandPrivate()
+{
+}
+
 QNodeCommand::CommandId QNodeCommandPrivate::createId()
 {
     static QBasicAtomicInteger<QNodeCommand::CommandId> next = Q_BASIC_ATOMIC_INITIALIZER(0);
diff --git a/src/core/changes/qnodecommand.h b/src/core/changes/qnodecommand.h
index c02365a59..f4371b03c 100644
--- a/src/core/changes/qnodecommand.h
+++ b/src/core/changes/qnodecommand.h
@@ -70,7 +70,7 @@ public:
     void setReplyToCommandId(CommandId id);
 
 protected:
-    QNodeCommand(QNodeCommandPrivate &dd, QNodeId id);
+    explicit QNodeCommand(QNodeCommandPrivate &dd, QNodeId id);
 
 private:
     Q_DECLARE_PRIVATE(QNodeCommand)
diff --git a/src/core/changes/qnodecommand_p.h b/src/core/changes/qnodecommand_p.h
index 09be873f5..dd4259b20 100644
--- a/src/core/changes/qnodecommand_p.h
+++ b/src/core/changes/qnodecommand_p.h
@@ -59,6 +59,7 @@ class QT3DCORE_PRIVATE_EXPORT QNodeCommandPrivate : public QSceneChangePrivate
 {
 public:
     QNodeCommandPrivate();
+    ~QNodeCommandPrivate();
 
     static QNodeCommand::CommandId createId();
 
-- 
cgit v1.2.1