From c87284356c1e27d7f0324a5201d9281ed7e73522 Mon Sep 17 00:00:00 2001 From: Eike Ziller Date: Tue, 16 Feb 2021 14:51:16 +0100 Subject: VCS: Do not write defaults to settings Saves useless entries in settings file and makes it possible to change defaults later. Task-number: QTCREATORBUG-24762 Change-Id: Iee7d39f2bf5d8de6903ca914ea533a678fad62f8 Reviewed-by: Orgad Shaneh --- src/plugins/vcsbase/commonvcssettings.cpp | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) (limited to 'src/plugins/vcsbase/commonvcssettings.cpp') diff --git a/src/plugins/vcsbase/commonvcssettings.cpp b/src/plugins/vcsbase/commonvcssettings.cpp index 182e5b35ac..b9be1d343a 100644 --- a/src/plugins/vcsbase/commonvcssettings.cpp +++ b/src/plugins/vcsbase/commonvcssettings.cpp @@ -64,15 +64,13 @@ CommonVcsSettings::CommonVcsSettings() : void CommonVcsSettings::toSettings(Utils::QtcSettings *s) const { - s->beginGroup(QLatin1String(settingsGroupC)); - s->setValue(QLatin1String(nickNameMailMapKeyC), nickNameMailMap); - s->setValue(QLatin1String(nickNameFieldListFileKeyC), nickNameFieldListFile); - s->setValue(QLatin1String(submitMessageCheckScriptKeyC), submitMessageCheckScript); - s->setValue(QLatin1String(lineWrapKeyC), lineWrap); - s->setValue(QLatin1String(lineWrapWidthKeyC), lineWrapWidth); - s->setValueWithDefault(QLatin1String(sshPasswordPromptKeyC), - sshPasswordPrompt, - sshPasswordPromptDefault()); + s->beginGroup(settingsGroupC); + s->setValueWithDefault(nickNameMailMapKeyC, nickNameMailMap); + s->setValueWithDefault(nickNameFieldListFileKeyC, nickNameFieldListFile); + s->setValueWithDefault(submitMessageCheckScriptKeyC, submitMessageCheckScript); + s->setValueWithDefault(lineWrapKeyC, lineWrap, lineWrapDefault); + s->setValueWithDefault(lineWrapWidthKeyC, lineWrapWidth, lineWrapWidthDefault); + s->setValueWithDefault(sshPasswordPromptKeyC, sshPasswordPrompt, sshPasswordPromptDefault()); s->endGroup(); } -- cgit v1.2.1