From 3cce72dcf50126a8da1b8352de732bc15e73574b Mon Sep 17 00:00:00 2001 From: hjk Date: Tue, 12 Jul 2011 16:47:32 +0200 Subject: analyzer: merge valgrind related settings This mainly reduces the number of tabs in the settings dialog. Change-Id: I62ba5c74585648c8f495602cd4d676d0628de9b5 Reviewed-on: http://codereview.qt.nokia.com/1575 Reviewed-by: Qt Sanity Bot Reviewed-by: Eike Ziller --- src/plugins/valgrind/valgrindplugin.cpp | 30 +++++------------------------- 1 file changed, 5 insertions(+), 25 deletions(-) (limited to 'src/plugins/valgrind/valgrindplugin.cpp') diff --git a/src/plugins/valgrind/valgrindplugin.cpp b/src/plugins/valgrind/valgrindplugin.cpp index 86ac42e97f..77353ed0d3 100644 --- a/src/plugins/valgrind/valgrindplugin.cpp +++ b/src/plugins/valgrind/valgrindplugin.cpp @@ -34,9 +34,7 @@ #include "valgrindplugin.h" -#include "callgrindsettings.h" #include "callgrindtool.h" -#include "memchecksettings.h" #include "memchecktool.h" #include "valgrindsettings.h" @@ -44,7 +42,6 @@ #include #include #include -#include #include #include @@ -199,36 +196,19 @@ void ValgrindPlugin::startValgrindTool(IAnalyzerTool *tool, StartMode mode) startRemoteTool(tool, mode); } -static AbstractAnalyzerSubConfig *valgrindConfigFactory() +static AbstractAnalyzerSubConfig *globalValgrindFactory() { - return new ValgrindSettings(); + return new ValgrindGlobalSettings(); } -static AbstractAnalyzerSubConfig *globalCallgrindFactory() +static AbstractAnalyzerSubConfig *projectValgrindFactory() { - return new CallgrindGlobalSettings(); -} - -static AbstractAnalyzerSubConfig *projectCallgrindFactory() -{ - return new CallgrindProjectSettings(); -} - -static AbstractAnalyzerSubConfig *globalMemcheckFactory() -{ - return new MemcheckGlobalSettings(); -} - -static AbstractAnalyzerSubConfig *projectMemcheckFactory() -{ - return new MemcheckProjectSettings(); + return new ValgrindProjectSettings(); } bool ValgrindPlugin::initialize(const QStringList &, QString *) { - AnalyzerGlobalSettings::instance()->registerSubConfigs(&valgrindConfigFactory, &valgrindConfigFactory); - AnalyzerGlobalSettings::instance()->registerSubConfigs(&globalCallgrindFactory, &projectCallgrindFactory); - AnalyzerGlobalSettings::instance()->registerSubConfigs(&globalMemcheckFactory, &projectMemcheckFactory); + AnalyzerGlobalSettings::instance()->registerSubConfigs(&globalValgrindFactory, &projectValgrindFactory); StartModes modes; #ifndef Q_OS_WIN -- cgit v1.2.1