From 2def95374d018898a484e34eca2e66effe0ac7f6 Mon Sep 17 00:00:00 2001 From: Orgad Shaneh Date: Mon, 30 Jan 2017 09:12:47 +0200 Subject: Git: Fix crash on Commit + Push to Gerrit Task-number: QTCREATORBUG-17634 Change-Id: I60d8067fe9cfc23acb688e06506363bca67ec0a5 Reviewed-by: Tobias Hunger --- src/plugins/git/gitplugin.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'src/plugins/git/gitplugin.cpp') diff --git a/src/plugins/git/gitplugin.cpp b/src/plugins/git/gitplugin.cpp index 9049828235..8d664496a4 100644 --- a/src/plugins/git/gitplugin.cpp +++ b/src/plugins/git/gitplugin.cpp @@ -1051,10 +1051,12 @@ bool GitPlugin::submitEditorAboutToClose() m_gitClient->interactiveRebase(m_submitRepository, amendSHA1, true); } else { m_gitClient->continueCommandIfNeeded(m_submitRepository); - if (editor->panelData().pushAction == NormalPush) + if (editor->panelData().pushAction == NormalPush) { m_gitClient->push(m_submitRepository); - else if (editor->panelData().pushAction == PushToGerrit) - connect(editor, &QObject::destroyed, this, &GitPlugin::delayedPushToGerrit); + } else if (editor->panelData().pushAction == PushToGerrit) { + connect(editor, &QObject::destroyed, this, &GitPlugin::delayedPushToGerrit, + Qt::QueuedConnection); + } } return true; -- cgit v1.2.1