From 87b1dc25a1c67815f88041fbe57794e4099655e2 Mon Sep 17 00:00:00 2001 From: Denis Mingulov Date: Thu, 16 Feb 2012 09:55:47 +0200 Subject: Debugger: use QString::fromLatin1 instead of QString::fromAscii By source - latin1 is really expected as there is no any check or usage of QTextCodec::setCodecForCStrings() currently. QString::fromAscii() might break 'Latin1' input in some cases. A quote from documentation about QString::fromAscii(): "Note that, despite the name, this function actually uses the codec defined by QTextCodec::setCodecForCStrings() to convert str to Unicode. Depending on the codec, it may not accept valid US-ASCII (ANSI X3.4-1986) input. If no codec has been set, this function does the same as fromLatin1()." Change-Id: I49cf047ca674d2ec621b517c635d1927bb2e796f Reviewed-by: Friedemann Kleint Reviewed-by: hjk --- src/plugins/debugger/gdb/symbian.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/plugins/debugger/gdb/symbian.cpp') diff --git a/src/plugins/debugger/gdb/symbian.cpp b/src/plugins/debugger/gdb/symbian.cpp index d690077ba0..a7f7abdf2a 100644 --- a/src/plugins/debugger/gdb/symbian.cpp +++ b/src/plugins/debugger/gdb/symbian.cpp @@ -620,7 +620,7 @@ QByteArray symFileLoadCommand(const QString &symFileNameIn, QString msgLoadLocalSymFile(const QString &symFileName, const QByteArray &libName, quint64 code) { - return QString::fromAscii("Loading symbol file '%1' for '%2' at 0x%3"). + return QString::fromLatin1("Loading symbol file '%1' for '%2' at 0x%3"). arg(symFileName, QString::fromLatin1(libName)). arg(code, 0, 16); } -- cgit v1.2.1