From 08d1274ccc0e9b116626afad60afaa970fe2fbbf Mon Sep 17 00:00:00 2001 From: Ivan Donchevskii Date: Wed, 21 Feb 2018 11:58:16 +0100 Subject: CppTools: Remove processEvents call from follow symbol processEvents is a bad way of dealing with asynchronous requests. Use QFutureWatcher for that purpose. Change-Id: I3839cb9db80a6d391f6af1178e96986a325b7b99 Reviewed-by: Marco Bubke --- src/plugins/clangrefactoring/refactoringengine.cpp | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) (limited to 'src/plugins/clangrefactoring/refactoringengine.cpp') diff --git a/src/plugins/clangrefactoring/refactoringengine.cpp b/src/plugins/clangrefactoring/refactoringengine.cpp index 7c69cfc9d1..952ed9bf19 100644 --- a/src/plugins/clangrefactoring/refactoringengine.cpp +++ b/src/plugins/clangrefactoring/refactoringengine.cpp @@ -123,11 +123,12 @@ void RefactoringEngine::findUsages(const CppTools::CursorInEditor &data, showUsagesCallback(locationsAt(data)); } -RefactoringEngine::Link RefactoringEngine::globalFollowSymbol(const CppTools::CursorInEditor &data, - const CPlusPlus::Snapshot &, - const CPlusPlus::Document::Ptr &, - CppTools::SymbolFinder *, - bool) const +void RefactoringEngine::globalFollowSymbol(const CppTools::CursorInEditor &data, + Utils::ProcessLinkCallback &&processLinkCallback, + const CPlusPlus::Snapshot &, + const CPlusPlus::Document::Ptr &, + CppTools::SymbolFinder *, + bool) const { // TODO: replace that with specific followSymbol query const CppTools::Usages usages = locationsAt(data); @@ -138,7 +139,7 @@ RefactoringEngine::Link RefactoringEngine::globalFollowSymbol(const CppTools::Cu return true; }); - return Link(usage.path, usage.line, usage.column); + processLinkCallback(Link(usage.path, usage.line, usage.column)); } bool RefactoringEngine::isRefactoringEngineAvailable() const -- cgit v1.2.1