From 15b2765dff1cbba30b41da2bc48cd15bfce7f2a7 Mon Sep 17 00:00:00 2001 From: Eike Ziller Date: Mon, 18 Nov 2019 16:57:44 +0100 Subject: Update Qt validity in options when changing Android device settings When changing the Android device settings and pressing "Apply", the information in the "Qt Versions" tab is no longer correct. The Abi information is parsed from the mkspec, and that depends on the NDK setting in the environment. When the NDK in the device settings changes, it updates the toolchains, and that triggers a re-validation of the Qt info in QtOptionsPageWidget::validInformation, but since the Android Qt version already has tried parsing the mkspec, and got (possibly empty) Abi information, it never is parsed and updated again. We need a way to force BaseQtVersion to update these things again. Fixes: QTCREATORBUG-23095 Change-Id: I9cb55ad1a73db942804637344e4c856c7e95afd3 Reviewed-by: Christian Kandeler --- src/plugins/android/androidqtversion.h | 1 + 1 file changed, 1 insertion(+) (limited to 'src/plugins/android/androidqtversion.h') diff --git a/src/plugins/android/androidqtversion.h b/src/plugins/android/androidqtversion.h index c986960819..5098f53356 100644 --- a/src/plugins/android/androidqtversion.h +++ b/src/plugins/android/androidqtversion.h @@ -58,6 +58,7 @@ public: protected: void parseMkSpec(ProFileEvaluator *) const override; private: + std::unique_ptr m_guard; mutable QStringList m_androidAbis; mutable int m_minNdk = -1; }; -- cgit v1.2.1