From 91004e0de3083c6b0fed78171609081d16d83965 Mon Sep 17 00:00:00 2001 From: David Schulz Date: Fri, 16 Nov 2018 08:58:03 +0100 Subject: Help: fix calling QDesktopServices::openUrl when opening about:blank Workaround QTBUG-71833 Fixes: QTCREATORBUG-21515 Change-Id: Iffa363ab94a8f71d958b04932c9829887bb00dd7 Reviewed-by: Eike Ziller (cherry picked from commit fc5caf3e0fff736acf1fc6c30e95b9b40089c03d) Reviewed-by: David Schulz --- src/plugins/help/helpviewer.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/plugins/help/helpviewer.cpp b/src/plugins/help/helpviewer.cpp index e2cac11fc9..f1a568e918 100644 --- a/src/plugins/help/helpviewer.cpp +++ b/src/plugins/help/helpviewer.cpp @@ -138,6 +138,10 @@ bool HelpViewer::launchWithExternalApp(const QUrl &url) const QUrl &resolvedUrl = helpEngine.findFile(url); if (!resolvedUrl.isValid()) return false; + // Workaround QTBUG-71833 + // QHelpEngineCore::findFile returns a valid url even though the file does not exist + if (resolvedUrl.scheme() == "about" && resolvedUrl.path() == "blank") + return false; const QString& path = resolvedUrl.path(); if (!canOpenPage(path)) { -- cgit v1.2.1