From 6ff6fe3b0e2569dc58d17a926e78d840ed14979c Mon Sep 17 00:00:00 2001 From: hjk Date: Tue, 27 Sep 2022 11:16:17 +0200 Subject: VcsBase: Remove Q_PROPERTY definitions The initial intention was to make these widgets usable from Designer. We don't expect a lot of new uses in this direction, and clazy seems to warn about not-so-complete Q_PROPERTY definitions: Link https://github.com/KDE/clazy/blob/master/docs/checks/README-qproperty-without-notify.md Change-Id: I4a2e9ff6ec7ecfd989196801c789533b4c44e8af Reviewed-by: Jarek Kobus Reviewed-by: Orgad Shaneh --- src/plugins/vcsbase/submiteditorwidget.h | 6 ------ src/plugins/vcsbase/submitfieldwidget.h | 3 --- src/plugins/vcsbase/vcsbaseeditor.h | 5 ----- src/plugins/vcsbase/vcsbasesubmiteditor.h | 4 ---- 4 files changed, 18 deletions(-) diff --git a/src/plugins/vcsbase/submiteditorwidget.h b/src/plugins/vcsbase/submiteditorwidget.h index 9c239d9e78..63fd833710 100644 --- a/src/plugins/vcsbase/submiteditorwidget.h +++ b/src/plugins/vcsbase/submiteditorwidget.h @@ -22,12 +22,6 @@ class SubmitFileModel; class VCSBASE_EXPORT SubmitEditorWidget : public QWidget { Q_OBJECT - Q_PROPERTY(QString descriptionText READ descriptionText WRITE setDescriptionText DESIGNABLE true) - Q_PROPERTY(QAbstractItemView::SelectionMode fileListSelectionMode READ fileListSelectionMode WRITE setFileListSelectionMode DESIGNABLE true) - Q_PROPERTY(bool lineWrap READ lineWrap WRITE setLineWrap DESIGNABLE true) - Q_PROPERTY(int lineWrapWidth READ lineWrapWidth WRITE setLineWrapWidth DESIGNABLE true) - Q_PROPERTY(bool descriptionMandatory READ isDescriptionMandatory WRITE setDescriptionMandatory DESIGNABLE false) - Q_PROPERTY(bool emptyFileListEnabled READ isEmptyFileListEnabled WRITE setEmptyFileListEnabled DESIGNABLE true) public: SubmitEditorWidget(); diff --git a/src/plugins/vcsbase/submitfieldwidget.h b/src/plugins/vcsbase/submitfieldwidget.h index 0ba391d42e..7fd1aebba3 100644 --- a/src/plugins/vcsbase/submitfieldwidget.h +++ b/src/plugins/vcsbase/submitfieldwidget.h @@ -18,9 +18,6 @@ struct SubmitFieldWidgetPrivate; class VCSBASE_EXPORT SubmitFieldWidget : public QWidget { Q_OBJECT - Q_PROPERTY(QStringList fields READ fields WRITE setFields DESIGNABLE true) - Q_PROPERTY(bool hasBrowseButton READ hasBrowseButton WRITE setHasBrowseButton DESIGNABLE true) - Q_PROPERTY(bool allowDuplicateFields READ allowDuplicateFields WRITE setAllowDuplicateFields DESIGNABLE true) public: explicit SubmitFieldWidget(QWidget *parent = nullptr); diff --git a/src/plugins/vcsbase/vcsbaseeditor.h b/src/plugins/vcsbase/vcsbaseeditor.h index badb7985fb..2bb4109ed8 100644 --- a/src/plugins/vcsbase/vcsbaseeditor.h +++ b/src/plugins/vcsbase/vcsbaseeditor.h @@ -110,11 +110,6 @@ public: class VCSBASE_EXPORT VcsBaseEditorWidget : public TextEditor::TextEditorWidget { - Q_PROPERTY(QString source READ source WRITE setSource) - Q_PROPERTY(Utils::FilePath workingDirectory READ workingDirectory WRITE setWorkingDirectory) - Q_PROPERTY(QTextCodec *codec READ codec WRITE setCodec) - Q_PROPERTY(QString annotateRevisionTextFormat READ annotateRevisionTextFormat WRITE setAnnotateRevisionTextFormat) - Q_PROPERTY(bool isFileLogAnnotateEnabled READ isFileLogAnnotateEnabled WRITE setFileLogAnnotateEnabled) Q_OBJECT protected: diff --git a/src/plugins/vcsbase/vcsbasesubmiteditor.h b/src/plugins/vcsbase/vcsbasesubmiteditor.h index 742e13ac22..41e1fc5265 100644 --- a/src/plugins/vcsbase/vcsbasesubmiteditor.h +++ b/src/plugins/vcsbase/vcsbasesubmiteditor.h @@ -36,10 +36,6 @@ public: class VCSBASE_EXPORT VcsBaseSubmitEditor : public Core::IEditor { Q_OBJECT - Q_PROPERTY(QAbstractItemView::SelectionMode fileListSelectionMode READ fileListSelectionMode WRITE setFileListSelectionMode DESIGNABLE true) - Q_PROPERTY(bool lineWrap READ lineWrap WRITE setLineWrap DESIGNABLE true) - Q_PROPERTY(int lineWrapWidth READ lineWrapWidth WRITE setLineWrapWidth DESIGNABLE true) - Q_PROPERTY(bool emptyFileListEnabled READ isEmptyFileListEnabled WRITE setEmptyFileListEnabled DESIGNABLE true) protected: explicit VcsBaseSubmitEditor(SubmitEditorWidget *editorWidget); -- cgit v1.2.1