From 66f603628b62b6865ebd039b729713c0a64ae851 Mon Sep 17 00:00:00 2001 From: Eike Ziller Date: Fri, 22 May 2015 15:19:17 +0200 Subject: Items were removed from QML overview when dragging onto editor view Change-Id: I6e8b3cbedb78df08066f87d4aa9922145cfa151c Task-number: QTCREATORBUG-14496 Reviewed-by: Daniel Teske Reviewed-by: Marco Benelli Reviewed-by: Alessandro Portale --- src/plugins/coreplugin/editormanager/editorview.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/plugins/coreplugin/editormanager/editorview.cpp b/src/plugins/coreplugin/editormanager/editorview.cpp index 85fb0baf32..425323c2bc 100644 --- a/src/plugins/coreplugin/editormanager/editorview.cpp +++ b/src/plugins/coreplugin/editormanager/editorview.cpp @@ -135,6 +135,12 @@ EditorView::EditorView(SplitterOrView *parentSplitterOrView, QWidget *parent) : m_widgetEditorMap.insert(empty, 0); auto dropSupport = new FileDropSupport(this, [this](QDropEvent *event) { + // do not accept move events except from other editor views (i.e. their tool bars) + // otherwise e.g. item views that support moving items within themselves would + // also "move" the item into the editor view, i.e. the item would be removed from the + // item view + if (!qobject_cast(event->source())) + event->setDropAction(Qt::CopyAction); return event->source() != m_toolBar; // do not accept drops on ourselves }); connect(dropSupport, &FileDropSupport::filesDropped, -- cgit v1.2.1