diff options
author | hjk <hjk@qt.io> | 2022-02-15 12:44:04 +0100 |
---|---|---|
committer | hjk <hjk@qt.io> | 2022-02-15 13:43:09 +0000 |
commit | 47957de2dcef70b644290c0d6b35f07837160e8a (patch) | |
tree | 9cb2e887865b113defa30a56a8e6724a97e9f7b9 /src/plugins/valgrind/callgrind | |
parent | 13ed522d8d1beba4609c7ae02eceb5240fe18009 (diff) | |
download | qt-creator-47957de2dcef70b644290c0d6b35f07837160e8a.tar.gz |
ProjectExplorer: Split ApplicationLauncher::start() parameters
There's traditionally an odd duplication of the runnable.device
and the passed device here. Start disentangling things.
Change-Id: I1cc1628c99cea04d761fc4d8dd0cb232127ce055
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Diffstat (limited to 'src/plugins/valgrind/callgrind')
-rw-r--r-- | src/plugins/valgrind/callgrind/callgrindcontroller.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/plugins/valgrind/callgrind/callgrindcontroller.cpp b/src/plugins/valgrind/callgrind/callgrindcontroller.cpp index 83f98cc71b..263d58d235 100644 --- a/src/plugins/valgrind/callgrind/callgrindcontroller.cpp +++ b/src/plugins/valgrind/callgrind/callgrindcontroller.cpp @@ -126,11 +126,12 @@ void CallgrindController::run(Option option) controller.command.setExecutable(FilePath::fromString(CALLGRIND_CONTROL_BINARY)); controller.command.setArguments(QString("%1 %2").arg(toOptionString(option)).arg(m_pid)); + m_controllerProcess->setRunnable(controller); if (!m_valgrindRunnable.device || m_valgrindRunnable.device->type() == ProjectExplorer::Constants::DESKTOP_DEVICE_TYPE) - m_controllerProcess->start(controller); + m_controllerProcess->start(); else - m_controllerProcess->start(controller, m_valgrindRunnable.device); + m_controllerProcess->start(m_valgrindRunnable.device); } void CallgrindController::setValgrindPid(qint64 pid) |