Use const'ref in theses methods

Change-Id: Idfa5ffdcf23d1ef80442276690b8082b8279dbfa
Reviewed-by: Eike Ziller <eike.ziller@qt.io>

5 files changed, 5 insertions, 5 deletions

diff --git a/src/plugins/texteditor/colorpreviewhoverhandler.cpp b/src/plugins/texteditor/colorpreviewhoverhandler.cpp
index 448c40de41..c6ca5947d0 100644
--- a/src/plugins/texteditor/colorpreviewhoverhandler.cpp
+++ b/src/plugins/texteditor/colorpreviewhoverhandler.cpp
@@ -44,7 +44,7 @@ namespace TextEditor {
  * Qt::GlobalColor types (although there cannot be any spaces such as
  * "Qt:: yellow")
  */
-static QString extractColorString(const QString s, int pos)
+static QString extractColorString(const QString &s, int pos)
 {
     if (s.length() < 3 || pos < 0 || pos >= s.length())
         return QString();
diff --git a/src/plugins/texteditor/tabsettings.cpp b/src/plugins/texteditor/tabsettings.cpp
index 0bf4bc2995..fb9e93859b 100644
--- a/src/plugins/texteditor/tabsettings.cpp
+++ b/src/plugins/texteditor/tabsettings.cpp
@@ -312,7 +312,7 @@ QString TabSettings::indentationString(int startColumn, int targetColumn, int pa
     return s;
 }
 
-void TabSettings::indentLine(QTextBlock block, int newIndent, int padding) const
+void TabSettings::indentLine(const QTextBlock &block, int newIndent, int padding) const
 {
     const QString text = block.text();
     const int oldBlockLength = text.size();
diff --git a/src/plugins/texteditor/tabsettings.h b/src/plugins/texteditor/tabsettings.h
index 01ea77c5bb..b1316b4cb1 100644
--- a/src/plugins/texteditor/tabsettings.h
+++ b/src/plugins/texteditor/tabsettings.h
@@ -74,7 +74,7 @@ public:
     int indentationColumn(const QString &text) const;
     static int maximumPadding(const QString &text);
 
-    void indentLine(QTextBlock block, int newIndent, int padding = 0) const;
+    void indentLine(const QTextBlock &block, int newIndent, int padding = 0) const;
     void reindentLine(QTextBlock block, int delta) const;
 
     bool isIndentationClean(const QTextBlock &block, const int indent) const;
diff --git a/src/plugins/texteditor/typingsettings.cpp b/src/plugins/texteditor/typingsettings.cpp
index ae0f2149fc..13440c259f 100644
--- a/src/plugins/texteditor/typingsettings.cpp
+++ b/src/plugins/texteditor/typingsettings.cpp
@@ -80,7 +80,7 @@ bool TypingSettings::equals(const TypingSettings &ts) const
         && m_smartBackspaceBehavior == ts.m_smartBackspaceBehavior;
 }
 
-bool TypingSettings::tabShouldIndent(const QTextDocument *document, QTextCursor cursor, int *suggestedPosition) const
+bool TypingSettings::tabShouldIndent(const QTextDocument *document, const QTextCursor &cursor, int *suggestedPosition) const
 {
     if (m_tabKeyBehavior == TabNeverIndents)
         return false;
diff --git a/src/plugins/texteditor/typingsettings.h b/src/plugins/texteditor/typingsettings.h
index f71fb3c6cc..2fd37f016e 100644
--- a/src/plugins/texteditor/typingsettings.h
+++ b/src/plugins/texteditor/typingsettings.h
@@ -56,7 +56,7 @@ public:
 
     TypingSettings();
 
-    bool tabShouldIndent(const QTextDocument *document, QTextCursor cursor, int *suggestedPosition) const;
+    bool tabShouldIndent(const QTextDocument *document, const QTextCursor &cursor, int *suggestedPosition) const;
 
     void toSettings(const QString &category, QSettings *s) const;
     void fromSettings(const QString &category, const QSettings *s);