diff options
| author | Marco Bubke <marco.bubke@qt.io> | 2022-09-15 13:07:45 +0200 |
|---|---|---|
| committer | Tim Jenssen <tim.jenssen@qt.io> | 2022-09-22 19:08:12 +0000 |
| commit | 0be4de69d8839795e11e17e80865ffb1825bb433 (patch) | |
| tree | 25ca122592d15152f8193fb4b64f870331820050 /src/plugins/qmldesigner/components/edit3d/edit3dview.cpp | |
| parent | 4bb4e07ad8419ba4edc1d9cb543ab8a0ddb1d07d (diff) | |
| download | qt-creator-0be4de69d8839795e11e17e80865ffb1825bb433.tar.gz | |
QmlDesigner: Remove parent from abstract view
We apply not very often the parent to views. So it can lead to dangling
pointer if the parent is used by other objects and does not handle the
null pointer case. It can lead to double deletion if the parent is
deleted before the object when it is on the stack or handled by smart
pointer.
If you really want to use it there is still setParent.
Change-Id: I1fc6b145a50f037a0e9d415fb36e7970ea7296ed
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Diffstat (limited to 'src/plugins/qmldesigner/components/edit3d/edit3dview.cpp')
| -rw-r--r-- | src/plugins/qmldesigner/components/edit3d/edit3dview.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/plugins/qmldesigner/components/edit3d/edit3dview.cpp b/src/plugins/qmldesigner/components/edit3d/edit3dview.cpp index 696a574dc0..54195cf78c 100644 --- a/src/plugins/qmldesigner/components/edit3d/edit3dview.cpp +++ b/src/plugins/qmldesigner/components/edit3d/edit3dview.cpp @@ -31,8 +31,7 @@ namespace QmlDesigner { -Edit3DView::Edit3DView(QObject *parent) - : AbstractView(parent) +Edit3DView::Edit3DView() { m_compressionTimer.setInterval(1000); m_compressionTimer.setSingleShot(true); |