diff options
| author | Tobias Hunger <tobias.hunger@qt.io> | 2018-06-14 15:46:33 +0200 |
|---|---|---|
| committer | Tobias Hunger <tobias.hunger@qt.io> | 2018-06-15 12:12:01 +0000 |
| commit | 4ceed778f84ec2c04bcd64d873145a23f61a141c (patch) | |
| tree | b1e4b0755a3167331a4fbd6538c4b1b9d964b870 /src/plugins/projectexplorer/abiwidget.cpp | |
| parent | 35844008e21c9086ce0503e3639939dba960a3fa (diff) | |
| download | qt-creator-4ceed778f84ec2c04bcd64d873145a23f61a141c.tar.gz | |
Abi: Clean up constructors
Only have one constructor. Get rid of implicit conversion from QString
to Abi -- that seems rather non-obvious. Use Abi::fromString(...) instead.
Change-Id: Ic638d3d4022c465123449089b0679197a5eb445d
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Diffstat (limited to 'src/plugins/projectexplorer/abiwidget.cpp')
| -rw-r--r-- | src/plugins/projectexplorer/abiwidget.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/plugins/projectexplorer/abiwidget.cpp b/src/plugins/projectexplorer/abiwidget.cpp index efff460634..577bd2e983 100644 --- a/src/plugins/projectexplorer/abiwidget.cpp +++ b/src/plugins/projectexplorer/abiwidget.cpp @@ -197,7 +197,7 @@ QList<Abi> AbiWidget::supportedAbis() const QList<Abi> result; result.reserve(d->m_abi->count()); for (int i = 1; i < d->m_abi->count(); ++i) - result << Abi(d->m_abi->itemData(i).toString()); + result << Abi::fromString(d->m_abi->itemData(i).toString()); return result; } @@ -240,7 +240,7 @@ void AbiWidget::mainComboBoxChanged() if (d->m_ignoreChanges.isLocked()) return; - const Abi newAbi = d->m_abi->currentData().toString(); + const Abi newAbi = Abi::fromString(d->m_abi->currentData().toString()); const bool customMode = d->isCustom(); d->m_architectureComboBox->setEnabled(customMode); @@ -254,7 +254,7 @@ void AbiWidget::mainComboBoxChanged() if (customMode) customComboBoxesChanged(); else - emitAbiChanged(Abi(d->m_abi->currentData().toString())); + emitAbiChanged(Abi::fromString(d->m_abi->currentData().toString())); } void AbiWidget::customComboBoxesChanged() |