diff options
author | Alessandro Portale <alessandro.portale@qt.io> | 2020-01-15 19:10:34 +0100 |
---|---|---|
committer | Alessandro Portale <alessandro.portale@qt.io> | 2020-01-20 20:56:57 +0000 |
commit | 24a25eed1481a7c563431d79e3ad07840c0f7125 (patch) | |
tree | 3eb8a56dac620a31e6af362bf7c03201ea645771 /src/plugins/autotest | |
parent | ad4040972b9d763b2ceaa7444d18e65dd3da2ee9 (diff) | |
download | qt-creator-24a25eed1481a7c563431d79e3ad07840c0f7125.tar.gz |
Use isEmpty() instead of count() or size()
Change-Id: I0a89d2808c6d041da0dc41ea5aea58e6e8759bb4
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Diffstat (limited to 'src/plugins/autotest')
-rw-r--r-- | src/plugins/autotest/boost/boosttestparser.cpp | 2 | ||||
-rw-r--r-- | src/plugins/autotest/gtest/gtestconfiguration.cpp | 2 | ||||
-rw-r--r-- | src/plugins/autotest/gtest/gtestparser.cpp | 2 | ||||
-rw-r--r-- | src/plugins/autotest/itestparser.cpp | 2 | ||||
-rw-r--r-- | src/plugins/autotest/qtest/qttestconfiguration.cpp | 2 | ||||
-rw-r--r-- | src/plugins/autotest/qtest/qttestvisitors.cpp | 2 | ||||
-rw-r--r-- | src/plugins/autotest/quick/quicktestconfiguration.cpp | 2 |
7 files changed, 7 insertions, 7 deletions
diff --git a/src/plugins/autotest/boost/boosttestparser.cpp b/src/plugins/autotest/boost/boosttestparser.cpp index 6f953e515a..09c216c1b6 100644 --- a/src/plugins/autotest/boost/boosttestparser.cpp +++ b/src/plugins/autotest/boost/boosttestparser.cpp @@ -144,7 +144,7 @@ static bool handleBoostTest(QFutureInterface<TestParseResultPtr> futureInterface firstSuite); BoostTestParseResult *currentSuite = topLevelSuite; suitesStates.removeFirst(); - while (suitesStates.size()) { + while (!suitesStates.isEmpty()) { firstSuite = suitesStates.first(); suites = firstSuite.fullName.split('/'); BoostTestParseResult *suiteResult = createParseResult(suites.last(), filePath, diff --git a/src/plugins/autotest/gtest/gtestconfiguration.cpp b/src/plugins/autotest/gtest/gtestconfiguration.cpp index 0608c3db72..e662f3702f 100644 --- a/src/plugins/autotest/gtest/gtestconfiguration.cpp +++ b/src/plugins/autotest/gtest/gtestconfiguration.cpp @@ -83,7 +83,7 @@ QStringList GTestConfiguration::argumentsForTestRunner(QStringList *omitted) con } const QStringList &testSets = testCases(); - if (testSets.size()) + if (!testSets.isEmpty()) arguments << "--gtest_filter=" + testSets.join(':'); TestFrameworkManager *manager = TestFrameworkManager::instance(); diff --git a/src/plugins/autotest/gtest/gtestparser.cpp b/src/plugins/autotest/gtest/gtestparser.cpp index f57f774ec0..e5eecf44ff 100644 --- a/src/plugins/autotest/gtest/gtestparser.cpp +++ b/src/plugins/autotest/gtest/gtestparser.cpp @@ -103,7 +103,7 @@ static bool handleGTest(QFutureInterface<TestParseResultPtr> futureInterface, QMap<GTestCaseSpec, GTestCodeLocationList> result = visitor.gtestFunctions(); QString proFile; const QList<CppTools::ProjectPart::Ptr> &ppList = modelManager->projectPart(filePath); - if (ppList.size()) + if (!ppList.isEmpty()) proFile = ppList.first()->projectFile; else return false; // happens if shutting down while parsing diff --git a/src/plugins/autotest/itestparser.cpp b/src/plugins/autotest/itestparser.cpp index f0310041d7..316245cdee 100644 --- a/src/plugins/autotest/itestparser.cpp +++ b/src/plugins/autotest/itestparser.cpp @@ -51,7 +51,7 @@ bool CppParser::selectedForBuilding(const QString &fileName) QList<CppTools::ProjectPart::Ptr> projParts = CppTools::CppModelManager::instance()->projectPart(fileName); - return projParts.size() && projParts.at(0)->selectedForBuilding; + return !projParts.isEmpty() && projParts.at(0)->selectedForBuilding; } QByteArray CppParser::getFileContent(const QString &filePath) diff --git a/src/plugins/autotest/qtest/qttestconfiguration.cpp b/src/plugins/autotest/qtest/qttestconfiguration.cpp index 86fce62f80..1212f3b852 100644 --- a/src/plugins/autotest/qtest/qttestconfiguration.cpp +++ b/src/plugins/autotest/qtest/qttestconfiguration.cpp @@ -65,7 +65,7 @@ QStringList QtTestConfiguration::argumentsForTestRunner(QStringList *omitted) co return arguments; if (qtSettings->useXMLOutput) arguments << "-xml"; - if (testCases().count()) + if (!testCases().isEmpty()) arguments << testCases(); const QString &metricsOption = QtTestSettings::metricsTypeToOption(qtSettings->metrics); diff --git a/src/plugins/autotest/qtest/qttestvisitors.cpp b/src/plugins/autotest/qtest/qttestvisitors.cpp index 48177921bf..7b8374985b 100644 --- a/src/plugins/autotest/qtest/qttestvisitors.cpp +++ b/src/plugins/autotest/qtest/qttestvisitors.cpp @@ -128,7 +128,7 @@ bool TestAstVisitor::visit(CallAST *ast) QList<LookupItem> toeItems = toe(argumentExpressionAST, m_currentDoc, m_currentScope); - if (toeItems.size()) { + if (!toeItems.isEmpty()) { if (const auto pointerType = toeItems.first().type()->asPointerType()) m_className = o.prettyType(pointerType->elementType()); } diff --git a/src/plugins/autotest/quick/quicktestconfiguration.cpp b/src/plugins/autotest/quick/quicktestconfiguration.cpp index 024b2223c2..57d075fe7d 100644 --- a/src/plugins/autotest/quick/quicktestconfiguration.cpp +++ b/src/plugins/autotest/quick/quicktestconfiguration.cpp @@ -72,7 +72,7 @@ QStringList QuickTestConfiguration::argumentsForTestRunner(QStringList *omitted) return arguments; if (qtSettings->useXMLOutput) arguments << "-xml"; - if (testCases().count()) + if (!testCases().isEmpty()) arguments << testCases(); const QString &metricsOption = QtTestSettings::metricsTypeToOption(qtSettings->metrics); |