TargetSetupWidget: Do not always pre-expand selected kits

Does not add much value (anymore), except in the import case.
Expanded targets take away a lot of space, pushing other targets
or potential kits out of the visible area

Change-Id: Iff0c46643b0fccef7e272a036d0c9c3a099ccc1f
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

3 files changed, 7 insertions, 2 deletions

diff --git a/src/plugins/projectexplorer/targetsetuppage.cpp b/src/plugins/projectexplorer/targetsetuppage.cpp
index 1c528efdfa..08d6587308 100644
--- a/src/plugins/projectexplorer/targetsetuppage.cpp
+++ b/src/plugins/projectexplorer/targetsetuppage.cpp
@@ -458,6 +458,7 @@ void TargetSetupPage::import(const Utils::FileName &path, bool silent)
 
         widget->addBuildInfo(info, true);
         widget->setKitSelected(true);
+        widget->expandWidget();
     }
     emit completeChanged();
 }
diff --git a/src/plugins/projectexplorer/targetsetupwidget.cpp b/src/plugins/projectexplorer/targetsetupwidget.cpp
index a1d718be99..281f2809cc 100644
--- a/src/plugins/projectexplorer/targetsetupwidget.cpp
+++ b/src/plugins/projectexplorer/targetsetupwidget.cpp
@@ -148,8 +148,6 @@ void TargetSetupWidget::setKitSelected(bool b)
     m_detailsWidget->setChecked(b);
     m_detailsWidget->widget()->setEnabled(b);
     m_ignoreChange = false;
-
-    m_detailsWidget->setState(b ? Utils::DetailsWidget::Expanded : Utils::DetailsWidget::Collapsed);
 }
 
 void TargetSetupWidget::addBuildInfo(BuildInfo *info, bool isImport)
@@ -256,6 +254,11 @@ void TargetSetupWidget::setProjectPath(const QString &projectPath)
         addBuildInfo(info, false);
 }
 
+void TargetSetupWidget::expandWidget()
+{
+    m_detailsWidget->setState(Utils::DetailsWidget::Expanded);
+}
+
 void TargetSetupWidget::handleKitUpdate(Kit *k)
 {
     if (k != m_kit)
diff --git a/src/plugins/projectexplorer/targetsetupwidget.h b/src/plugins/projectexplorer/targetsetupwidget.h
index f4d8b436d4..bb321e55ab 100644
--- a/src/plugins/projectexplorer/targetsetupwidget.h
+++ b/src/plugins/projectexplorer/targetsetupwidget.h
@@ -76,6 +76,7 @@ public:
 
     QList<const BuildInfo *> selectedBuildInfoList() const;
     void setProjectPath(const QString &projectPath);
+    void expandWidget();
 
 signals:
     void selectedToggled() const;