delta/qt-creator.git/src/plugins/coreplugin/dialogs, branch master code.qt.io: qt-creator/qt-creator.git Utils: Make PagedSettings::readSettings() calls shorter 2023-05-16T16:36:25+00:00 hjk hjk@qt.io 2023-05-16T11:06:18+00:00 6c5fb656d63efddcdc7e98e58aae04f2ae718c50 Ideally, this would not be needed on the user code side at all, but there's no way to ensure the settings are read timing before sibling constructors might need it. So keep the 'poor man's two-phase initialization', but make it less intrusive. Change-Id: Ica7f6510cd05072d7286f4e85cd72c494e8f10f8 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io> 
Ideally, this would not be needed on the user code side at all, but
there's no way to ensure the settings are read timing before sibling
constructors might need it. So keep the 'poor man's two-phase
initialization', but make it less intrusive.

Change-Id: Ica7f6510cd05072d7286f4e85cd72c494e8f10f8
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Core: Make PagedSettings autoapply by default in the base 2023-05-11T13:43:58+00:00 hjk hjk@qt.io 2023-05-10T15:04:22+00:00 56146960029ee843812a5386908d0ea3aaf8ad93 Instead of relying (and forgetting...) it in all derived clases. Change-Id: I5d1dea0ace420d464c39c192278ae6e5db01de90 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io> 
Instead of relying (and forgetting...) it in all derived clases.

Change-Id: I5d1dea0ace420d464c39c192278ae6e5db01de90
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Core: PagedSettings, next attempt 2023-05-10T15:22:49+00:00 hjk hjk@qt.io 2023-05-10T10:59:35+00:00 47e0e9be29ebebccf3ad08f7b1553ab5bd009513 We cannnot pass the LayoutItem directly but need the lambda to postpone creation of aspect subwidgets until the settings page gets into view. Change-Id: I420e82f66fd5c4781451d6851cc38368e7501abc Reviewed-by: Alessandro Portale <alessandro.portale@qt.io> 
We cannnot pass the LayoutItem directly but need the lambda
to postpone creation of aspect subwidgets until the settings
page gets into view.

Change-Id: I420e82f66fd5c4781451d6851cc38368e7501abc
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Core: Remove QObject base of IOptionsPage 2023-05-10T08:06:14+00:00 hjk hjk@qt.io 2023-05-08T12:36:11+00:00 2c433f7fe1b47b3fd497f87e51e248c70323a3f5 Change-Id: I714fd0cdd542da947deb2a8395dec87bb40fca75 Reviewed-by: Christian Stenger <christian.stenger@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> 
Change-Id: I714fd0cdd542da947deb2a8395dec87bb40fca75
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Core: Introduce a IOptionsPage::setLayout(const LayoutItem) 2023-05-10T05:01:09+00:00 hjk hjk@qt.io 2023-05-09T16:08:46+00:00 e206ed5236c6ca1846c7a9add8976fb8cac07672 Helps to move the lambda setup off the user code. Change-Id: I0de43f53fc9018913340e81b5c1e8e69df067bd6 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io> 
Helps to move the lambda setup off the user code.

Change-Id: I0de43f53fc9018913340e81b5c1e8e69df067bd6
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Core: Introduce PagedSettings 2023-05-10T05:00:40+00:00 hjk hjk@qt.io 2023-05-09T15:47:15+00:00 f9fd83df9ad4be3eb99dbd7569813a02887ca3fe An AspectContainer with an IOptionsPage. Change-Id: I03d460f788cfcb2c631b2789bc8f7c74a0b62a37 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io> 
An AspectContainer with an IOptionsPage.

Change-Id: I03d460f788cfcb2c631b2789bc8f7c74a0b62a37
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Core: Remove QObject inheritance of IOptionsPageProvider 2023-05-08T12:40:26+00:00 hjk hjk@qt.io 2023-05-08T12:25:50+00:00 80a425acbae5334b70b468921173240e502ceeb3 This was not really used. Change-Id: I86049697d211d88827a9633b367d2121fa8d1f1c Reviewed-by: Eike Ziller <eike.ziller@qt.io> 
This was not really used.

Change-Id: I86049697d211d88827a9633b367d2121fa8d1f1c
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Core: Remove parent pointer from IOptionPage constructor 2023-05-08T12:27:32+00:00 hjk hjk@qt.io 2023-05-08T12:09:09+00:00 851f317199ec15a6cf0483580c09efa2ab9bde58 Not used anymore. Change-Id: Ic44ce021b1f952337a3193454b5b6649d5847446 Reviewed-by: Eike Ziller <eike.ziller@qt.io> 
Not used anymore.

Change-Id: Ic44ce021b1f952337a3193454b5b6649d5847446
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Utils: Rename qtcprocess.{cpp,h} -> process.{cpp,h} 2023-05-04T05:52:26+00:00 Jarek Kobus jaroslaw.kobus@qt.io 2023-05-03T15:05:35+00:00 a0f6e8dc04291138ec2305fe7c02a0a460f57fac Follows QtcProcess -> Process rename. Change-Id: I97235a9a40cb7fd52944515b7ab878d96528f919 Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> 
Follows QtcProcess -> Process rename.

Change-Id: I97235a9a40cb7fd52944515b7ab878d96528f919
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Layouts: Add/remove contentMargins where needed 2023-05-04T05:38:33+00:00 Alessandro Portale alessandro.portale@qt.io 2023-05-03T18:47:53+00:00 e5051bbfdef896ece974a949a392de7337284bf0 Some cases were preexisting, some were introduced recently Change-Id: I0e7e7b74422c420fbf4563d7cbf384e53931c3a0 Reviewed-by: hjk <hjk@qt.io> 
Some cases were preexisting, some were introduced recently

Change-Id: I0e7e7b74422c420fbf4563d7cbf384e53931c3a0
Reviewed-by: hjk <hjk@qt.io>