Fix misuse of Function.prototype.apply

We were using the following pattern to pass the current arguments object
to functions:
    Foo.func.apply(this, arguments)
This is wrong as it changes the this object of func from Foo to
the this object of the calling context.

The right way to pass the current arguments object is
    Foo.func.apply(Foo, arguments)

Change-Id: Ie30dea98a9ce78a402677e146dd35fa2b96672ab
Reviewed-by: Jake Petroules <jake.petroules@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>

1 files changed, 5 insertions, 5 deletions

diff --git a/share/qbs/modules/cpp/windows-msvc.qbs b/share/qbs/modules/cpp/windows-msvc.qbs
index 8aab2a026..09b6f3a4f 100644
--- a/share/qbs/modules/cpp/windows-msvc.qbs
+++ b/share/qbs/modules/cpp/windows-msvc.qbs
@@ -128,7 +128,7 @@ CppModule {
             filePath: ".obj/" + product.name + '_c.pch_copy'
         }
         prepare: {
-            return MSVC.prepareCompiler.apply(this, arguments);
+            return MSVC.prepareCompiler.apply(MSVC, arguments);
         }
     }
 
@@ -151,7 +151,7 @@ CppModule {
         }
 
         prepare: {
-            return MSVC.prepareCompiler.apply(this, arguments);
+            return MSVC.prepareCompiler.apply(MSVC, arguments);
         }
     }
 
@@ -167,7 +167,7 @@ CppModule {
         }
 
         prepare: {
-            return MSVC.prepareCompiler.apply(this, arguments);
+            return MSVC.prepareCompiler.apply(MSVC, arguments);
         }
     }
 
@@ -198,7 +198,7 @@ CppModule {
         }
 
         prepare: {
-            return MSVC.prepareLinker.apply(this, arguments);
+            return MSVC.prepareLinker.apply(MSVC, arguments);
         }
     }
 
@@ -234,7 +234,7 @@ CppModule {
         }
 
         prepare: {
-            return MSVC.prepareLinker.apply(this, arguments);
+            return MSVC.prepareLinker.apply(MSVC, arguments);
         }
     }