delta/qbs.git/src/lib/buildgraph/rulesevaluationcontext.cpp, branch dynablaster

Some minor improvements to the Error class.

2013-06-18T08:57:25+00:00

- Rename "Error" to "ErrorInfo", to make clear that this class conveys
information about errors, including that there might not actually be
one.
- Rename "ErrorData" to "ErrorItem", to make clear that these are parts
of an aggregate structure.
- Introduce ErrorInfo::hasError() for quick checking of whether an error
occurred.

Change-Id: Icea6ed5240d6d14bd30e9cea189c6babd7004792
Reviewed-by: Joerg Bornemann

Help compiler with branch prediction.

2013-04-12T13:10:46+00:00

Mark error checks in potentially performance-sensitive
contexts with Q_UNLIKELY. Actual benefits unknown,
but it cannot hurt.

Change-Id: If3d2375965e6342b5d7a0b46ad2c8a41fd3567d0
Reviewed-by: Joerg Bornemann

cache Rule.prepare scripts as function objects

2013-03-27T09:19:13+00:00

For Rule.prepare a function object is created on demand. This function
object is called on every rule application. The QScriptProgram cache
turns out to be quite useless.

This caching approach saves roughly 5% of time of the whole resolve
phase.

Magic persistence number changed, because the createCommands
method now expects prepare scripts in function form.

Change-Id: Ie531dcfb5f21578548a5961ddaa6086ae441a2b0
Reviewed-by: Christian Kandeler

replace Q_ASSERT with QBS_ASSERT / QBS_CHECK

2013-02-14T15:29:33+00:00

Change-Id: I9f4d43b9b7be7e4ce814963d1feee81605a9d2eb
Reviewed-by: Christian Kandeler

Remove global log sink.

2013-02-06T09:36:05+00:00

Applications may not want to use the same log sink for all builds.

The logging facility is also decoupled from the command-line client in other
ways:
    - The LogWriter modifiers for output channel and text color are gone,
      since this type of decision should not be made by low-level code.
      Instead, the "highlight" string can be forwarded to the log sink.
    - The console logger now lives in app/shared, as it must never be used
      by library code.

Change-Id: I8863a554c9b74577320ef23f6f934a74e0f0cbb0
Reviewed-by: Joerg Bornemann

update copyright year

2013-01-09T13:51:06+00:00

Change-Id: Ic2962e57ede037b910d7e77b01b0163f0a22cb7d
Reviewed-by: Christian Kandeler

Some engine-related optimizations.

2012-12-05T10:10:57+00:00

- Re-enable script program cache; it is safe to use now.
- Create a new evaluation context only for the first build of a project.
- To help with all of this, use a shared pointer for
  RulesEvaluationContext, as it does not have a clear owner.

Change-Id: I90a7fcaf855573b756f29daff37038e98aa7c1fe
Reviewed-by: Joerg Bornemann

Split up buildgraph.h and buildgraph.cpp.

2012-12-04T10:49:46+00:00

Move things to the appropriate places.

Change-Id: I2f201ccdf9c465a8c3201e229629b756cc258495
Reviewed-by: Joerg Bornemann

Move engine-related functionality out of BuildGraph.

2012-12-03T10:07:09+00:00

Change-Id: I5da16ea99bce3e6f737f37770fb0fe3e2e5c0214
Reviewed-by: Joerg Bornemann