delta/qbs.git/src/lib/buildgraph/executorjob.cpp, branch dynablaster

Some minor improvements to the Error class.

2013-06-18T08:57:25+00:00

- Rename "Error" to "ErrorInfo", to make clear that this class conveys
information about errors, including that there might not actually be
one.
- Rename "ErrorData" to "ErrorItem", to make clear that these are parts
of an aggregate structure.
- Introduce ErrorInfo::hasError() for quick checking of whether an error
occurred.

Change-Id: Icea6ed5240d6d14bd30e9cea189c6babd7004792
Reviewed-by: Joerg Bornemann

Remove structural redundancy in project and product classes.

2013-04-12T12:19:12+00:00

We had two project classes, each holding a list of products
that was structurally identical, except that no BuildProduct
object existed for a disabled ResolvedProduct. The same kind
of duplication also happened for product dependencies.
This patch gets rid of these parallel structures. BuildProject
and BuildProduct are largely being demoted to data holders and are
aggregated by ResolvedProject and ResolvedProduct, respectively.
The resulting project structure should be easier to understand
and maintain.

Change-Id: I68beef60b9e0d62258f6a8337c9015864e18bd80
Reviewed-by: Joerg Bornemann

replace Q_ASSERT with QBS_ASSERT / QBS_CHECK

2013-02-14T15:29:33+00:00

Change-Id: I9f4d43b9b7be7e4ce814963d1feee81605a9d2eb
Reviewed-by: Christian Kandeler

Remove global log sink.

2013-02-06T09:36:05+00:00

Applications may not want to use the same log sink for all builds.

The logging facility is also decoupled from the command-line client in other
ways:
    - The LogWriter modifiers for output channel and text color are gone,
      since this type of decision should not be made by low-level code.
      Instead, the "highlight" string can be forwarded to the log sink.
    - The console logger now lives in app/shared, as it must never be used
      by library code.

Change-Id: I8863a554c9b74577320ef23f6f934a74e0f0cbb0
Reviewed-by: Joerg Bornemann

Do not write directly into logger

2013-01-11T10:49:26+00:00

Pass information up to the client instead so that it can
decide how to handle it.

This allows e.g. creator to parse compile output for build
issues.

Change-Id: I76be4eaeb289b211b7d2527b555536b556655492
Reviewed-by: Christian Kandeler

update copyright year

2013-01-09T13:51:06+00:00

Change-Id: Ic2962e57ede037b910d7e77b01b0163f0a22cb7d
Reviewed-by: Christian Kandeler

Split up buildgraph.h and buildgraph.cpp.

2012-12-04T10:49:46+00:00

Move things to the appropriate places.

Change-Id: I2f201ccdf9c465a8c3201e229629b756cc258495
Reviewed-by: Joerg Bornemann

Reduce compile dependencies.

2012-11-29T13:43:08+00:00

While it seems elegant at first glance to do typedefs in class scope, it
has one serious drawback: Forward declarations become impossible unless
they use the non-typedef'ed type name, which defeats the purpose. As a
result, dozens of headers currently include language.h and buildgraph.h,
even though they technically don't have to.
Fix this by introducing special forward-declaring headers and doing the
typedefs there, outside the class scope. Now changes to header files
included in language.h or buildgraph.h don't ripple through half the
project anymore.
Along the way, also remove unneeded and potentially harmful INCLUDEPATH
statements from various pri files.

Change-Id: Ib50db850876955216db7f39b6099c32d1239092b
Reviewed-by: Joerg Bornemann

Introduce namespace Internal.

2012-11-08T14:03:50+00:00

This makes it obvious at first glance which facilities are for
public use and which are not, which should be useful especially
for clients of the library.

Change-Id: I7f74f13b5c8a4c63a1de57bf607084a3a3852653
Reviewed-by: Joerg Bornemann

ExecutorJob: Fix assertion.

2012-10-23T14:13:13+00:00

The command index can be out of range if cancel() has been called
earlier.

Change-Id: Iba04c0785fdc3db44f120d3a6d9c12c248bfd2ca
Reviewed-by: Joerg Bornemann