delta/python-setuptools-git.git/setuptools/command/build_py.py, branch v63.2.0 github.com: pypa/setuptools.git Change warning about namespace packages and data files 2022-06-09T12:55:39+00:00 Anderson Bravalheri andersonbravalheri@gmail.com 2022-06-09T12:55:39+00:00 e91918d69443eb7ef1e1d84dca277965ef048ade This follows a suggestion given by users to improve clarity. 
This follows a suggestion given by users to improve clarity.
Improve warning message for package data abuse 2022-06-05T10:07:35+00:00 Anderson Bravalheri andersonbravalheri@gmail.com 2022-06-05T10:07:35+00:00 bb0eb4ebf8d289c6c37926bfadd44fe78548c01a 






Update setuptools/command/build_py.py
2022-05-18T13:34:41+00:00

Anderson Bravalheri
andersonbravalheri+github@gmail.com

2022-05-18T13:34:41+00:00

3eba1cb02fba0d00ef65a653a3a729e5a524d771

Co-authored-by: Michał Górny <mgorny@gentoo.org>




Co-authored-by: Michał Górny <mgorny@gentoo.org>






Improve warning message for _IncludePackageDataAbuse
2022-05-18T11:07:44+00:00

Anderson Bravalheri
andersonbravalheri@gmail.com

2022-05-18T10:33:49+00:00

89173d2f8e88e9fc735806a237215f50df72e962












Warn about deprecation of behaviour that considers modules/packages as data when include_package_data=True (#3308)
2022-05-16T17:34:35+00:00

Anderson Bravalheri
andersonbravalheri@gmail.com

2022-05-16T17:34:35+00:00

e66ee6206feb49fe4bdec417c84d601d6b4bbf72












Allow recursive globs for package_data
2022-05-07T13:35:36+00:00

nullableVoidPtr
30564701+nullableVoidPtr@users.noreply.github.com

2022-05-07T13:25:55+00:00

ed6790fb0220686c648c578726c92664984bcaec












Simplify checks for abuse of include_package_data
2022-05-06T09:09:48+00:00

Anderson Bravalheri
andersonbravalheri@gmail.com

2022-05-06T09:09:48+00:00

2b218927334c58a655fc285a5c241828d394cffe

Previously, the checks would result in a warning per module additionally
to the parent package.

Now only one warning per parent package is issued.





Previously, the checks would result in a warning per module additionally
to the parent package.

Now only one warning per parent package is issued.







Warn about packages/modules included as package data
2022-05-05T18:34:46+00:00

Anderson Bravalheri
andersonbravalheri@gmail.com

2022-05-05T18:34:46+00:00

56a8b90551411024f792efe853c48de5e5097e59












Remove data_files avoidance code.
2021-11-03T01:39:32+00:00

Jason R. Coombs
jaraco@jaraco.com

2021-11-03T01:08:01+00:00

b8ad7d2ca1abc59e42e63ecf484036d021a2e19c












Fix 1461: Better loop breaker for `manifest_maker`
2021-11-01T20:50:58+00:00

Anderson Bravalheri
andersonbravalheri@gmail.com

2021-11-01T19:47:33+00:00

2e66eb7147ae1e8a799b2276c7340f48f63a7220

The inconsistency for the `package_data` configuration in sdists
when `include_package_data=True` in #1461 have been causing some
problems for the community for a while, as also shown in #2835.

As pointed out by
[@jaraco](https://github.com/pypa/setuptools/issues/1461#issuecomment-749092366),
this was being caused by a mechanism to break the recursion between the
`egg_info` and `sdist` commands.

In summary the loop is caused by the following behaviour:

- the `egg_info` command uses a subclass of `sdist` (`manifest_maker`)
  to calculate the MANIFEST,
- the `sdist` class needs to know the MANIFEST to calculate the data files when
  `include_package_data=True`

Previously, the mechanism to break this loop was to simply ignore
the data files in `sdist` when `include_package_data=True`.

The approach implemented in this change was to replace this mechanism,
by allowing `manifest_maker` to override the `_safe_data_files` method
from `sdist`.

---

Please notice [an extensive experiment]
(https://github.com/abravalheri/experiment-setuptools-package-data)
was carried out to investigate the previous confusing behaviour.

There is also [a simplified theoretical analysis]
(https://github.com/pyscaffold/pyscaffold/pull/535#issuecomment-956296407)
comparing the observed behavior in the experiment and the expected
one. This analysis point out to the same offender indicated by
[@jaraco](https://github.com/pypa/setuptools/issues/1461#issuecomment-749092366)
(which is being replaced in this change).





The inconsistency for the `package_data` configuration in sdists
when `include_package_data=True` in #1461 have been causing some
problems for the community for a while, as also shown in #2835.

As pointed out by
[@jaraco](https://github.com/pypa/setuptools/issues/1461#issuecomment-749092366),
this was being caused by a mechanism to break the recursion between the
`egg_info` and `sdist` commands.

In summary the loop is caused by the following behaviour:

- the `egg_info` command uses a subclass of `sdist` (`manifest_maker`)
  to calculate the MANIFEST,
- the `sdist` class needs to know the MANIFEST to calculate the data files when
  `include_package_data=True`

Previously, the mechanism to break this loop was to simply ignore
the data files in `sdist` when `include_package_data=True`.

The approach implemented in this change was to replace this mechanism,
by allowing `manifest_maker` to override the `_safe_data_files` method
from `sdist`.

---

Please notice [an extensive experiment]
(https://github.com/abravalheri/experiment-setuptools-package-data)
was carried out to investigate the previous confusing behaviour.

There is also [a simplified theoretical analysis]
(https://github.com/pyscaffold/pyscaffold/pull/535#issuecomment-956296407)
comparing the observed behavior in the experiment and the expected
one. This analysis point out to the same offender indicated by
[@jaraco](https://github.com/pypa/setuptools/issues/1461#issuecomment-749092366)
(which is being replaced in this change).