delta/python-packages/zope-interface.git/src, branch issue208 github.com: zopefoundation/zope.interface.git Fix interface definitions of IAdapterRegistry.subscribe, subscribers and subscriptions. 2020-04-23T11:11:50+00:00 Jason Madden jamadden@gmail.com 2020-04-23T11:11:50+00:00 5da431f3d2e5c6bda451bfcce6719e7a936a11fb They were defined to accept a name argument, but the actual implementation doesn't. Add tests for this. Fixes #208. Also in test_adapter.py modernize idioms from assertTrue(x in y) and assertTrue(x is y) to assertIn and assertIs. 
They were defined to accept a name argument, but the actual implementation doesn't. Add tests for this. Fixes #208.

Also in test_adapter.py modernize idioms from assertTrue(x in y) and assertTrue(x is y) to assertIn and assertIs.
Merge pull request #203 from zopefoundation/issue199 2020-04-08T12:18:08+00:00 Jason Madden jamadden@gmail.com 2020-04-08T12:18:08+00:00 76203ebcd3736f598fc858bf53de9738ae523858 Make @implementer and classImplements not add redundant interfaces 
Make @implementer and classImplements not add redundant interfaces
 Merge pull request #205 from zopefoundation/issue204 2020-04-07T18:52:38+00:00 Jason Madden jamadden@gmail.com 2020-04-07T18:52:38+00:00 bf4f437b0c6f453a8832624f6202b72f62b9e507 The ImmutableDeclaration also has immutable _v_attrs. 
The ImmutableDeclaration also has immutable _v_attrs.
 Minor cleanup of #202. 2020-04-07T14:23:10+00:00 Jason Madden jamadden@gmail.com 2020-04-07T14:23:10+00:00 bcfa537ee0159d0cb402a2f4751ed50dfe4bd659 See https://github.com/zopefoundation/zope.interface/pull/202#pullrequestreview-389126705 
See https://github.com/zopefoundation/zope.interface/pull/202#pullrequestreview-389126705
The ImmutableDeclaration also has immutable _v_attrs. 2020-04-07T12:56:48+00:00 Jason Madden jamadden@gmail.com 2020-04-07T12:56:48+00:00 c500360aaba5db30e5005664d14659ed7d8186ec Fixes #204 
Fixes #204
Fix implementerOnly when duplicating something inherited from the parent. 2020-04-07T12:32:06+00:00 Jason Madden jamadden@gmail.com 2020-04-06T16:53:21+00:00 97c0fbc4a3a532d1b2ec044994422d1a4ada4754 Seen in plone.app.testing as a problem in Products.GenericSetup. Added tests for that. 
Seen in plone.app.testing as a problem in Products.GenericSetup.

Added tests for that.
Special case the base Interface in @implementer/classImplements to skip the redundancy detection for the sake of plone.app.caching. 2020-04-07T12:32:06+00:00 Jason Madden jamadden@gmail.com 2020-04-06T16:17:50+00:00 4cb3e63d3f45f0d4337bf890ec8508c3072be772 






Make @implementer and classImplements not re-declare redundant interfaces.
2020-04-07T12:32:06+00:00

Jason Madden
jamadden@gmail.com

2020-04-06T12:57:12+00:00

46781f87ccbc02ae3d884e2dbe57b799c3804077

classImplementsOnly and @implementer_only can still be used to do that.





classImplementsOnly and @implementer_only can still be used to do that.







Feedback from review: whitespace, doc clarification, and a unit test showing the precedence of __conform__ vs __adapt__.
2020-04-07T12:04:44+00:00

Jason Madden
jamadden@gmail.com

2020-04-07T12:04:44+00:00

b1807049d47afef711c467b785fae6aab7be851a












Let interface 'subclasses' override __adapt__.
2020-04-06T14:14:45+00:00

Jason Madden
jamadden@gmail.com

2020-04-03T14:55:43+00:00

10eadd6305ee57910dbcc508b293f4bf0364fd84

Cooperate with InterfaceClass to ensure there is no performance penalty for this. Fixes #3

+-------------------------------------------------------------+----------------+------------------------------+------------------------------+
| Benchmark                                                   | bench_master38 | bench_issue3                 | bench_issue3_opt             |
+=============================================================+================+==============================+==============================+
| call interface (provides; deep)                             | 369 ns         | 454 ns: 1.23x slower (+23%)  | not significant              |
+-------------------------------------------------------------+----------------+------------------------------+------------------------------+
| call interface (provides; wide)                             | 373 ns         | 457 ns: 1.22x slower (+22%)  | 365 ns: 1.02x faster (-2%)   |
+-------------------------------------------------------------+----------------+------------------------------+------------------------------+
| call interface (no alternate, no conform, not provided)     | 671 ns         | 760 ns: 1.13x slower (+13%)  | 636 ns: 1.06x faster (-5%)   |
+-------------------------------------------------------------+----------------+------------------------------+------------------------------+
| call interface (alternate, no conform, not provided)        | 395 ns         | 494 ns: 1.25x slower (+25%)  | not significant              |
+-------------------------------------------------------------+----------------+------------------------------+------------------------------+
| call interface (no alternate, valid conform, not provided)  | 250 ns         | not significant              | 227 ns: 1.10x faster (-9%)   |
+-------------------------------------------------------------+----------------+------------------------------+------------------------------+
| call interface (alternate, invalid conform, not provided)   | 348 ns         | 424 ns: 1.22x slower (+22%)  | not significant              |
+-------------------------------------------------------------+----------------+------------------------------+------------------------------+





Cooperate with InterfaceClass to ensure there is no performance penalty for this. Fixes #3

+-------------------------------------------------------------+----------------+------------------------------+------------------------------+
| Benchmark                                                   | bench_master38 | bench_issue3                 | bench_issue3_opt             |
+=============================================================+================+==============================+==============================+
| call interface (provides; deep)                             | 369 ns         | 454 ns: 1.23x slower (+23%)  | not significant              |
+-------------------------------------------------------------+----------------+------------------------------+------------------------------+
| call interface (provides; wide)                             | 373 ns         | 457 ns: 1.22x slower (+22%)  | 365 ns: 1.02x faster (-2%)   |
+-------------------------------------------------------------+----------------+------------------------------+------------------------------+
| call interface (no alternate, no conform, not provided)     | 671 ns         | 760 ns: 1.13x slower (+13%)  | 636 ns: 1.06x faster (-5%)   |
+-------------------------------------------------------------+----------------+------------------------------+------------------------------+
| call interface (alternate, no conform, not provided)        | 395 ns         | 494 ns: 1.25x slower (+25%)  | not significant              |
+-------------------------------------------------------------+----------------+------------------------------+------------------------------+
| call interface (no alternate, valid conform, not provided)  | 250 ns         | not significant              | 227 ns: 1.10x faster (-9%)   |
+-------------------------------------------------------------+----------------+------------------------------+------------------------------+
| call interface (alternate, invalid conform, not provided)   | 348 ns         | 424 ns: 1.22x slower (+22%)  | not significant              |
+-------------------------------------------------------------+----------------+------------------------------+------------------------------+