delta/python-packages/zope-interface.git/src/zope/interface/tests/test_declarations.py, branch issue199 github.com: zopefoundation/zope.interface.git Fix implementerOnly when duplicating something inherited from the parent. 2020-04-07T12:32:06+00:00 Jason Madden jamadden@gmail.com 2020-04-06T16:53:21+00:00 97c0fbc4a3a532d1b2ec044994422d1a4ada4754 Seen in plone.app.testing as a problem in Products.GenericSetup. Added tests for that. 
Seen in plone.app.testing as a problem in Products.GenericSetup.

Added tests for that.
Special case the base Interface in @implementer/classImplements to skip the redundancy detection for the sake of plone.app.caching. 2020-04-07T12:32:06+00:00 Jason Madden jamadden@gmail.com 2020-04-06T16:17:50+00:00 4cb3e63d3f45f0d4337bf890ec8508c3072be772 






Make @implementer and classImplements not re-declare redundant interfaces.
2020-04-07T12:32:06+00:00

Jason Madden
jamadden@gmail.com

2020-04-06T12:57:12+00:00

46781f87ccbc02ae3d884e2dbe57b799c3804077

classImplementsOnly and @implementer_only can still be used to do that.





classImplementsOnly and @implementer_only can still be used to do that.







Let interface 'subclasses' override __adapt__.
2020-04-06T14:14:45+00:00

Jason Madden
jamadden@gmail.com

2020-04-03T14:55:43+00:00

10eadd6305ee57910dbcc508b293f4bf0364fd84

Cooperate with InterfaceClass to ensure there is no performance penalty for this. Fixes #3

+-------------------------------------------------------------+----------------+------------------------------+------------------------------+
| Benchmark                                                   | bench_master38 | bench_issue3                 | bench_issue3_opt             |
+=============================================================+================+==============================+==============================+
| call interface (provides; deep)                             | 369 ns         | 454 ns: 1.23x slower (+23%)  | not significant              |
+-------------------------------------------------------------+----------------+------------------------------+------------------------------+
| call interface (provides; wide)                             | 373 ns         | 457 ns: 1.22x slower (+22%)  | 365 ns: 1.02x faster (-2%)   |
+-------------------------------------------------------------+----------------+------------------------------+------------------------------+
| call interface (no alternate, no conform, not provided)     | 671 ns         | 760 ns: 1.13x slower (+13%)  | 636 ns: 1.06x faster (-5%)   |
+-------------------------------------------------------------+----------------+------------------------------+------------------------------+
| call interface (alternate, no conform, not provided)        | 395 ns         | 494 ns: 1.25x slower (+25%)  | not significant              |
+-------------------------------------------------------------+----------------+------------------------------+------------------------------+
| call interface (no alternate, valid conform, not provided)  | 250 ns         | not significant              | 227 ns: 1.10x faster (-9%)   |
+-------------------------------------------------------------+----------------+------------------------------+------------------------------+
| call interface (alternate, invalid conform, not provided)   | 348 ns         | 424 ns: 1.22x slower (+22%)  | not significant              |
+-------------------------------------------------------------+----------------+------------------------------+------------------------------+





Cooperate with InterfaceClass to ensure there is no performance penalty for this. Fixes #3

+-------------------------------------------------------------+----------------+------------------------------+------------------------------+
| Benchmark                                                   | bench_master38 | bench_issue3                 | bench_issue3_opt             |
+=============================================================+================+==============================+==============================+
| call interface (provides; deep)                             | 369 ns         | 454 ns: 1.23x slower (+23%)  | not significant              |
+-------------------------------------------------------------+----------------+------------------------------+------------------------------+
| call interface (provides; wide)                             | 373 ns         | 457 ns: 1.22x slower (+22%)  | 365 ns: 1.02x faster (-2%)   |
+-------------------------------------------------------------+----------------+------------------------------+------------------------------+
| call interface (no alternate, no conform, not provided)     | 671 ns         | 760 ns: 1.13x slower (+13%)  | 636 ns: 1.06x faster (-5%)   |
+-------------------------------------------------------------+----------------+------------------------------+------------------------------+
| call interface (alternate, no conform, not provided)        | 395 ns         | 494 ns: 1.25x slower (+25%)  | not significant              |
+-------------------------------------------------------------+----------------+------------------------------+------------------------------+
| call interface (no alternate, valid conform, not provided)  | 250 ns         | not significant              | 227 ns: 1.10x faster (-9%)   |
+-------------------------------------------------------------+----------------+------------------------------+------------------------------+
| call interface (alternate, invalid conform, not provided)   | 348 ns         | 424 ns: 1.22x slower (+22%)  | not significant              |
+-------------------------------------------------------------+----------------+------------------------------+------------------------------+







Remove the bare except: statements.
2020-04-02T12:53:05+00:00

Jason Madden
jamadden@gmail.com

2020-04-02T12:53:05+00:00

84872a8d2ab6b980aebc1c3c1ffb6aee9cf97ea5

Only catch AttributeError instead of everything.

Fixes #200

Note that this does break a doctest in five.intid (it's expecting a TypeError but it now gets Acquisition's RuntimeError).





Only catch AttributeError instead of everything.

Fixes #200

Note that this does break a doctest in five.intid (it's expecting a TypeError but it now gets Acquisition's RuntimeError).







Ensure that objects that implement no interfaces still have Interface in their iro and sro.
2020-03-30T13:55:56+00:00

Jason Madden
jamadden@gmail.com

2020-03-30T13:55:56+00:00

bfedd6f58706810ee5bac3c0d08650dcac30c215

Fixes #197.





Fixes #197.







Update comments and add a test for more coverage.
2020-03-19T11:54:33+00:00

Jason Madden
jamadden@gmail.com

2020-03-19T11:54:33+00:00

42c5ad2d4f88610bb89d35152c1caa1c52dc6927












Add tests for comparing InterfaceClass/Implements objects to things without the required attributes.
2020-03-18T17:28:13+00:00

Jason Madden
jamadden@gmail.com

2020-03-12T12:34:55+00:00

a2687a64253c76b0d7452d102f521e7f680b5306

And fix the C handling of this case.





And fix the C handling of this case.







Use C3 (mostly) to compute IRO.
2020-03-15T14:56:14+00:00

Jason Madden
jamadden@gmail.com

2020-03-05T20:38:39+00:00

024f6432270afd021da2d9fff5c3f496f788e54d

Fixes #21

The 'mostly' is because interfaces are used in cases that C3 forbids;
when there's a conflict, we fallback to the legacy algorithm. It turns
out there are few conflicts (13K out of 149K total orderings in Plone).

I hoped the fix for #8 might shake out automatically, but it didn't.

Optimize the extremely common case of a __bases__ of length one.

In the benchmark, 4/5 of the interfaces and related objects have a base of length one.

Fix the bad IROs in the bundled ABC interfaces, and implement a way to get warnings or errors.

In running plone/buildout.coredev and tracking the RO requests, the
stats for equal, not equal, and inconsistent-so-fallback, I got
{'ros': 148868, 'eq': 138461, 'ne': 10407, 'inconsistent': 12934}

Add the interface module to the Attribute str.

This was extremely helpful tracking down the Plone problem; IDate is defined in multiple modules.





Fixes #21

The 'mostly' is because interfaces are used in cases that C3 forbids;
when there's a conflict, we fallback to the legacy algorithm. It turns
out there are few conflicts (13K out of 149K total orderings in Plone).

I hoped the fix for #8 might shake out automatically, but it didn't.

Optimize the extremely common case of a __bases__ of length one.

In the benchmark, 4/5 of the interfaces and related objects have a base of length one.

Fix the bad IROs in the bundled ABC interfaces, and implement a way to get warnings or errors.

In running plone/buildout.coredev and tracking the RO requests, the
stats for equal, not equal, and inconsistent-so-fallback, I got
{'ros': 148868, 'eq': 138461, 'ne': 10407, 'inconsistent': 12934}

Add the interface module to the Attribute str.

This was extremely helpful tracking down the Plone problem; IDate is defined in multiple modules.







Make provided/implementedBy and adapter registries respect super().
2020-03-09T17:51:18+00:00

Jason Madden
jamadden@gmail.com

2020-03-05T15:52:35+00:00

1e720c3819b8daa07aaad0ee0258d9035597f27d

The query functions now start by looking at the next class in the MRO (interfaces directly provided by the underlying object are not found).

Adapter registries automatically pick up providedBy change to start finding the correct implementations of adapters, but to make that really useful they needed to change to unpack super() arguments and pass __self__ to the factory.

Fixes #11

Unfortunately, this makes PyPy unable to build the C extensions.

Additional crash-safety for adapter lookup.

Make the C functions get the cache only after resolving the
``required`` into a tuple, in case of side-effects like...clearing the
cache. This could lead to the ``cache`` object being deallocated
before we used it.

Drop the ``tuplefy`` function in favor of a direct call to
``PySequence_Tuple``. It's what the ``tuple`` constructor would do
anyway and saves a few steps.

Make sure that getting ``providedBy(super())`` and
``implementedBy(super())`` have no side effects.





The query functions now start by looking at the next class in the MRO (interfaces directly provided by the underlying object are not found).

Adapter registries automatically pick up providedBy change to start finding the correct implementations of adapters, but to make that really useful they needed to change to unpack super() arguments and pass __self__ to the factory.

Fixes #11

Unfortunately, this makes PyPy unable to build the C extensions.

Additional crash-safety for adapter lookup.

Make the C functions get the cache only after resolving the
``required`` into a tuple, in case of side-effects like...clearing the
cache. This could lead to the ``cache`` object being deallocated
before we used it.

Drop the ``tuplefy`` function in favor of a direct call to
``PySequence_Tuple``. It's what the ``tuple`` constructor would do
anyway and saves a few steps.

Make sure that getting ``providedBy(super())`` and
``implementedBy(super())`` have no side effects.