From 7d5fe9ae5cb8177171cd67f5728c2b6f35f5703b Mon Sep 17 00:00:00 2001 From: Kyle Stewart <4b796c65+bitbucket@gmail.com> Date: Thu, 17 Mar 2016 22:41:40 -0700 Subject: Have the ZipFile handle the file descriptor in make_wheelfile_inner. If you make a ZipFile from an open file then you need to close both objects. --- wheel/archive.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/wheel/archive.py b/wheel/archive.py index f928e6a..fa30a70 100644 --- a/wheel/archive.py +++ b/wheel/archive.py @@ -43,8 +43,7 @@ def make_wheelfile_inner(base_name, base_dir='.'): date_time = time.gmtime(int(timestamp))[0:6] # XXX support bz2, xz when available - zip = zipfile.ZipFile(open(zip_filename, "wb+"), "w", - compression=zipfile.ZIP_DEFLATED) + zip = zipfile.ZipFile(zip_filename, "w", compression=zipfile.ZIP_DEFLATED) score = {'WHEEL': 1, 'METADATA': 2, 'RECORD': 3} deferred = [] -- cgit v1.2.1