From 86ef507cc73ee4a0a104b334d7ce08ad045e0c76 Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Mon, 4 Jul 2016 15:54:29 -0400 Subject: Double percent signs based on paramstyle, not dialect This patch moves the "doubling" of percent signs into the base compiler and makes it completely a product of whether or not the paramstyle is format/pyformat or not. Without this paramstyle, percent signs are not doubled across text(), literal_column(), and column(). Change-Id: Ie2f278ab1dbb94b5078f85c0096d74dbfa049197 Fixes: #3740 --- test/sql/test_quote.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'test/sql/test_quote.py') diff --git a/test/sql/test_quote.py b/test/sql/test_quote.py index a436dde67..477fca783 100644 --- a/test/sql/test_quote.py +++ b/test/sql/test_quote.py @@ -1,12 +1,12 @@ -from sqlalchemy import * +from sqlalchemy import MetaData, Table, Column, Integer, select, \ + ForeignKey, Index, CheckConstraint, inspect, column from sqlalchemy import sql, schema from sqlalchemy.sql import compiler from sqlalchemy.testing import fixtures, AssertsCompiledSQL, eq_ from sqlalchemy import testing -from sqlalchemy.sql.elements import (quoted_name, - _truncated_label, - _anonymous_label) +from sqlalchemy.sql.elements import quoted_name, _anonymous_label from sqlalchemy.testing.util import picklers +from sqlalchemy.engine import default class QuoteExecTest(fixtures.TestBase): @@ -700,7 +700,7 @@ class PreparerTest(fixtures.TestBase): """Test the db-agnostic quoting services of IdentifierPreparer.""" def test_unformat(self): - prep = compiler.IdentifierPreparer(None) + prep = compiler.IdentifierPreparer(default.DefaultDialect()) unformat = prep.unformat_identifiers def a_eq(have, want): @@ -732,7 +732,7 @@ class PreparerTest(fixtures.TestBase): def _unescape_identifier(self, value): return value.replace('``', '`') - prep = Custom(None) + prep = Custom(default.DefaultDialect()) unformat = prep.unformat_identifiers def a_eq(have, want): -- cgit v1.2.1