From 5221f492ca704d75561d7729fba0fa48fd3ad0fb Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Fri, 27 Jan 2012 21:19:26 -0500 Subject: - [bug] Added a boolean check for the "finalize" function within the pool connection proxy's weakref callback before calling it, so that a warning isn't emitted that this function is None when the application is exiting and gc has removed the function from the module before the weakref callback was invoked. [ticket:2383] --- lib/sqlalchemy/pool.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib') diff --git a/lib/sqlalchemy/pool.py b/lib/sqlalchemy/pool.py index 7b87cafa9..a615e8c60 100644 --- a/lib/sqlalchemy/pool.py +++ b/lib/sqlalchemy/pool.py @@ -372,7 +372,7 @@ class _ConnectionFairy(object): conn = self.connection = self._connection_record.get_connection() rec.fairy = weakref.ref( self, - lambda ref:_finalize_fairy(conn, rec, pool, ref, _echo) + lambda ref:_finalize_fairy and _finalize_fairy(conn, rec, pool, ref, _echo) ) _refs.add(rec) except: -- cgit v1.2.1