From 42812c06c182b236f491cb33315527a54fcba002 Mon Sep 17 00:00:00 2001 From: Jonathan Ellis Date: Fri, 3 Aug 2007 04:49:34 +0000 Subject: add comment, intermediate var for readability --- lib/sqlalchemy/topological.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'lib/sqlalchemy/topological.py') diff --git a/lib/sqlalchemy/topological.py b/lib/sqlalchemy/topological.py index 56c8cb46e..dcfe9ea71 100644 --- a/lib/sqlalchemy/topological.py +++ b/lib/sqlalchemy/topological.py @@ -307,9 +307,9 @@ class QueueDependencySorter(object): for parent in edges.get_parents(): traverse(parent) - for cycle in dict([(id(s), s) for s in cycles.values()]).values(): - edgecollection = [] - for edge in edges: - if edge[0] in cycle and edge[1] in cycle: - edgecollection.append(edge) + # sets are not hashable, so uniquify with id + unique_cycles = dict([(id(s), s) for s in cycles.values()]).values() + for cycle in unique_cycles: + edgecollection = [edge for edge in edges + if edge[0] in cycle and edge[1] in cycle] yield edgecollection -- cgit v1.2.1