From d79e1d69a6b2d0d1cc18d3d9d0283ef4a77925bc Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Sat, 5 Oct 2013 23:47:49 -0400 Subject: - fix propagation of quote flag within _gen_label() so that if the name is already an instance of _anonymous_label(), we don't downgrade it to a plain quoted_name - fixes regression from [ticket:2812]. [ticket:2834] --- lib/sqlalchemy/sql/elements.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) (limited to 'lib/sqlalchemy/sql') diff --git a/lib/sqlalchemy/sql/elements.py b/lib/sqlalchemy/sql/elements.py index ea2132e67..73a8a0b82 100644 --- a/lib/sqlalchemy/sql/elements.py +++ b/lib/sqlalchemy/sql/elements.py @@ -2018,6 +2018,7 @@ class ColumnClause(Immutable, ColumnElement): def _gen_label(self, name): t = self.table + if self.is_literal: return None @@ -2030,8 +2031,14 @@ class ColumnClause(Immutable, ColumnElement): # propagate name quoting rules for labels. if getattr(name, "quote", None) is not None: - label = quoted_name(label, name.quote) + if isinstance(label, quoted_name): + label.quote = name.quote + else: + label = quoted_name(label, name.quote) elif getattr(t.name, "quote", None) is not None: + # can't get this situation to occur, so let's + # assert false on it for now + assert not isinstance(label, quoted_name) label = quoted_name(label, t.name.quote) # ensure the label name doesn't conflict with that -- cgit v1.2.1