From 8822d832679cdc13bb631dd221d0f5932f6540c7 Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Wed, 21 Jul 2021 15:44:27 -0400 Subject: Apply new uniquing rules for future ORM selects Fixed issue where usage of the :meth:`_result.Result.unique` method with an ORM result that included column expressions with unhashable types, such as ``JSON`` or ``ARRAY`` using non-tuples would silently fall back to using the ``id()`` function, rather than raising an error. This now raises an error when the :meth:`_result.Result.unique` method is used in a 2.0 style ORM query. Additionally, hashability is assumed to be True for result values of unknown type, such as often happens when using SQL functions of unknown return type; if values are truly not hashable then the ``hash()`` itself will raise. For legacy ORM queries, since the legacy :class:`_orm.Query` object uniquifies in all cases, the old rules remain in place, which is to use ``id()`` for result values of unknown type as this legacy uniquing is mostly for the purpose of uniquing ORM entities and not column values. Fixes: #6769 Change-Id: I5747f706f1e97c78867b5cf28c73360497273808 --- lib/sqlalchemy/sql/sqltypes.py | 2 -- 1 file changed, 2 deletions(-) (limited to 'lib/sqlalchemy/sql') diff --git a/lib/sqlalchemy/sql/sqltypes.py b/lib/sqlalchemy/sql/sqltypes.py index 1b05465c9..44431d38f 100644 --- a/lib/sqlalchemy/sql/sqltypes.py +++ b/lib/sqlalchemy/sql/sqltypes.py @@ -3184,8 +3184,6 @@ class NullType(TypeEngine): _isnull = True - hashable = False - def literal_processor(self, dialect): def process(value): raise exc.CompileError( -- cgit v1.2.1