From 04fbb9e63c098dd2de40b545eed210dfd93893ce Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Fri, 27 Dec 2019 15:02:31 -0500 Subject: Test for short term reference cycles and resolve as many as possible Added test support and repaired a wide variety of unnecessary reference cycles created for short-lived objects, mostly in the area of ORM queries. Fixes: #5056 Change-Id: Ifd93856eba550483f95f9ae63d49f36ab068b85a --- lib/sqlalchemy/sql/selectable.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'lib/sqlalchemy/sql/selectable.py') diff --git a/lib/sqlalchemy/sql/selectable.py b/lib/sqlalchemy/sql/selectable.py index ed7a6c2b9..428acae6c 100644 --- a/lib/sqlalchemy/sql/selectable.py +++ b/lib/sqlalchemy/sql/selectable.py @@ -3695,10 +3695,10 @@ class Select( clone(f, **kw) for f in self._from_obj ).union(f for f in new_froms.values() if isinstance(f, Join)) - self._correlate = set(clone(f) for f in self._correlate) + self._correlate = set(clone(f, **kw) for f in self._correlate) if self._correlate_except: self._correlate_except = set( - clone(f) for f in self._correlate_except + clone(f, **kw) for f in self._correlate_except ) # 4. clone other things. The difficulty here is that Column -- cgit v1.2.1