From ef2859bbc8bb8104bf4e429a52efb50a712d834a Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Wed, 14 Mar 2018 11:04:43 -0400 Subject: Track if we're rendering within the CTE recursively Fixed a regression that occurred from the previous fix to :ticket:`4204` in version 1.2.5, where a CTE that refers to itself after the :meth:`.CTE.alias` method has been called would not refer to iself correctly. Change-Id: Iaa63d65ad2b90c8693f9953fbb32dbb10c73a037 Fixes: #4204 --- lib/sqlalchemy/sql/compiler.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) (limited to 'lib/sqlalchemy/sql/compiler.py') diff --git a/lib/sqlalchemy/sql/compiler.py b/lib/sqlalchemy/sql/compiler.py index 438484f33..6c7e6145d 100644 --- a/lib/sqlalchemy/sql/compiler.py +++ b/lib/sqlalchemy/sql/compiler.py @@ -1346,18 +1346,23 @@ class SQLCompiler(Compiled): return self.bindtemplate % {'name': name} def visit_cte(self, cte, asfrom=False, ashint=False, - fromhints=None, + fromhints=None, visiting_cte=None, **kwargs): self._init_cte_state() + kwargs['visiting_cte'] = cte if isinstance(cte.name, elements._truncated_label): cte_name = self._truncated_identifier("alias", cte.name) else: cte_name = cte.name is_new_cte = True + embedded_in_current_named_cte = False + if cte_name in self.ctes_by_name: existing_cte = self.ctes_by_name[cte_name] + embedded_in_current_named_cte = visiting_cte is existing_cte + # we've generated a same-named CTE that we are enclosed in, # or this is the same CTE. just return the name. if cte in existing_cte._restates or cte is existing_cte: @@ -1431,6 +1436,9 @@ class SQLCompiler(Compiled): self.ctes[cte] = text if asfrom: + if not is_new_cte and embedded_in_current_named_cte: + return self.preparer.format_alias(cte, cte_name) + if cte_pre_alias_name: text = self.preparer.format_alias(cte, cte_pre_alias_name) if self.preparer._requires_quotes(cte_name): -- cgit v1.2.1