From d216298073ac6657728bdeb56598f3e5124e2d67 Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Sat, 23 Apr 2011 10:45:11 -0700 Subject: - metadata.reflect() and reflection.Inspector() had some reliance on GC to close connections which were internally procured, fixed this. - added --zero-timeout option to nose fixture, sets pool_timeout to zero --- lib/sqlalchemy/engine/reflection.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'lib/sqlalchemy/engine') diff --git a/lib/sqlalchemy/engine/reflection.py b/lib/sqlalchemy/engine/reflection.py index 72eb27c4e..ca4360325 100644 --- a/lib/sqlalchemy/engine/reflection.py +++ b/lib/sqlalchemy/engine/reflection.py @@ -80,10 +80,6 @@ class Inspector(object): :meth:`Inspector.from_engine` """ - - # ensure initialized - bind.connect() - # this might not be a connection, it could be an engine. self.bind = bind @@ -92,6 +88,11 @@ class Inspector(object): self.engine = bind.engine else: self.engine = bind + + if self.engine is bind: + # if engine, ensure initialized + bind.connect().close() + self.dialect = self.engine.dialect self.info_cache = {} -- cgit v1.2.1