From 8e10ab92df0d8b5d24474e00d6628d2de94b900c Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Sat, 22 Mar 2014 19:02:37 -0400 Subject: - restore the old behavior of the connection pool replacing itself just within userland engine.dispose(); as some SQLA tests already failed when the replace step was removed, due to those conns still being referenced, it's likely this will create surprises for all those users that incorrectly use dispose() and it's not really worth dealing with. This doesn't affect the change we made for ref: #2985. --- lib/sqlalchemy/engine/base.py | 1 + 1 file changed, 1 insertion(+) (limited to 'lib/sqlalchemy/engine') diff --git a/lib/sqlalchemy/engine/base.py b/lib/sqlalchemy/engine/base.py index 2cad2a094..4a8719c6b 100644 --- a/lib/sqlalchemy/engine/base.py +++ b/lib/sqlalchemy/engine/base.py @@ -1502,6 +1502,7 @@ class Engine(Connectable, log.Identified): """ self.pool.dispose() + self.pool = self.pool.recreate() def _execute_default(self, default): with self.contextual_connect() as conn: -- cgit v1.2.1