From 2644693c0bf5b775f7a7283cdbf566a37872586f Mon Sep 17 00:00:00 2001 From: Miguel Grinberg Date: Thu, 21 May 2020 05:54:47 -0400 Subject: Fix query string escaping in engine URLs Fixed issue in :class:`.URL` object where stringifying the object would not URL encode special characters, preventing the URL from being re-consumable as a real URL. Pull request courtesy Miguel Grinberg. Fixes: #5341 Closes: #5342 Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/5342 Pull-request-sha: 362ca3398336a3a892e8020530f0c68d4f2d1d01 Change-Id: Ief6218122d1ec0c70479eb1a90e1c16433801924 --- lib/sqlalchemy/engine/url.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib/sqlalchemy/engine') diff --git a/lib/sqlalchemy/engine/url.py b/lib/sqlalchemy/engine/url.py index 5950fa021..7b7a0047c 100644 --- a/lib/sqlalchemy/engine/url.py +++ b/lib/sqlalchemy/engine/url.py @@ -96,7 +96,7 @@ class URL(object): keys = list(self.query) keys.sort() s += "?" + "&".join( - "%s=%s" % (k, element) + "%s=%s" % (util.quote_plus(k), util.quote_plus(element)) for k in keys for element in util.to_list(self.query[k]) ) -- cgit v1.2.1